Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Sasha Levin <sashal@kernel.org>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "stable@vger.kernel.org" <stable@vger.kernel.org>,
        "David S . Miller" <davem@davemloft.net>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        "alexandre.belloni@bootlin.com" <alexandre.belloni@bootlin.com>,
        "UNGLinuxDriver@microchip.com" <UNGLinuxDriver@microchip.com>,
        "edumazet@google.com" <edumazet@google.com>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH AUTOSEL 5.19 34/73] net: mscc: ocelot: report FIFO drop
 counters through stats->rx_dropped
Thread-Topic: [PATCH AUTOSEL 5.19 34/73] net: mscc: ocelot: report FIFO drop
 counters through stats->rx_dropped
Thread-Index: AQHY3Czle6uZNn/1Fk2h6S84nLKWJK4Hhs0A
Date:   Mon, 10 Oct 2022 11:58:15 +0000
Message-ID: <20221010115814.7zag4ivzuwh4psm7@skbuf>
References: <20221009221453.1216158-1-sashal@kernel.org>
 <20221009221453.1216158-34-sashal@kernel.org>
In-Reply-To: <20221009221453.1216158-34-sashal@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?CiL7ZhgQNAj+GedPsiJWeDrK4pwJQoDNOKrJDBQ3TyGLm8XKteATorPBCobR?=
 =?us-ascii?Q?EOyI98/vlNkOmDw27htFVoVcr8kn2Meje2GiuSRDLWpb8VYjFUCiRO76CjgW?=
 =?us-ascii?Q?Q5s0YQKzJRuzcpDNBZHp6ygYaQUtV+sZ9GNP+hYVTanXoGU0P+hcpDsqkD8H?=
 =?us-ascii?Q?HqsJA+81gfLOhqUn4wXxZvtGrWDCiomEGq7NCxjUHA4jmyTwWezJPTp7XFP1?=
 =?us-ascii?Q?gzzTY4EZVY9OGaZe03fGmxLZcHMlRo8laVAM2g7nGnJulUEnbplGWX8MKRKu?=
 =?us-ascii?Q?kasJ+1wgRlRDvpEmYaJRs/g5cDPvUmJv5e+w63hTgUoO2xbjZviPaA2ikm81?=
 =?us-ascii?Q?NlMqhU5nx6x+1VYv2GnaoaqXigG2WlnIWUaYYAGX3ZwBXEX9FMUV+ckP5QvL?=
 =?us-ascii?Q?9o51XyM/4CKu+RAIqhl4oB55FFmGL3dmlWJ+4s3P3GLI35+pVOqDqE3rVVLa?=
 =?us-ascii?Q?Nl+hcp2AgL4RQABftkxSZht0R5SPN46OXaITXEr8o16j+5ZfGlEcL28PiAMe?=
 =?us-ascii?Q?+wyh6r0GPzHkMdyV/dFL7cptKSPSexrHmRGNqkHjw/yBeYd0pcBFoMrTK5FH?=
 =?us-ascii?Q?lzCrO3KkWUL+bVpTPIF+jXj5m3KuDABvTIAafwJ837Y7sgemT6FdtSKTDP/n?=
 =?us-ascii?Q?TVsjwvy1ICAE9u3pCLmsHfKuEWoqhpbMmzUPeRkj9n9bZjmAm71Ubm3ywtZk?=
 =?us-ascii?Q?Wqwz4iLrImDmG9rYBNMNOFyIMijPxSwfz+3BWTa0x3ke8iF7+2f7/MV7zzVv?=
 =?us-ascii?Q?bD2854O5FEDI2+NQeh1zG+xnRxsqrlSrP9WgJyLA7WtPpkHHzPBBTYoxXzt8?=
 =?us-ascii?Q?hqPyQIX9JYVuJ0VDAUUNbj3CWxbN12j7xEQBRXbr997Z8q/BJxdE1MUmq9Nk?=
 =?us-ascii?Q?jHC9NujEitTcCFnU1Qiuog7mch1hSIfaxQ0SkFrME0lA40rleOgQeUkY5hQi?=
 =?us-ascii?Q?3+dXOh/WIC//639r+aNQj1kOMI5GCcCpvJlDmKgduvjTTl0o7HYMQorbdHP8?=
 =?us-ascii?Q?piA2ZpZNyqgD+eNVDT5fn6YHjkcm+cBXdkdwug1nND1k2dtiHywXl6oLsVUn?=
 =?us-ascii?Q?qPg4bZLNmt7dc8gmFhFF9Rgm81zmg7CYStaiv2+Pal8Fcfm9fK/c4ONI1sW4?=
 =?us-ascii?Q?qG4DS2SsmeNhBNKOwHW2dE4na9Nq5nIdRfd44xsV66DbeC4FANiD4hL5A6AD?=
 =?us-ascii?Q?DrzMo8I9oZt3y6/peaks4uqBUItnIkk3CgKQ/7RBIEMv481slJoTfJhH/gkz?=
 =?us-ascii?Q?37sfwOpkpArmcxOvs53Pkx1hVszZp5Idw5dumTtstCeumJDptIe14igndA2c?=
 =?us-ascii?Q?z05g5N52qdbyjZgwyW3pdqit+wihWMA8yOlu/2wzLABLZsFGovX44/oq8H0a?=
 =?us-ascii?Q?zzcjZcQ1VdkhN1Cszm7D4ycr0Lt9RPtie4RhUc07vYMIyzvRyFehJoAROOwG?=
 =?us-ascii?Q?E0ER888KUE/dt4aSsvj/D4qa2NWlB/TULH8oEhEFwJh9nmKrwa4RLweSUHgK?=
 =?us-ascii?Q?MXQrhZjgVtVvPsps/QE2PEaYxzOAGyeu/0BIb0hCDFS4IP+WL2HV3CfxK2CL?=
 =?us-ascii?Q?ntb7y/ODer0P6BPuSS/fj62WCSRtHU+6JWU/89we683eLWVw3q6Pd/ZEtaor?=
 =?us-ascii?Q?+Q=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3A69548CC84ABD49AD0F376B7C14809E@eurprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 79d05b71-cd2d-4fc5-0100-08daaab6b69c
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Oct 2022 11:58:15.0637
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: SqtGbXqCHTmpbxi9Zm1Iiz1te+Wo4tUm8RTRG8NWjWIcbw/1hWkNmDHzDb7mx9GkOitcJ6hpNkdI3TXTidnQLQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8282
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, Oct 09, 2022 at 06:14:12PM -0400, Sasha Levin wrote:
> From: Vladimir Oltean <vladimir.oltean@nxp.com>
>=20
> [ Upstream commit cc160fc29a264726b2bfbc2f551081430db3df03 ]
>=20
> if_link.h says:
>=20
>  * @rx_dropped: Number of packets received but not processed,
>  *   e.g. due to lack of resources or unsupported protocol.
>  *   For hardware interfaces this counter may include packets discarded
>  *   due to L2 address filtering but should not include packets dropped
>  *   by the device due to buffer exhaustion which are counted separately =
in
>  *   @rx_missed_errors (since procfs folds those two counters together).
>=20
> Currently we report "stats->rx_dropped =3D dev->stats.rx_dropped", the
> latter being incremented by various entities in the stack. This is not
> wrong, but we'd like to move ocelot_get_stats64() in the common ocelot
> switch lib which is independent of struct net_device.
>=20
> To do that, report the hardware RX drop counters instead. These drops
> are due to policer action, or due to no destinations. When we have no
> memory in the queue system, report this through rx_missed_errors, as
> instructed.
>=20
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
> Signed-off-by: David S. Miller <davem@davemloft.net>
> Signed-off-by: Sasha Levin <sashal@kernel.org>
> ---

Not needed for stable kernels, please drop, thanks.=