Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Sasha Levin <sashal@kernel.org>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "stable@vger.kernel.org" <stable@vger.kernel.org>,
        "David S . Miller" <davem@davemloft.net>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        "alexandre.belloni@bootlin.com" <alexandre.belloni@bootlin.com>,
        "UNGLinuxDriver@microchip.com" <UNGLinuxDriver@microchip.com>,
        "edumazet@google.com" <edumazet@google.com>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH AUTOSEL 6.0 37/77] net: mscc: ocelot: report FIFO drop
 counters through stats->rx_dropped
Thread-Topic: [PATCH AUTOSEL 6.0 37/77] net: mscc: ocelot: report FIFO drop
 counters through stats->rx_dropped
Thread-Index: AQHY3CwA3dRF1Ay270ureL3kpCuWxa4HhouA
Date:   Mon, 10 Oct 2022 11:57:18 +0000
Message-ID: <20221010115717.opjh4nachlx53ded@skbuf>
References: <20221009220754.1214186-1-sashal@kernel.org>
 <20221009220754.1214186-37-sashal@kernel.org>
In-Reply-To: <20221009220754.1214186-37-sashal@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?6r5OBHeYEYcDxIa48o5A7W7+zOUA5Z/VND9XxLC+C6e6emeFQgqZgqQFoqBf?=
 =?us-ascii?Q?Rvai1jnBM2sf9VXDJYtcBMSUbFyw0EFzyNDpR/ZLGjvcV2N2zr9Xg6al/jn1?=
 =?us-ascii?Q?DsyF0xvw40kM5S+eMCc7YfzL11QK02/NtIjaMuxdURZ+tszMg6Wgin3Avt0/?=
 =?us-ascii?Q?JU3n1toAEquObEZ8SdKk5zqnkV6jfbB510OMQSa+bpfrpoZ9mD0VenJXLJN9?=
 =?us-ascii?Q?IWH59R4VR4Jugdb3n/tjM162mvdEIxvSXGqrzAz+O4iep+tRsuIwjLqi78Ge?=
 =?us-ascii?Q?7OK2xKsTEDPcdr6hrK794Vr5Emfuu89AhTDM3+g8tUbKzaJ9WpUC8AY92+HJ?=
 =?us-ascii?Q?Bvy7B999GPjo2i2ePgYaOaOtbMkd6LnkIxHx1DCramLh2cTosriMBDYfR9w6?=
 =?us-ascii?Q?dQjON6UGKWN0nHPXbOkzWuWecKf1dmYIbooY1LVLnc0uzY/D7148FPrja0th?=
 =?us-ascii?Q?QLvhBsZoe5NHW4Nxw2grbe2Mjk/7Gxo2jtGmV9ADvTHc+/ZeW3jaPIFAeerv?=
 =?us-ascii?Q?+FvrRb9wIdd3TJEtImIWcaRrf0//NBnbrSnb/yTeDzkNlY+reQGn5KbhDbw+?=
 =?us-ascii?Q?ZH8bNE2PfvMlK33+WwpVdHiT+GDSwDAxHF0QeVICMc/MQg2/qI8YQVKfMTwe?=
 =?us-ascii?Q?59NRS88LrY83h3LuMtOHUDifuBB0JvCCKHt9hqzhFNApXSVZTejtAlEfniW9?=
 =?us-ascii?Q?4FFFPP8W51DoA4bGie6jK2LPXVTUuM6beKJlIOFsY+k/feSog3/WvxzQ+QEU?=
 =?us-ascii?Q?ybeklcvaww7hdhwbYzXlrs7Zen+DxUk3z6S0P5ajegzQplbfkIPs3CqzF6Jj?=
 =?us-ascii?Q?+i/URxkOo6C2IfXyeeLsoeblmJMK2KNV9aXIbouNhswNdVIaQm4o27lis365?=
 =?us-ascii?Q?l3r68G5P7SfcM7n/n6HzEnOygO5RDiu5z1oY+1Stv4rwurGwoWxO+Pw7+qhC?=
 =?us-ascii?Q?I30pgyorttDm+sLmz1GPPHT4BCc1Kw6mCle8dSHeB35YpCt2ojbmvw13acXN?=
 =?us-ascii?Q?ypBvip/N5Slb2iIzTd5hH7yLL/OKdfLRqmp1N0PA19lfjaLGC+33ja+PMG0p?=
 =?us-ascii?Q?R+JSnv24uyl3Js+vKhSKFAvkBnKzmuACWZp85BLc+TTL82/ugLBoIQaw3lmC?=
 =?us-ascii?Q?EUrXlyJRoHfjH5xb+voqrJxMuQl1dhB/DoKcBBi5UvxfmO6pfgNq7hRDiZcw?=
 =?us-ascii?Q?jI8DqGrtT1R4C4zsPv9bKu3X5qVrSyBEHGfZ7hP+4evhWx94ShCc4nm08b3+?=
 =?us-ascii?Q?zB11GET8Om/DpqxV6uVW/v7Gy4Pr4jopF3DjhX6ACVlWVWV7+4AbT0GyyKo5?=
 =?us-ascii?Q?KCgIHTLGNPKPkR6+8QbBakRzzvdpV6zmvt/gVfK3DnXq+r7Y0gcuzZafmGJr?=
 =?us-ascii?Q?9zGbwzXtBt9+7CEB310oZxGZViIwNQjKz+t9S561vZU3u4VrM3YY1JBKT597?=
 =?us-ascii?Q?/kX56veWX38zCt3ZunszXms/ted8BQg5q94EM6xNVjAdMEHDt3ftAoyriR/y?=
 =?us-ascii?Q?XYgirqDTkv+6etsIy25ozIa1g/7fSWiC5XBHFLrtmDhMi5TUM2ORR3Bp1MoS?=
 =?us-ascii?Q?ynIqy5pPHkNk5Pj0sptgDL5++8MPDW7B54YgRALKDzQeGiZN52Gy8XJAy8i/?=
 =?us-ascii?Q?Cw=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <4A798329DD60634098DEEFD6ABD4B2C6@eurprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5e63ced7-b13c-4fde-4336-08daaab694aa
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Oct 2022 11:57:18.0833
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: +2Fp7nCvw1PJt9M7Pcos2LyTIpvf6fNNEW4PegsNAzOQF6XuWcGLms53UR2wnJPyr9pG2ABWbHbzQ2dHPPnsNg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8282
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, Oct 09, 2022 at 06:07:14PM -0400, Sasha Levin wrote:
> From: Vladimir Oltean <vladimir.oltean@nxp.com>
>=20
> [ Upstream commit cc160fc29a264726b2bfbc2f551081430db3df03 ]
>=20
> if_link.h says:
>=20
>  * @rx_dropped: Number of packets received but not processed,
>  *   e.g. due to lack of resources or unsupported protocol.
>  *   For hardware interfaces this counter may include packets discarded
>  *   due to L2 address filtering but should not include packets dropped
>  *   by the device due to buffer exhaustion which are counted separately =
in
>  *   @rx_missed_errors (since procfs folds those two counters together).
>=20
> Currently we report "stats->rx_dropped =3D dev->stats.rx_dropped", the
> latter being incremented by various entities in the stack. This is not
> wrong, but we'd like to move ocelot_get_stats64() in the common ocelot
> switch lib which is independent of struct net_device.
>=20
> To do that, report the hardware RX drop counters instead. These drops
> are due to policer action, or due to no destinations. When we have no
> memory in the queue system, report this through rx_missed_errors, as
> instructed.
>=20
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
> Signed-off-by: David S. Miller <davem@davemloft.net>
> Signed-off-by: Sasha Levin <sashal@kernel.org>
> ---

Not needed for stable kernels, please drop, thanks.=