Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 10 Oct 2022 12:19:23 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Siarhei Volkau <lis8215@gmail.com>
Cc:     Paul Cercueil <paul@crapouillou.net>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>, linux-mips@vger.kernel.org,
        alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: codecs: jz4725b: Various improvements and fixes
Message-ID: <Y0P/u4pJT8rup8Za@sirena.org.uk>
References: <20221008181655.2747857-1-lis8215@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="Op3ThFipb3tyblPC"
Content-Disposition: inline
In-Reply-To: <20221008181655.2747857-1-lis8215@gmail.com>
Precedence: bulk


--Op3ThFipb3tyblPC
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, Oct 08, 2022 at 09:16:55PM +0300, Siarhei Volkau wrote:
> The patch fixes:
> - incorrectly represented dB values in alsamixer, et al.
> - Line In path stays powered off during capturing or
>   bypass to mixer.
>=20
> The patch improves:
> - Exposes all mixer inputs (both Mics, LineIn and DAC) with their
>   gain controls.
> - Exposes output stage (post mixer) gain control and makes it new
>   Master playback gain, DAC gain was the previous master.
>   However, no Master mute now.
>=20
> Known issues:
> - Bypass path enablement isn't applied immediately, for make
>   things going bit clock needs to be triggered for a bit,
>   e.g. by aplay dummy.wav
>   It might be a hardware bug, since the bit clock isn't
>   declared as required for codec operation.

As covered in submitting-patches.rst this should really be split up into
multiple patches, with one change per patch.  This is especially the
case here since you have a mix of fixes and new features which should be
applied differently.

> -	SOC_DOUBLE_R_TLV("Master Capture Volume",
> +	SOC_DOUBLE_TLV("Master Capture Volume",
> +		       JZ4725B_CODEC_REG_CGR10,
> +		       REG_CGR10_GIL_OFFSET,
> +		       REG_CGR10_GIR_OFFSET,
> +		       0xf, 0, jz4725b_adc_tlv),
> +	SOC_DOUBLE_R_TLV("Mixer Line In Bypass Playback Volume",
>  			 JZ4725B_CODEC_REG_CGR3,

This doesn't appear to correspond to what your patch description said
and will presumably cause problems for any existing configurations...

--Op3ThFipb3tyblPC
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmND/7oACgkQJNaLcl1U
h9Ck3gf+MN3H2Q8YLJKMm3xOdxFyrrH0ZsGoIK4lRoS2exdLznRoBee133qnowPW
g+3+Oe3kzCX/Pd+uHl3u6Xsj63GkKUM7UewBPSqlxa0ErTBKPO7GSOaWKQanpyah
oPvhJ4CXee0Ul6nS3STH8SKZ8v57Xca64GFHn7yQ+8mFvob6PspUsYhpk7098Obj
nOMlKo1E1UCjZTJ6lmaPc5uSyBGb400n+t0jq1YYZEcWiRiCtqGITwctzplf3Cjo
6gW0O9R8goqDdIZE/rFCoDu8PfEc69ulzSw4LaKPQJKHSXdFlY/Vrzz5w5NQJgM9
R7ziLxg/PCEgA6SOQTt4KABRUxuGzw==
=jUV/
-----END PGP SIGNATURE-----

--Op3ThFipb3tyblPC--