Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Feedback-ID: i8771445c:Fastmail
Date:   Mon, 10 Oct 2022 14:11:23 +0200
From:   Maxime Ripard <maxime@cerno.tech>
To:     Noralf =?utf-8?Q?Tr=C3=B8nnes?= <noralf@tronnes.org>
Cc:     Jernej Skrabec <jernej.skrabec@gmail.com>,
        Chen-Yu Tsai <wens@csie.org>,
        Karol Herbst <kherbst@redhat.com>,
        Samuel Holland <samuel@sholland.org>,
        Lyude Paul <lyude@redhat.com>,
        Jani Nikula <jani.nikula@linux.intel.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        Thomas Zimmermann <tzimmermann@suse.de>,
        Emma Anholt <emma@anholt.net>,
        Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
        Ben Skeggs <bskeggs@redhat.com>,
        David Airlie <airlied@linux.ie>,
        Rodrigo Vivi <rodrigo.vivi@intel.com>,
        Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
        Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
        linux-arm-kernel@lists.infradead.org,
        dri-devel@lists.freedesktop.org,
        Geert Uytterhoeven <geert@linux-m68k.org>,
        intel-gfx@lists.freedesktop.org, linux-sunxi@lists.linux.dev,
        Hans de Goede <hdegoede@redhat.com>,
        nouveau@lists.freedesktop.org,
        Mateusz Kwiatkowski <kfyatek+publicgit@gmail.com>,
        Dave Stevenson <dave.stevenson@raspberrypi.com>,
        linux-kernel@vger.kernel.org, Dom Cobley <dom@raspberrypi.com>,
        Phil Elwell <phil@raspberrypi.com>
Subject: Re: [PATCH v4 00/30] drm: Analog TV Improvements
Message-ID: <20221010121123.sn6rxj3iwubn5tkc@houat>
References: <20220728-rpi-analog-tv-properties-v4-0-60d38873f782@cerno.tech>
 <0db1c833-eeee-cadd-b050-837d79a3d691@tronnes.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="dlolvdd7kvjkjbu5"
Content-Disposition: inline
In-Reply-To: <0db1c833-eeee-cadd-b050-837d79a3d691@tronnes.org>
Precedence: bulk


--dlolvdd7kvjkjbu5
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, Oct 01, 2022 at 03:12:06PM +0200, Noralf Tr=F8nnes wrote:
>=20
>=20
> Den 29.09.2022 18.30, skrev Maxime Ripard:
> > Hi,
> >=20
> > Here's a series aiming at improving the command line named modes suppor=
t,
> > and more importantly how we deal with all the analog TV variants.
> >=20
> > The named modes support were initially introduced to allow to specify t=
he
> > analog TV mode to be used.
> >=20
> > However, this was causing multiple issues:
> >=20
> >   * The mode name parsed on the command line was passed directly to the
> >     driver, which had to figure out which mode it was suppose to match;
> >=20
> >   * Figuring that out wasn't really easy, since the video=3D argument o=
r what
> >     the userspace might not even have a name in the first place, but
> >     instead could have passed a mode with the same timings;
> >=20
> >   * The fallback to matching on the timings was mostly working as long =
as
> >     we were supporting one 525 lines (most likely NSTC) and one 625 lin=
es
> >     (PAL), but couldn't differentiate between two modes with the same
> >     timings (NTSC vs PAL-M vs NSTC-J for example);
> >=20
> >   * There was also some overlap with the tv mode property registered by
> >     drm_mode_create_tv_properties(), but named modes weren't interacting
> >     with that property at all.
> >=20
> >   * Even though that property was generic, its possible values were
> >     specific to each drivers, which made some generic support difficult.
> >=20
> > Thus, I chose to tackle in multiple steps:
> >=20
> >   * A new TV mode property was introduced, with generic values, each dr=
iver
> >     reporting through a bitmask what standard it supports to the usersp=
ace;
> >=20
> >   * This option was added to the command line parsing code to be able to
> >     specify it on the kernel command line, and new atomic_check and res=
et
> >     helpers were created to integrate properly into atomic KMS;
> >=20
> >   * The named mode parsing code is now creating a proper display mode f=
or
> >     the given named mode, and the TV standard will thus be part of the
> >     connector state;
> >=20
> >   * Two drivers were converted and tested for now (vc4 and sun4i), with
> >     some backward compatibility code to translate the old TV mode to the
> >     new TV mode;
> >=20
> > Unit tests were created along the way.
> >=20
> > One can switch from NTSC to PAL now using (on vc4)
> >=20
> > modetest -M vc4  -s 53:720x480i -w 53:'TV mode':1 # NTSC
> > modetest -M vc4  -s 53:720x576i -w 53:'TV mode':4 # PAL
> >=20
> > Let me know what you think,
> > Maxime
> >=20
>=20
> I suggest that you apply the patches that are reviewed, have merrit on
> their own and are not tied to the TV mode property.
> This will help in keeping this rather big patchset focused and ease the
> task for reviewers.
>=20
> The following seems to be in that group:
>=20
>   drm/tests: Order Kunit tests in Makefile
>   drm/atomic-helper: Rename drm_atomic_helper_connector_tv_reset to
> avoid ambiguity
>   drm/connector: Rename subconnector state variable
>   drm/atomic: Add TV subconnector property to get/set_property
>   drm/modes: Only consider bpp and refresh before options
>   drm/modes: parse_cmdline: Add support for named modes containing dashes
>   drm/vc4: vec: Fix definition of PAL-M mode

Yeah, that was my intention with this series, it's done now, thanks for the=
 reminder :)

Maxime

--dlolvdd7kvjkjbu5
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCY0QL6wAKCRDj7w1vZxhR
xRDnAQCxLDoVhFPZlORYkrlxoTezGu1S3AQmL4/t11gdtxozgQD/WRdupXy8iNif
MB/QIxtk3f/Wt+CP26Ii1CnsJaRGqA0=
=1Yvq
-----END PGP SIGNATURE-----

--dlolvdd7kvjkjbu5--