Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 10 Oct 2022 14:45:23 +0200
Message-ID: <87zge3etjw.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     "Luke D. Jones" <luke@ljones.dev>
Cc:     linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
        tiwai@suse.com, perex@perex.cz
Subject: Re: [PATCH] Fixes bc2c23549ccd ("ALSA: hda/realtek: Add pincfg for ASUS G533Z HP jack")
In-Reply-To: <20221010065702.35190-1-luke@ljones.dev>
References: <20221010065702.35190-1-luke@ljones.dev>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Mon, 10 Oct 2022 08:57:02 +0200,
Luke D. Jones wrote:
> 
> The initial fix for ASUS G533Z was based on faulty information. This
> fixes the pincfg to values that have been verified with no existing
> module options or other hacks enabled.
> 
> Enables headphone jack, and 5.1 surround.
> 
> Signed-off-by: Luke D. Jones <luke@ljones.dev>

The changes look OK, but the subject line should be rather describing
what about the patch is about.  I corrected the subject and put the
proper Fixes tag (as well as Cc-to-stable).

Also, the indent level wasn't right, so I corrected it locally, too.


thanks,

Takashi