Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Elliott, Robert (Servers)" <elliott@hpe.com>
To:     Aaron Tomlin <atomlin@redhat.com>,
        "linux-modules@vger.kernel.org" <linux-modules@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Unloaded tainted modules list with tcrypt
Thread-Topic: Unloaded tainted modules list with tcrypt
Thread-Index: AdjcuQahMl2C8lRIQDeORTZxmzyv4A==
Date:   Mon, 10 Oct 2022 15:12:11 +0000
Message-ID: <MW5PR84MB1842AE1F86F2B66A5D57DAA5AB209@MW5PR84MB1842.NAMPRD84.PROD.OUTLOOK.COM>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?b9Hrxji72j6XXJxvVDo7rxcV4CCXR+yOIqe1E4QPnueEf6VNP401C037mrbE?=
 =?us-ascii?Q?yMxxrxkSn7epFBp01F4dJC0XPEG4aMn0Z99RtjF8fV8hhfbpcUX3ibu3v4vA?=
 =?us-ascii?Q?NgkeKNzrxcnjqKiseOJJwVEyXhKLma74B8wf1WdzampcSq8TpW0T3DuFcZeJ?=
 =?us-ascii?Q?KykC8P49lpMJCsH7KKRMDqSJdmv0UhGlANXug9MJA8YO1W1VOnwDBhLmmGwM?=
 =?us-ascii?Q?dpHH8hKdGigpUky4E4FWSHoCbMzAne0fRv6RJwh+Y8XEdCFFJf4vGzQTin7T?=
 =?us-ascii?Q?GRAEbQeI3YgH3M9u+Wt+r+PFbKYfNXxy75KY5s823XoODSfdil3nLiv0LZyn?=
 =?us-ascii?Q?DyUd/cGLKJxuBoUCwK1YtHHnZLKZ3NXZcA34cCCkBXBd6OW3/a20SFVbM0Dr?=
 =?us-ascii?Q?HiWYfZiHP7CIHG5oIy/pfsi3SNsG8mP5nClfWy5mRvYsA/kiRFFxwo1ZrBGy?=
 =?us-ascii?Q?1SuMv4gpBWAnKx0vMIgBzH8qYozAr+HuZI1BBDO3mUnZ6WIHJOGlDWs4vXkq?=
 =?us-ascii?Q?5oX4i07cqfwr2EUz9wTuTeUJtGyIxW/Wbap4/1s/L98YAtailV/xP3MrqRIa?=
 =?us-ascii?Q?QjivGJYCDinJRKZpd6RqsuOxdSEEzl5Az0uK/V0vxFG1DrBCH0GER/OYcno3?=
 =?us-ascii?Q?tZxsXjksicC5y9AlKb6LcYB7zfAmmi+/3lS/Z2UU5GO69xXu/Kdtr2mmauO8?=
 =?us-ascii?Q?4ftLsHNUF6lK8pBy3CgzoUceZ/QagkJo5T5dCFaMG34cUFimYLc7ul4FVTO8?=
 =?us-ascii?Q?I2J2gVoD3BxuOtb4UzSUC/wx+ulGkFVyjhEUAUUL8x2s+hc4og5x3n65c+d9?=
 =?us-ascii?Q?J9++yMqM6wn1gi0RRurwWqHbNnAiSueODDgl5TrF2NCKlhFLgsYrYu1HrfTt?=
 =?us-ascii?Q?GRA4WzkI0Ra5SzKnsQ6wUO2S+TgFkjaxywzKdqoY5nzXNCg6dOTmdziDRMLy?=
 =?us-ascii?Q?HwrmOeTVgMMOWFoWWRDJns1+jTTOpXHIZMLHV98fVvdvu5599YP7oGI8cKqy?=
 =?us-ascii?Q?vhMwVJLyRiADOF3XHaxGrGqw+OzFt3+Wd+yAML+hXrlmZEpl3ccPlHUPXowJ?=
 =?us-ascii?Q?1ECy9tG1pjdsvLkoS9OrfXqe+P3dFYu8YMKnfenfvVRFISRWithPVo4eHPUM?=
 =?us-ascii?Q?zqEWt+QugOWqvO2uyRlCM56Iwq/yKpdJVrYiVNvlz89FQJ1ko1Ofo9C5FJ1v?=
 =?us-ascii?Q?jhhdtvTKQV7COAUr9EXLo7o47S4H49+I1xQveX8872UFMEhF4LqTSsnXLFOP?=
 =?us-ascii?Q?d3Mkh06g3kuUlzoR5/qU0/YO0KPaFwY7cIvMuANpcd6ge/vlz2+Q2AaY5K8p?=
 =?us-ascii?Q?3o8PUvHz6OBfn6GhwfBu44SKeI1q2I42TEQ59dquv6G/HiRdmxWFy/yntaq5?=
 =?us-ascii?Q?2WtBUX5cxcmxNcs0i8oaZwVjaLcfWJy0+1tmuVxSOdffkQBQIJneX/D6j0ju?=
 =?us-ascii?Q?bZvudWQbuk2PWF1n+9q+Olw3WLb3tOHLZrBXaGJd4jwaGO8UXvjSQG3b8L5w?=
 =?us-ascii?Q?lGxeMpvK5zDJZIwVefWgTfeb1gqaAxrWzdx2/EjoUgNnyu/Skp9QuiSf3bXc?=
 =?us-ascii?Q?sysjYmhzL87bNIAFsyU=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MW5PR84MB1842.NAMPRD84.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-Network-Message-Id: 9de08eeb-ae7a-4cd5-d6ef-08daaad1ceb1
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Oct 2022 15:12:11.8682
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: s7YnVYs0NOqYcMVeAuE073IlUIZlGoKFSBQsZ4TebpKOwUWIY3gNxAI6WCN62Aol
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW5PR84MB1819
X-OriginatorOrg: hpe.com
X-Proofpoint-ORIG-GUID: dHxira89Q8BBuwjwFdgpnjaFOssn7IGz
X-Proofpoint-GUID: dHxira89Q8BBuwjwFdgpnjaFOssn7IGz
X-HPE-SCL: -1
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1
 definitions=2022-10-10_08,2022-10-10_02,2022-06-22_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501
 lowpriorityscore=0 malwarescore=0 mlxscore=0 suspectscore=0 phishscore=0
 adultscore=0 spamscore=0 impostorscore=0 clxscore=1011 mlxlogscore=352
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2209130000 definitions=main-2210100089
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

When repeatedly using the tcrypt module (which is designed to never
load successfully), the "Unloaded tainted modules" list grows forever:

Unloaded tainted modules: tcrypt():1 tcrypt():1 tcrypt():1 tcrypt():1=20
tcrypt():1 tcrypt():1 tcrypt():1 tcrypt():1 tcrypt():1 tcrypt():1=20
tcrypt():1 tcrypt():1 tcrypt():1 tcrypt():1 tcrypt():1 tcrypt():1=20
tcrypt():1 tcrypt():1 tcrypt():1 tcrypt():1 tcrypt():1 tcrypt():1=20
tcrypt():1 tcrypt():1 tcrypt():1 tcrypt():1 tcrypt():1 tcrypt():1=20
tcrypt():1 tcrypt():1 tcrypt():1 tcrypt():1 tcrypt():1 tcrypt():1=20
tcrypt():1 tcrypt():1 tcrypt():1 tcrypt():1 tcrypt():1 tcrypt():1=20
tcrypt():1 tcrypt():1 tcrypt():1 tcrypt():1 tcrypt():1 tcrypt():1=20
tcrypt():1 tcrypt():1 padlock_aes():1 padlock_aes():1=20
isst_if_mbox_msr():1 acpi_cpufreq():1 pcc_cpufreq():1 isst_if_mbox_msr():1=
=20
acpi_cpufreq():1 pcc_cpufreq():1 acpi_cpufreq():1 acpi_cpufreq():1=20
pcc_cpufreq():1 isst_if_mbox_msr():1 acpi_cpufreq():1 acpi_cpufreq():1=20
pcc_cpufreq():1 isst_if_mbox_msr():1 acpi_cpufreq():1 acpi_cpufreq():1=20
isst_if_mbox_msr():1 isst_if_mbox_msr():1=20
acpi_cpufreq():1 pcc_cpufreq():1 acpi_cpufreq():1 isst_if_mbox_msr():1

Some other modules like acpi_cpufreq() are repeated too.

Maybe this check after the name comparison:
	mod_taint->taints & mod->taints
should be:
	mod_taint->taints =3D=3D mod->taints

or shouldn't be there at all?