Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Soha Jin" <soha@lohu.info>
To:     "'Andrew Lunn'" <andrew@lunn.ch>
Cc:     "'Heiner Kallweit'" <hkallweit1@gmail.com>,
        "'David S. Miller'" <davem@davemloft.net>,
        "'Eric Dumazet'" <edumazet@google.com>,
        "'Jakub Kicinski'" <kuba@kernel.org>,
        "'Paolo Abeni'" <pabeni@redhat.com>,
        "'Russell King'" <linux@armlinux.org.uk>, <netdev@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
References: <20221009162006.1289-1-soha@lohu.info> <Y0Q0P4MlTXmzkJSG@lunn.ch>
In-Reply-To: <Y0Q0P4MlTXmzkJSG@lunn.ch>
Subject: RE: [PATCH] net: mdiobus: add fwnode_phy_is_fixed_link()
Date:   Mon, 10 Oct 2022 23:44:06 +0800
Message-ID: <08616A924F416E8E+327e01d8dcbf$2237dbe0$66a793a0$@lohu.info>
MIME-Version: 1.0
Content-Type: text/plain;
        charset="utf-8"
Content-Transfer-Encoding: 8BIT
Thread-Index: AQFoC3KVUqWpiwX+Soe/1lfFTeyGBQNmLtDwrs40JzA=
Content-Language: fr
Feedback-ID: bizesmtpipv:lohu.info:qybglogicsvr:qybglogicsvr3
Precedence: bulk

Hello Andrew,

> From: Andrew Lunn <andrew@lunn.ch>
> Sent: Monday, October 10, 2022 11:03 PM
> 
> On Mon, Oct 10, 2022 at 12:20:06AM +0800, Soha Jin wrote:
> > A helper function to check if PHY is fixed link with fwnode properties.
> > This is similar to of_phy_is_fixed_link.
> 
> You need to include a user of this new function.

Greg already notified me about this. I was thinking this patch and my
driver patches are on different trees, so I split the patches into
different parts. I will include this patch in my driver patch's v2 later
and ask you to review then. Sorry for the mistake.

> Also, not that ACPI only defines the 'new binding' for fixed-link.  If this is
> being called on a device which is ACPI underneath, it should only return true
> for the 'new binding', not the old binding.

Thanks for the information, I will correct this.

Regards,
Soha