Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp941262rwi; Mon, 10 Oct 2022 09:06:48 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6Hh40zm9Z0xC8lIHbSOLvNxnW4bolww3lTxo7T0BEaJcZMf2peLDTnC++HA7SI4rt3lW+/ X-Received: by 2002:a17:902:ce86:b0:182:498f:afdb with SMTP id f6-20020a170902ce8600b00182498fafdbmr5091504plg.12.1665418007928; Mon, 10 Oct 2022 09:06:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1665418007; cv=none; d=google.com; s=arc-20160816; b=WHClIbexusBNgnPj4iH87LPbUFjtGNAkez6trJvUyAeuATkXT/KDimwuWSucy2BNJw f5ArunOS7+HuX6TOnphMtOIAAoLDnYXYIYM6mQmssTJLMoVGH6QqGo1c+SKqkMlCpZwW yfREJ5MOPz2urOCH1jT3v6IndN9mld7gXAaGymLEjQkvm+7qj8bQPeRkNvptJfIkveXe AIJEa8lmJWVE09EqqfN68Dl3P8HqrK4wai/PEFPubwV48CAyQ5Z9wuPDnqU6zlBrRkpc w33FTU2pIpm5LeSeYqrET/WY6i/NBU7JghUgEfooWZiZzXcDXki6fOFWfS7B0Sui1iQR NwVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=YpOA3yDkOhhLvlnmsAVbYcm3nzeMbmZuIBkpzhRIZOI=; b=dFYpewxVMXkGdh2z0hMjoD2DS/4VYNiBKDw7nsjWye3FMwwT3o2pBh5Ph9NAWIuIo+ e0NjI6YW83H+WFpnjbkZTVWU6QYzrN8vF/MHUpLzIfMRnP9aJPxLfNo2KkXM4CLOVrzB o1TnhRSm0XIZT3U17S7sSRnBT/eABrqmeoacjbtKp0jhJR6CHo+ZdkWvoiq623ziZfB4 yFkC2tsivqTBAC59j1eMKXDR86+EVFH1hItSola1b4COjpNguA+L3+jqGuLBE7/v+Vhg ZFYEbRX052M2HVv0ftSdLVM+gFE/HAeaUaiJOt6iCWQvcsgdnnnWHIHYlAPytMPwdBOZ GCTg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail (test mode) header.i=@armlinux.org.uk header.s=pandora-2019 header.b=p65M3v9W; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=armlinux.org.uk Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id cn15-20020a056a00340f00b0055889152f09si11099673pfb.286.2022.10.10.09.06.29; Mon, 10 Oct 2022 09:06:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail (test mode) header.i=@armlinux.org.uk header.s=pandora-2019 header.b=p65M3v9W; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=armlinux.org.uk Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229949AbiJJP4H (ORCPT + 99 others); Mon, 10 Oct 2022 11:56:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33812 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229644AbiJJP4E (ORCPT ); Mon, 10 Oct 2022 11:56:04 -0400 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 676FE74CE1 for ; Mon, 10 Oct 2022 08:56:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=YpOA3yDkOhhLvlnmsAVbYcm3nzeMbmZuIBkpzhRIZOI=; b=p65M3v9WQrCi7bcHQV5xlVnK0j ot7O6nOZ+yKjc2xMvbK2eh0JaV/tXy/1MT1h7isK40qeoia4HhmjixqIkQrjDFl8hkC367qySghQ2 9gHZLaAOWh+k33Q9tX1uC+QLgWtUTwq2nUWwOFm6+dfc4630y7z8zOyPNcPGIQRU5BCeVP0mx7Ele VG4UdCfEVmrxZx6md1TyyyrmcgA6/7rTEzuA0ZsmYhN1tkIhcZCzItA+1dlkXXKvPs1+jwGQ/bLtl Wor54DMrLbmQY1CFFXnIVDaxKlHi4dWGVrCHEnrTN1ywby77xz/py6ihrJrwPvm99mWTXZUoprGkO sb34A6SA==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:34664) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1ohv8G-0004qc-3Z; Mon, 10 Oct 2022 16:55:57 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1ohv8B-0001xp-P9; Mon, 10 Oct 2022 16:55:51 +0100 Date: Mon, 10 Oct 2022 16:55:51 +0100 From: "Russell King (Oracle)" To: Kefeng Wang Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] ARM: mm: Provide better message when kernel fault Message-ID: References: <20220927062134.99019-1-wangkefeng.wang@huawei.com> <4339e1f4-b5c1-0b61-3a37-e63aafe22857@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4339e1f4-b5c1-0b61-3a37-e63aafe22857@huawei.com> Sender: Russell King (Oracle) X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 10, 2022 at 07:24:15PM +0800, Kefeng Wang wrote: > > On 2022/9/27 14:21, Kefeng Wang wrote: > > If there is a kernel fault, see do_kernel_fault(), we only print > > the generic "paging request" or "NULL pointer dereference" message > > which don't show read, write or excute information, let's provide > > better fault message for them. > > Hi Russell, what's your option about this one, if no object, LGTM. > I will send to ARM patch system, thanks, Yes please, if not already done. Thanks. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!