Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp973649rwi; Mon, 10 Oct 2022 09:29:52 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7i2au/zVbZW7cIiJxQM9LFw4d7NbMNxBxH40exc31PspCB7UtB2k4wGwXi9NV4lpIQXh3f X-Received: by 2002:a17:907:7f02:b0:73d:dffa:57b3 with SMTP id qf2-20020a1709077f0200b0073ddffa57b3mr15804875ejc.19.1665419392232; Mon, 10 Oct 2022 09:29:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1665419392; cv=none; d=google.com; s=arc-20160816; b=oDLegt5eZCtu/aKmmMWsh7pD57AV54EAKXi+rOYLpot2NmvEYbr35ju+C0SIydGz/Q cMWsuOUZdxl7fXS0DZnvz4FEyYiFCWyXmbUFI2YiHFjh+7ANnCHOmSzwzdfG+czu0bLt NI83MeOXjlWApMNGbuLVoHXa6fnrcF+u79x9o49BrHrEX2IocxC8imsNidH1ouSzcUUW nTnYq1XeFGjWEvusYB4B8DA/JMZKuZRXdhoY4ENZFw+FaRxxyishk2fhYuEDFZ0ldyXs 3jA3m5LewqlJuZSOD7DEbhWbn77fUZGPodurNsxkgMbIH0LwjtWJH+TFrR8dahcZd2jy e/7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=LMeKhxfmAfdwjuQ3iXb8eIas5DAK6CL7U9L+xY2kA6k=; b=PDpb6YPzTGpw3xpoMUlgiFsk0VSiv/dGYAwi276Jcy5swT+uplf/YdgSA9gHh5dDcb bvAVYt/uLaY/pXfYqpfZEQvEVrSe5awH3kzmSOLSuQWioOBC40iID7TLUtxJK/VP9st9 EHXDrFxCfSf0HJsixPWgi09oiBjFtYd8mpeVnuYtSaL8i2qPpECuMuSPBRYLXU9MQLFQ JEKb9Cgf6+qYKuioXYK4q4uS7cGJeLdX5bFwzRZp7GK0S0qMWg5ta/jmbrMoThBbeZv+ CPZ7DxOEnV5hQSOkofdpQO/xr8ZvBpiqFa90KjGUOM4Y9FBJybSNU573uO0UkILyke6d P5hg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=eiOYrzJ5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hg7-20020a1709072cc700b0073d92f83e06si11298356ejc.887.2022.10.10.09.29.25; Mon, 10 Oct 2022 09:29:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=eiOYrzJ5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229939AbiJJPxo (ORCPT + 99 others); Mon, 10 Oct 2022 11:53:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55626 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229748AbiJJPxm (ORCPT ); Mon, 10 Oct 2022 11:53:42 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7F1F83207C; Mon, 10 Oct 2022 08:53:41 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1A79960FA0; Mon, 10 Oct 2022 15:53:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AF46BC433D6; Mon, 10 Oct 2022 15:53:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1665417220; bh=LMeKhxfmAfdwjuQ3iXb8eIas5DAK6CL7U9L+xY2kA6k=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=eiOYrzJ5l++msOUwryKwXxVCMQwoWdUrtoRvCfAlYcxU1+thvwwJoWxRXzGz3pihQ xCgtc+AHvisvr/XI46QwOCJ9vXAqjlBKFwXTl7NYfe5xops+V78FBdliz4xY188BYN 4j9Y/+pv6T6CYtRUy+81cy1lWuvGmlUBZ2OLYR/MUHXR/ODd4SgRzNBY7tWcVszzfB Lk+Z41U/nyjQAuZkXJy03/TLUchAJKa57Sw2GvHlJQFcJIiiOTBRYHoRob0GzBRKKz wfKt9ijgvJ4cf2z9ngaJ14pz6aLS5w1ZLTrCBxYiZi0BFwl581wfbegxZtVftBRJqH LQ9tLhX77+mUA== Date: Mon, 10 Oct 2022 16:53:35 +0100 From: Mark Brown To: Siarhei Volkau Cc: Paul Cercueil , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , linux-mips@vger.kernel.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ASoC: codecs: jz4725b: Various improvements and fixes Message-ID: References: <20221008181655.2747857-1-lis8215@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="zP4tF1TsbOA9/jYj" Content-Disposition: inline In-Reply-To: X-Cookie: This sentence no verb. X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --zP4tF1TsbOA9/jYj Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Oct 10, 2022 at 06:20:24PM +0300, Siarhei Volkau wrote: > =D0=BF=D0=BD, 10 =D0=BE=D0=BA=D1=82. 2022 =D0=B3. =D0=B2 14:19, Mark Brow= n : > > and will presumably cause problems for any existing configurations... > I'm curious why this didn't cause problems earlier, as the wrong > control was used > for the Master Capture Volume. The issue is that if someone is relying on the current behaviour and the control starts doing something completely different they might be surprised, it at least needs a separate change. --zP4tF1TsbOA9/jYj Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmNEP/4ACgkQJNaLcl1U h9DKlQf/YSQIWB5gynvqXZHjvurY3pBrf82bZh2fiApXWPANyOMBHxVXG2wdg/GZ +6nAX7UhTnJeSfTK0CoifZkwYXiOPs+qwIi76mcUirMGJU+uxG0G3mXfAu3asRTa IG+B+uy8RInF2vcUzwamCRSQeMJA/DoiI874PAc4szy+adG1TnYQtX5AFtEjB12R xt2lOLObkSeEpGIJgj8yMglpHR0+Tu186ojscpvs1JfQBwePULy14fOfOHgcwal0 Ym73bAbOh8HNigz7UXZmiQ8LKLWLnTER+Q7ZEDcjvfSl65jo96GhtnSvJoRMocwr x7+RmH/x/kDNZa27gVnwfrUsNjH7Dw== =EaAl -----END PGP SIGNATURE----- --zP4tF1TsbOA9/jYj--