Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 10 Oct 2022 18:52:01 +0200
From:   Andrew Lunn <andrew@lunn.ch>
To:     "Russell King (Oracle)" <linux@armlinux.org.uk>
Cc:     Soha Jin <soha@lohu.info>, Heiner Kallweit <hkallweit1@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: mdiobus: add fwnode_phy_is_fixed_link()
Message-ID: <Y0RNsZUnV0GJqIlO@lunn.ch>
References: <20221009162006.1289-1-soha@lohu.info>
 <Y0Q0P4MlTXmzkJSG@lunn.ch>
 <Y0RLm0qU8MwGt40d@shell.armlinux.org.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Y0RLm0qU8MwGt40d@shell.armlinux.org.uk>
Precedence: bulk

On Mon, Oct 10, 2022 at 05:43:07PM +0100, Russell King (Oracle) wrote:
> On Mon, Oct 10, 2022 at 05:03:27PM +0200, Andrew Lunn wrote:
> > On Mon, Oct 10, 2022 at 12:20:06AM +0800, Soha Jin wrote:
> > > A helper function to check if PHY is fixed link with fwnode properties.
> > > This is similar to of_phy_is_fixed_link.
> > 
> > You need to include a user of this new function.
> > 
> > Also, not that ACPI only defines the 'new binding' for fixed-link.  If
> > this is being called on a device which is ACPI underneath, it should
> > only return true for the 'new binding', not the old binding.
> 
> Do we want to support the "managed" property in the fwnode variant,
> or persuade people to switch to phylink if they want that?

managed has been documented in
Documentation/firmware-guide/acpi/dsd/phy.rst so i think we need to
support it.

	Andrew