Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 10 Oct 2022 13:17:29 -0400
From:   "Michael S. Tsirkin" <mst@redhat.com>
To:     Deming Wang <wangdeming@inspur.com>
Cc:     jasowang@redhat.com, virtualization@lists.linux-foundation.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] virtio_ring: split: Operators use unified style
Message-ID: <20221007091431-mutt-send-email-mst@kernel.org>
References: <20220926022202.1516-1-wangdeming@inspur.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220926022202.1516-1-wangdeming@inspur.com>
Precedence: bulk

On Sun, Sep 25, 2022 at 10:22:02PM -0400, Deming Wang wrote:
> The operators of vring_alloc_queue_split should use the unified style.Add
> space for the '|' ,make it be looked more pretty.
> 
> Signed-off-by: Deming Wang <wangdeming@inspur.com>

Thanks for the patch!
Since this is about cosmetics let's make the patch look good:

Pls tweak the commit log. Space after . and , no space before ,
unified style -> kernel coding style
make it be looked more pretty -> make it prettier.


> ---
>  drivers/virtio/virtio_ring.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c
> index 8974c34b40fd..7510163565b7 100644
> --- a/drivers/virtio/virtio_ring.c
> +++ b/drivers/virtio/virtio_ring.c
> @@ -1074,7 +1074,7 @@ static int vring_alloc_queue_split(struct vring_virtqueue_split *vring_split,
>  	if (!queue) {
>  		/* Try to get a single page. You are my only hope! */
>  		queue = vring_alloc_queue(vdev, vring_size(num, vring_align),
> -					  &dma_addr, GFP_KERNEL|__GFP_ZERO);
> +					  &dma_addr, GFP_KERNEL | __GFP_ZERO);
>  	}
>  	if (!queue)
>  		return -ENOMEM;
> -- 
> 2.27.0