Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp1069771rwi; Mon, 10 Oct 2022 10:44:02 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5pI3s56Ha+C8rlacUNR3SnzAw2hne52Oqz7a5Jlr9ZeV3DGZ/SHdFPzeSrsmlCF4KYnJyh X-Received: by 2002:a17:907:8a23:b0:78d:b042:eece with SMTP id sc35-20020a1709078a2300b0078db042eecemr6067855ejc.494.1665423842705; Mon, 10 Oct 2022 10:44:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1665423842; cv=none; d=google.com; s=arc-20160816; b=viTlkWSbvAVkDHMHqE1tcBBRZ/tLFjozxBrOXYtrchDYmo3mlu4bYVCWb0huPxoegY rU1oSiTeBzNzhLCQx5F9P2daZSYvCrNtdiN2XggxvvARy502/uywvkwgIVqwYwVd9RcS sf1hQvPG6bHxZwCk/RovOqQNBm3rzw0HdkVNQKu064T8NcrQfrWf5/QOZbqXGAmCUh8L At1uiRmRQVCbde8Mt9rVXJtyNIi8CqM9h37QNK/uwlT6AZuuNFk2lH7vP/E/RkT/UZxZ sCSiUs4AlsAPHNwxnQ4Aq2LQb4SXyh52o0BJKSw9UsKUcrmBViWkvA0pXk/aKOXNaVCb UPHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=Sku5J7PyxwEr729i9MgpltbFTlOLk2agD7q4nskSz/8=; b=mK8HTAspfost6kUnsj0uXi0U/K8YMGeRgtgx3e9DNg2GzZZ8j6kHqnyb0MSK9wm8Jz q0dy6U0pruYZNIIyK5WweKo2hB3Sma7g6HYy+LucEpSOI3qUnH38BrajQ5O1vyvzM2ti 0hFfg3vF7MpGQx+o23pggJktcCbARnwhrTGbqYaLl90cxKnE8p7Y7IO/UMv7/9+izseK iOy1nnJB5k7RmLCD19DJyNYFMsmxXnAA+7/MK/DgX8Ig0pcVZJCvZO8bkag7MCOlSbfC SkCiiFLhqrXTkw2YoHYuJJX26bzuO0WPyFRnE2jM5vN2Z3fmgsYPsVzlXj7wJ8a730uR Tm0g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=google header.b=GfZe1er7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hs13-20020a1709073e8d00b0078d27a75198si13347953ejc.522.2022.10.10.10.43.36; Mon, 10 Oct 2022 10:44:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=google header.b=GfZe1er7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230018AbiJJRCt (ORCPT + 99 others); Mon, 10 Oct 2022 13:02:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53884 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229963AbiJJRCg (ORCPT ); Mon, 10 Oct 2022 13:02:36 -0400 Received: from mail-io1-xd2b.google.com (mail-io1-xd2b.google.com [IPv6:2607:f8b0:4864:20::d2b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7C6713FA19 for ; Mon, 10 Oct 2022 10:02:31 -0700 (PDT) Received: by mail-io1-xd2b.google.com with SMTP id 137so4675838iou.9 for ; Mon, 10 Oct 2022 10:02:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Sku5J7PyxwEr729i9MgpltbFTlOLk2agD7q4nskSz/8=; b=GfZe1er7asCP0ALA4xE6quMC5DxOFhh/7LbUYi1cC7lbaczkr2bHNyRdEFHjv207Vn Wiqxjkj1oviICRGEGXz7Mcg6Awz7FctKFrN1vYbsEPlnEa06eG1DIgm3v2oSHEgptcur spkpD/4M/kpmoHV9rtcTZJr2HLtXnkPJPYdPs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Sku5J7PyxwEr729i9MgpltbFTlOLk2agD7q4nskSz/8=; b=g7er5wijrSK7RVZPYTHldmSXNuD5rtbYdQW+4xpYA7vxfC0JMTbXQ6FVqxSpL1daSt i3vTLK+QAaoy/8FJofg2iaSLUT7uRTSN5sRKEWtX/vJlaS0wZGAUjg5NSKISd0rpKc4X 11zKxRfJOIl65Fe36zvxthp5mxejqbOVsD2ulioFQFN93COwAEV7Qx0H2cszMXRz+hjG 2YjKzu+zjNEvyaE4nPVs7thorQhMsF+PqEyt09rrxeRpl69w3qfbLu3KDKEWkQBTZfuK VLSBl2hdSwHNqEUsb9YWI5y0MMsFUp4IiqjgthNvOqxtyn58lRj6/iTDN/tJk4B6GHI7 iuZw== X-Gm-Message-State: ACrzQf20rCTGqaG+WUgQo32h+EbFYVMeeIxOKvqyl9C7b97Tkv042AZq Xjc4MbWDfuOAcONHSkGWKHzNQA== X-Received: by 2002:a05:6638:2491:b0:35a:53dd:f98e with SMTP id x17-20020a056638249100b0035a53ddf98emr10571658jat.261.1665421350124; Mon, 10 Oct 2022 10:02:30 -0700 (PDT) Received: from [192.168.1.128] ([38.15.45.1]) by smtp.gmail.com with ESMTPSA id v2-20020a02b082000000b0036378e4747esm4096449jah.114.2022.10.10.10.02.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 Oct 2022 10:02:29 -0700 (PDT) Message-ID: Date: Mon, 10 Oct 2022 11:02:29 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH -next v5 2/4] selftests/memory-hotplug: Restore memory before exit Content-Language: en-US To: David Hildenbrand , zhaogongyi , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "linux-kselftest@vger.kernel.org" Cc: "akinobu.mita@gmail.com" , "corbet@lwn.net" , "osalvador@suse.de" , "shuah@kernel.org" , Shuah Khan References: From: Shuah Khan In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/10/22 00:54, David Hildenbrand wrote: > On 08.10.22 03:40, zhaogongyi wrote: >> >> Yes, online_memory_expect_success() already prints a warning, remove the warning in online_all_offline_memory() seems ok, >> >> My previous consideration was that one more log information would make it easier to locate the wrong location. > > Let's keep it simple unless there is real reason to warn twice. > zhaogongyi, Please note that I already applied the patches to linux-kselftest next for my second pull request before the merge window. Please send the change David requested in a separate patch on top of next as a fix. thanks, -- Shuah