Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <3a43d0c6-1537-8396-1b7b-68cc24f50c18@oracle.com>
Date:   Mon, 10 Oct 2022 10:44:02 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.0
Subject: Re: [PATCH V2 2/3] vdpa_sim_net: support feature provisioning
Content-Language: en-US
To:     mst <mst@redhat.com>, Jason Wang <jasowang@redhat.com>,
        Parav Pandit <parav@nvidia.com>
Cc:     Eli Cohen <elic@nvidia.com>,
        Wu Zongyong <wuzongyong@linux.alibaba.com>,
        virtualization <virtualization@lists.linux-foundation.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        eperezma <eperezma@redhat.com>,
        Zhu Lingshan <lingshan.zhu@intel.com>,
        Gautam Dawar <gdawar@xilinx.com>, Cindy Lu <lulu@redhat.com>,
        Yongji Xie <xieyongji@bytedance.com>
References: <20220922024305.1718-1-jasowang@redhat.com>
 <20220922024305.1718-3-jasowang@redhat.com>
 <a1e98754-114e-b401-e927-5f2b71c3c641@oracle.com>
 <CACGkMEu9JfBDP4VkK76jdAnH225yUfTF+xMnqmy7_yDW3P0rKA@mail.gmail.com>
 <afe960d3-730a-b52c-e084-40bf080b27fa@oracle.com>
 <CACGkMEsWPbTs+D4PBHQL2hUOtGWj_6zo-669cUhYK5zK039QCQ@mail.gmail.com>
 <CACGkMEuQHV-pECAPy3EozDE20Gdeh6QjaBvu6u0djeL3PZT2NA@mail.gmail.com>
 <7c555830-6909-d482-ea05-4316a02012df@oracle.com>
 <CACGkMEsvnE6Kuvmd+5gh=mQfb57DQYnJEWegXVVO+6pWs=KY3g@mail.gmail.com>
From:   Si-Wei Liu <si-wei.liu@oracle.com>
Organization: Oracle Corporation
In-Reply-To: <CACGkMEsvnE6Kuvmd+5gh=mQfb57DQYnJEWegXVVO+6pWs=KY3g@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NnNabSs5QU1xbVVrWFBJekJMZk9xcmtKK3NHMnBiNnF4UkJhSlJyaGxtSGVR?=
 =?utf-8?B?aG5JU2FkQ1JnYjVQZ0NHWGtiK095aEhFRTJrYk5wQVZMMnZXT0JZYmY4RU9q?=
 =?utf-8?B?UHhPOUszVmVKSlpNQXJ1U2lFbW1QYkNsTHJGZUN1SnJvMi9jVVh3UDB2Sm1v?=
 =?utf-8?B?cFpCWm5XSWRUSmNncFZ5SnFsVjl4Tjh3UTk1NUN4UmpmbDgwSWt5bmowdS9K?=
 =?utf-8?B?V01QL1ZScVRMTEE2dDNYWlNVQm5Qa0I1V01TeE1meS84Ky9zbnNEdUp2dkUy?=
 =?utf-8?B?MktiaXlGMGNhS3M4MlhDb3FvSS9jNmJXcXJPV0pSeGhNemtjdTV5SVFIL1lO?=
 =?utf-8?B?c2JEeWxFNEJSOWEvVnhaeE80cWZMV09BV0FneFJPS0plcjRYck9NMXF4clE4?=
 =?utf-8?B?Uzh3NjR0c0puTVRZbENaMm9zVjQ1QUp5cW83cndsejVEQWVvZ0xJWmZ2aEsx?=
 =?utf-8?B?SFloNExMS0R5dTRxQm5QTzZlMzUxcnR0d0plVFlrSHlkeHpJaGV0b25VRTlt?=
 =?utf-8?B?dWQrVGp4SGQzRENTM3pvZ0x0OUxxa0lGc3JicFJxM3pjK0JJNmRGT0ZyTi9n?=
 =?utf-8?B?L2V1OGFEYTA5RWRKd2NybFV4ZnRLK0twUXlXb3FFdlVQbk5QMFlUMHhOWkc3?=
 =?utf-8?B?T1E2Qi8zZlVWK2ZFQVlqdlhvYW1CaFQyeVBLS2JkelJmY0c2eVVtSkZPQmxk?=
 =?utf-8?B?cS9yMGE5dmxTalJtdzNJOXpONFZ2L05BN3g4SGhuamUva2JsY09rZFAwc054?=
 =?utf-8?B?TmFGY3JXSGEwQWV5b25Td01KcWtTMC9zUnJnTVQvSDQ3MkkxYVJmS29GYUpx?=
 =?utf-8?B?VEFPTVBrdEYwOW1wTStPWnJIU2RUK3l0dElHY2JWRXM1YWY4WXd2MEowZE81?=
 =?utf-8?B?WmNpZ0VKRFF2ZWtkazRqRURWSlZDUHh5ZGNDRGdubUphQUZBK2VHWEZJcmgw?=
 =?utf-8?B?RUtUcFZyK0hzeVF4cmQ5amdmR0NlUkNCTnhNY2JMNVpuZlRiWEZtSVJod1hJ?=
 =?utf-8?B?Rkwza2YrbHgybklPcEI1ZnFtazcrUit4dlN5WkxlSmtKaFh1dUZwbjdmRVdi?=
 =?utf-8?B?M0pCL25hN3ZPVXdMZEVJRFVvaWltVnBOMnAyZUtvYlpqWE1mcy9zWm9HOTN1?=
 =?utf-8?B?aDV0d004SG9uUDhNbHQrRVZGWWFsM21aQUNSc0k0ZGoyZk9hSnRvUFV1Y01z?=
 =?utf-8?B?aFJyWjB1bDBLWlN4ZENqNUQxNVcxTVRid2o1c2o1ZXowRktzUG5WQTl4TGdQ?=
 =?utf-8?B?QWp1L0xzb3JTT25kUVZYTjl0K1ZVUnhGVDhkWk9UYkNoWEhlOHg2WmptMzhC?=
 =?utf-8?B?emFGb0FsL05Ya0pqTVk4WEtVV1NEQkY2NGxhQ1N5bm01ckVYYzZjSjVyUmZM?=
 =?utf-8?B?b2N6RkJBbjBVaTMxU25mUGhyUlJhaFRXQ3JnWG95NUU4REJuczEwUjRJRlB1?=
 =?utf-8?B?MGx6NkpnWFR1RHFEdlBYQ29DQkhrWVZQSUM4bjllQlhmcCtwTEUxOW1mQXlO?=
 =?utf-8?B?QkQrdTU5MCtYTDdBMERNVzV1NUtXU28zOU50c2ovelRhZGF3WEI2NVJtVkJ5?=
 =?utf-8?B?THNqRFRLdnR5ODZMOVVYQWZwWXVMbkRhbTFsaXdTMyt0empiQW9XOVo2T2No?=
 =?utf-8?B?V3dML0o2Q3RtZlU1NUk3TWJKMkhYQWs1blRDSmZkM1BSQmd0Q0xlb2gxTVlw?=
 =?utf-8?B?YVBwQlZIM0tmMW96eHpnSSs5RnFsNm0xU0RTOVMyaG1CYlhGeHdxaTZsMVYr?=
 =?utf-8?B?cm81ditOZFFYMDdxenhnZ2pkM3JoVG5oN0MzMERtZ1NTS0RQVGtEV0k1cW96?=
 =?utf-8?B?NXhhRnFGcmZ1eFUxRHZMeWJ0bU5nNExZVDd1TUtNdXdzbjUraGt2d01uQjFE?=
 =?utf-8?B?RjBmNTF1cWlFaUNwc0thNWlmVzVZZzcrL0o1VEtTTGlBdWdjQ29BVkQvRm1O?=
 =?utf-8?B?R0dicm5vdzV0b0svV21xeWtRSjI2K2pJMXNBL0wwTmlqc1k1bmQ5eldwcVAr?=
 =?utf-8?B?NVo4R1dKTTU2S0U5SGYybnlBQVlRT2piZDh2ZkZJTXlxRW5jY0dKQ25lalg4?=
 =?utf-8?B?bUdOaEpKWlg4cUdiZHpLVjVXMWN3RS8yUE9qbitxZHhWS1o0dlV2d1YyM0VB?=
 =?utf-8?Q?DZr8gMTir08/Hl+Jo0cyL8xKy?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b8fb45cb-8acc-48df-78ab-08daaae70783
X-MS-Exchange-CrossTenant-AuthSource: MW4PR10MB6535.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Oct 2022 17:44:06.7818
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ldL23f26uE7YQlJLARLu0z94/bLOJtxqljs8izsJrvs4Pj+5j6JcAznnUC7j0do37kPULcUIY80qE173lSmbFg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR10MB6741
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1
 definitions=2022-10-10_11,2022-10-10_02,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 bulkscore=0
 adultscore=0 malwarescore=0 phishscore=0 suspectscore=0 mlxscore=0
 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2209130000 definitions=main-2210100104
X-Proofpoint-GUID: qQPB96ZTQrV3SDktY-C6VAgclKukYVua
X-Proofpoint-ORIG-GUID: qQPB96ZTQrV3SDktY-C6VAgclKukYVua
X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Michael,

Noticed that you just merged this series that we now got two nominally 
duplicated attributes: VDPA_ATTR_VDPA_DEV_SUPPORTED_FEATURES and 
VDPA_ATTR_DEV_FEATURES. I think Jason agreed to remove one of them but 
did not get chance to post a new series to catch up with the merge 
window. Do you mind if I post a format patch similar as below to rectify 
this quickly from linux-next, without unnecessarily getting the dup 
exposed to the uAPI?

Thanks,
-Siwei

--- a/drivers/vdpa/vdpa.c
+++ b/drivers/vdpa/vdpa.c
@@ -855,7 +855,7 @@ static int vdpa_dev_net_config_fill(struct 
vdpa_device *vdev, struct sk_buff *ms

         features_device = vdev->config->get_device_features(vdev);

-       if (nla_put_u64_64bit(msg, 
VDPA_ATTR_VDPA_DEV_SUPPORTED_FEATURES, features_device,
+       if (nla_put_u64_64bit(msg, VDPA_ATTR_DEV_FEATURES, features_device,
                               VDPA_ATTR_PAD))
                 return -EMSGSIZE;

diff --git a/include/uapi/linux/vdpa.h b/include/uapi/linux/vdpa.h
index 9bd7923..6e620c3 100644
--- a/include/uapi/linux/vdpa.h
+++ b/include/uapi/linux/vdpa.h
@@ -53,10 +53,8 @@ enum vdpa_attr {
         VDPA_ATTR_DEV_VENDOR_ATTR_NAME,         /* string */
         VDPA_ATTR_DEV_VENDOR_ATTR_VALUE,        /* u64 */

-       VDPA_ATTR_DEV_FEATURES,                 /* u64 */
-
         /* virtio features that are supported by the vDPA device */
-       VDPA_ATTR_VDPA_DEV_SUPPORTED_FEATURES,  /* u64 */
+       VDPA_ATTR_DEV_FEATURES,                 /* u64 */

         /* new attributes must be added above here */
         VDPA_ATTR_MAX,


On 9/28/2022 9:10 PM, Jason Wang wrote:
> I think VDPA_ATTR_VDPA_DEV_SUPPORTED_FEATURES and
> VDPA_ATTR_DEV_FEATURES are equivalent, we can rebase on each other if
> it is needed.
>
> Thanks
>
>