Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp1118536rwi; Mon, 10 Oct 2022 11:26:33 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6Qd40jHirLHb04yjlhE3YI9uvl4qjnAVwqrLO0TeGCwOkdcF4wOt3FWSA7uPde+NL0zis8 X-Received: by 2002:a63:8049:0:b0:462:f1ac:c4fd with SMTP id j70-20020a638049000000b00462f1acc4fdmr4097368pgd.268.1665426393096; Mon, 10 Oct 2022 11:26:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1665426393; cv=none; d=google.com; s=arc-20160816; b=PUibKoBD3hbZiAjoCqBWPsuQI2FgwPSYqWq41pdUxVIUeWNergx84uPLPPo9bUQe+b 2wFRp3h5l7soLYB2WSqAJvQtdIURi8OltcTnex2nDOKQEYjhJxbu9LpTSVyFaD98yHfE 3/t3x3EXtMIeu/H3SBFpk6hdwmsY0AOTGra5uceOCJWXscRVgWJ3JHNIZFKT7rzH5sll uWaGAuF6z64ge9rBTz6GGXTk/F5QD814+O5JXVjUGxp4x82bCv+pyjwprYFlt+f1eFsQ luXbeH3GQCXiHG+swvWzmxF2tHqKpP2fyKDLjvBfuViH7AoL84NkLs8bCeIBbPfhBHsE I3Vg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=xsnSaR6uUCBZjp+kEvtpUBOjoyoCrGfxoWHGbQH9hK8=; b=xDZKBv/US2OjKpAOMABOYO/aELLqM9uEjbS1jx2D5j/0DjJamxbfenLLAvksa0zWO2 dHTsaIclE/bwiYZe7GI2IAyhodAP0cdZSSPjYe4oFMVPOPNpkpcroZgS4ZBCSVSpVGDk IO4UBthfcVMTLKwRNAFp/17Azny/BSzTjwDURKtJJzjS1U7VSwsnrDkGL3xFuurAdSOS 9r6in6OWMeKnOKij9pGpnjb5dzp9OjhnauBm8kqTQud10QyWehwOfU3BDIFlHSwp6wHz HqWVLGl47Lgzw4YjanYspHypsBGUTe7ADV4BiipOGrnTSpj3PwAgFA5MMbfOZuKgoqs6 mHFQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=Y2IpNu0x; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 202-20020a6219d3000000b0053e7495a394si11140555pfz.141.2022.10.10.11.26.20; Mon, 10 Oct 2022 11:26:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=Y2IpNu0x; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229550AbiJJSGt (ORCPT + 99 others); Mon, 10 Oct 2022 14:06:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40886 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229520AbiJJSGs (ORCPT ); Mon, 10 Oct 2022 14:06:48 -0400 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1802425E6; Mon, 10 Oct 2022 11:06:47 -0700 (PDT) Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 29AGe0ox019138; Mon, 10 Oct 2022 18:06:32 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=xsnSaR6uUCBZjp+kEvtpUBOjoyoCrGfxoWHGbQH9hK8=; b=Y2IpNu0x0N92zWMM7xlYwfaoZkveojVZioEmCl8myrbZxOjk4wqxdkAvRjClwk2th4Vm u+hHA2TOysCXrF6ABS49ntiotF7JDRdFZUryZ1kgpHRnyZvGy2zxKb78J3pFvw9r6OpS PRkmwScPtWAX4O+fTAsjMzlZ2PpMyN4CXoPzMP14OiJiuLTbmL3AaFDB4ASjEkebfsuL y+AMa9iOwY4CoPw9gXkjAQpFlEkLSPGfgdCx2Y4lA3fXo3tKVTN+CRRvtlq3LMb+locs xjJc/esTv/LowpeSaxu4gZXvlm9o4gayHr2G8mOQDoN2Q6gnktDNDN5G/HBL3fmFtXAm 3A== Received: from nasanppmta04.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3k32csd1m6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 10 Oct 2022 18:06:32 +0000 Received: from nasanex01b.na.qualcomm.com (nasanex01b.na.qualcomm.com [10.46.141.250]) by NASANPPMTA04.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 29AI6Vno019634 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 10 Oct 2022 18:06:31 GMT Received: from [10.110.10.240] (10.80.80.8) by nasanex01b.na.qualcomm.com (10.46.141.250) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.29; Mon, 10 Oct 2022 11:06:30 -0700 Message-ID: Date: Mon, 10 Oct 2022 11:06:30 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v4 14/14] tty: gunyah: Add tty console driver for RM Console Services Content-Language: en-US To: Jiri Slaby , Bjorn Andersson , Greg Kroah-Hartman CC: Murali Nalajala , Trilok Soni , Srivatsa Vaddagiri , Carl van Schaik , Andy Gross , Dmitry Baryshkov , Jassi Brar , , "Mark Rutland" , Lorenzo Pieralisi , Sudeep Holla , "Marc Zyngier" , Rob Herring , "Krzysztof Kozlowski" , Jonathan Corbet , Will Deacon , Catalin Marinas , Arnd Bergmann , , , , References: <20220928195633.2348848-1-quic_eberman@quicinc.com> <20220928195633.2348848-15-quic_eberman@quicinc.com> From: Elliot Berman In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nasanex01b.na.qualcomm.com (10.46.141.250) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: 1vKR6j1K9w1xJaKYNVwGChQ-CHUvk2tO X-Proofpoint-ORIG-GUID: 1vKR6j1K9w1xJaKYNVwGChQ-CHUvk2tO X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1 definitions=2022-10-10_12,2022-10-10_02,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 spamscore=0 impostorscore=0 adultscore=0 suspectscore=0 bulkscore=0 mlxlogscore=908 priorityscore=1501 clxscore=1011 mlxscore=0 malwarescore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2209130000 definitions=main-2210100106 X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/3/2022 12:01 AM, Jiri Slaby wrote: > On 28. 09. 22, 21:56, Elliot Berman wrote: >> +struct rm_cons_port { >> +    struct tty_port port; >> +    u16 vmid; >> +    bool open; >> +    unsigned int index; >> + >> +    DECLARE_KFIFO(put_fifo, char, 1024); > > Why is tty_port::xmit_fifo not enough? > xmit_fifo gave me some inspiration to avoid using KFIFO here and skip extra an extra memcpy into/out of the FIFO. I've also dropped out the FIFO usage for tty_operations and this buffering is only used for printk console. Thanks, Elliot