Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Sender: Tejun Heo <htejun@gmail.com>
Date:   Mon, 10 Oct 2022 08:48:48 -1000
From:   Tejun Heo <tj@kernel.org>
To:     Greg KH <gregkh@linuxfoundation.org>
Cc:     Christian Brauner <brauner@kernel.org>,
        "Christian A. Ehrhardt" <lk@c--e.de>,
        syzbot <syzbot+534ee3d24c37c411f37f@syzkaller.appspotmail.com>,
        linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com,
        Yosry Ahmed <yosryahmed@google.com>
Subject: Re: [PATCH] cgroup: Fix crash with CLONE_INTO_CGROUP and v1 cgroups
Message-ID: <Y0RpEGo+FZrA80mI@slm.duckdns.org>
References: <000000000000385cbf05ea3f1862@google.com>
 <00000000000028a44005ea40352b@google.com>
 <Y0CbtVwW6+QIYJdQ@slm.duckdns.org>
 <Y0HBlJ4AoZba93Uf@cae.in-ulm.de>
 <20221009084039.cw6meqbvy4362lsa@wittgenstein>
 <Y0LITEA/22Z7YVSa@cae.in-ulm.de>
 <20221009173519.jwuissylg5haicie@wittgenstein>
 <Y0MP/errn3nJ+9WQ@kroah.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Y0MP/errn3nJ+9WQ@kroah.com>
Precedence: bulk

On Sun, Oct 09, 2022 at 08:16:29PM +0200, Greg KH wrote:
> On Sun, Oct 09, 2022 at 07:35:19PM +0200, Christian Brauner wrote:
> > On Sun, Oct 09, 2022 at 03:10:36PM +0200, Christian A. Ehrhardt wrote:
> > > 
> > > Since commit f3a2aebdd6, Version 1 cgroups no longer cause an
> > > error when used with CLONE_INTO_CGROUP. However, the permission
> > > checks performed during clone assume a Version 2 cgroup.
> > > 
> > > Restore the error check for V1 cgroups in the clone() path.
> > > 
> > > Reported-by: syzbot+534ee3d24c37c411f37f@syzkaller.appspotmail.com
> > > Link: https://lore.kernel.org/lkml/000000000000385cbf05ea3f1862@google.com/
> > > Fixes: f3a2aebdd6 ("cgroup: enable cgroup_get_from_file() on cgroup1")
> > > Signed-off-by: Christian A. Ehrhardt <lk@c--e.de>
> > > ---
> > 
> > Thanks for fixing this,
> > Reviewed-by: Christian Brauner (Microsoft) <brauner@kernel.org>
> 
> No cc: stable?  :(

This got merged this cycle, so no need for -stable.

Thanks.

-- 
tejun