Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp1157579rwi; Mon, 10 Oct 2022 12:03:24 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7pNqhD0JLNaFrh+hSrHGhwfu3CDXlZ0vRzri1Ky9o9wCSW4QpviPqii3ZntOMVB/vS1fGv X-Received: by 2002:a05:6402:90c:b0:457:b5ce:5f18 with SMTP id g12-20020a056402090c00b00457b5ce5f18mr19749103edz.309.1665428604226; Mon, 10 Oct 2022 12:03:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1665428604; cv=none; d=google.com; s=arc-20160816; b=uP/W0upCUdOaPLDgrUKLEvpHVoDQLy2hOph5o6VNLlA6G1MiCvGi6pf+EFLCLjAM5S /4raoTOmUm7uDfb3RB9sLrKGG0+gZLwbvHylqbQ9/mszITIQC78mH9p7/WOe+CPnM9Cw KbiInm0Vskr8Dz5njq3S11iDPPjW1QnGGepuZNQN49UW8cjMb4n88LZe/hkXgx7ts6BI ZOLDSiasa+7pQ3XnYTqOP56gLGOdiEo+OUjUyQAADHIfKPoaDnAgqn/I2GW3SNg5vc5q i1M61ZhJw/UYx7NeFIZ+vm0Vx6UWRImeuzRfmNgUoVpvy2CfDKT1SWzMXYLSLq6wGLW2 lHqA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=mQOcbgqlc7YWpQLopbZ7qox0JJ82m+Wb0DJKAyjCUZA=; b=S8BrPVW7MKHb639RzR20pSiSphHiAtGjsGS8E+CWODdlZ7c2GtGKpnyFXbqrtdo9l0 IehGuCCoi5MDkmOBPscENBPuCHI8eZFY8/MBAk6kUIywinB+LlgguN+7cykDOzKQKK/P l+lY7YDHUg7ddrgkw/UqDdMJOjGJa91IGZTr9aiBAAUIKtFFbfCD08tcmT7bOicfeBNX EX/mdglncP3MnxRyn6j87ohEjOt/8j+88i+YjAq7HdUNbhfAx7WzILWZtrFgTeKcBxUf x/OVA/s76QdiJfn0Q+NwOIxhIEb5XSRuvUZKtcySxa1FjtjjH7830pzRlALGTHRP8cUe mCaw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=y14sdLtW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id go12-20020a1709070d8c00b0078c65d3a2a9si12911087ejc.859.2022.10.10.12.02.34; Mon, 10 Oct 2022 12:03:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=y14sdLtW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229818AbiJJSxR (ORCPT + 99 others); Mon, 10 Oct 2022 14:53:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36718 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229768AbiJJSxP (ORCPT ); Mon, 10 Oct 2022 14:53:15 -0400 Received: from vps0.lunn.ch (vps0.lunn.ch [185.16.172.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 00522786E5; Mon, 10 Oct 2022 11:53:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=mQOcbgqlc7YWpQLopbZ7qox0JJ82m+Wb0DJKAyjCUZA=; b=y14sdLtWMIQwI8Ff8AWvJCr39k 4rC1V6N7RyYWmjQadNm1cDcVtxErCQ4NZJGXFTwPMydS3R4YskDUFX4eUVTkFYLzM42D1OyCBhY35 TuJMX63oSz2MGChjQs/0wO1+5DuV0cCpgdm4W5+dMrvvpmY0ztEl3EbRHII8Q4D8vCjc=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1ohxtd-001e6Y-Pl; Mon, 10 Oct 2022 20:53:01 +0200 Date: Mon, 10 Oct 2022 20:53:01 +0200 From: Andrew Lunn To: Christian Marangi Cc: Vivien Didelot , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , "Russell King (Oracle)" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Pawel Dembicki , Lech Perczak Subject: Re: [net PATCH 1/2] net: dsa: qca8k: fix inband mgmt for big-endian systems Message-ID: References: <20221010111459.18958-1-ansuelsmth@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221010111459.18958-1-ansuelsmth@gmail.com> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > /* Special struct emulating a Ethernet header */ > struct qca_mgmt_ethhdr { > - u32 command; /* command bit 31:0 */ > - u32 seq; /* seq 63:32 */ > - u32 mdio_data; /* first 4byte mdio */ > + __le32 command; /* command bit 31:0 */ > + __le32 seq; /* seq 63:32 */ > + __le32 mdio_data; /* first 4byte mdio */ > __be16 hdr; /* qca hdr */ > } __packed; It looks odd that hdr is BE while the rest are LE. Did you check this? Andrew