Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp1214319rwi; Mon, 10 Oct 2022 12:56:43 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7mfepFgiDYkIJKTOh1tXACs1YmyFpUilX9lgrVl/YGHQBgsejps00OGiYSiWnYbfKDb+XY X-Received: by 2002:a63:7909:0:b0:458:1ba6:ec80 with SMTP id u9-20020a637909000000b004581ba6ec80mr18366712pgc.414.1665431802976; Mon, 10 Oct 2022 12:56:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1665431802; cv=none; d=google.com; s=arc-20160816; b=JeEijiVwtRIMho2tQl9x2hk1ASiB052dOsBzkr406E1HdP8MG4OeRmZE7qZXDBjQYp 5YoLEjdGyeVFyi0bXNbaM3d0qt72PvjzjpHD3pqkzfOuwBT4jzv2flO0kOITWVlgueHv VA5lcziKIPG+zcAdCfYbsSJ76xnBFWz1L+shA5uF5WKJrUR3Jb4M9YprMuSBWzjrAntX hGmZX1mw5KJHMDUPFVFEKUawIyYSwU4Iw8X3FBxM3SQ8Sw69+fJVGsaizsDPV/bF7Tzl xczLEf0M6mlnXsejR9+hOQVaAJmtOEg6cVwpPtfz6J4eWFklwxqQpcZ9f2rS0Hnr+Umq MAEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=hKtR8JVIp6FNFfckoP6qflwXPqB9HW7iOtTc8jEtu3g=; b=jC60L484zFrEbHjqFRH4oKXF9ZLk+0xGS8pQmzRNbtb74iK/ZIv6FuCYwdYYN+85nS lvHVgMFUJnQ9QPE9VjCdAVXquR4X+h476GLLe5o/vzdOj163K/WF3OImBBGRLVf5DAiA /PoP2smqKx8dPRRT+fsPcTrtoS582BnmeJ42a0i6v+tOeQquimCovyG9mwwJ53K64ZZO ZJF8HiWcjn1d24pYJIyDfKdpvDTWInhLr2M/8hmFO29B+TIEs+K93SqpLBNdaoNjpA2S 5H+LKWv0c301PzlrI9pCeXzi5qK0FONjs9pbNMtsA3Vwap0QB8kRLE9Z3hwDhCa94tJQ xBuw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=YVx8BQUM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b3-20020a056a00114300b0055f9c56e056si13654459pfm.276.2022.10.10.12.56.30; Mon, 10 Oct 2022 12:56:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=YVx8BQUM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229462AbiJJTrA (ORCPT + 99 others); Mon, 10 Oct 2022 15:47:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53024 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229452AbiJJTq6 (ORCPT ); Mon, 10 Oct 2022 15:46:58 -0400 Received: from mail-lj1-x231.google.com (mail-lj1-x231.google.com [IPv6:2a00:1450:4864:20::231]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3A3725E559; Mon, 10 Oct 2022 12:46:55 -0700 (PDT) Received: by mail-lj1-x231.google.com with SMTP id x18so5837269ljm.1; Mon, 10 Oct 2022 12:46:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=hKtR8JVIp6FNFfckoP6qflwXPqB9HW7iOtTc8jEtu3g=; b=YVx8BQUMqOWo3vXqoqTAgVFjcOWYBMs7DoY0bwuJ2Sy5LoiDs9sXTLzS1HsVkiIVwj C9vuYseRVD2Eq/m4y1leskgHMWaKGOgONlZap7H6vjIRTU065wuoafkacmc4lg8kdMJa bg9McYSh2j/5btauOTbz6jrmyGXundWNoXIeTXoo4Qy7YjDxC43x5FMuLYwZsCyFoulU rFIZtlC1Ke0N9HKze2SeNhjuZ7JeI5ckoPv1/lcERy7oATzdcspo5ha17ChTzSRDEgpw asRByzAsV9GcYT9rAuX8FbRA1gRg8hYX1Lb7Z3l7SwMooNfC0nDsBZUDsvDbRg3Y24kK J/WA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=hKtR8JVIp6FNFfckoP6qflwXPqB9HW7iOtTc8jEtu3g=; b=T5onvwIUsPACmQkKSobJ2JrUx5eCtgYt4yDQPB+JqqrU7DMmziETBTvpDV+yy+NG7C gdbPw46UDhGeRVTbDanDnFHQdx7wo6WQXzjAv+NUwgH64p6ldUg4xT4qmVMSGGHTvuZq LrS+AdqBPdYnvCp0XkqL8i5Lt8vlXrthiLbrYUz6nknyMiRvgqw/9szkwGvaay1Zs1Xn 49WAyc1Hsca99IVy85XRzlMLZtqf5xaaxOjebI/s2Tq6Jdv5V3Ilk4CPFJwMMIBq25gU iyr+Z0bHxhZBSGD/5IpXkeSDtB4LyS0fXNtfRub6u+7E6kcQgQP+Ce2Kd/XTKHS5OAeB P/8w== X-Gm-Message-State: ACrzQf0JAPsUTKsl+orUoLUjGaBsJowW17C9UCYEMR6g7eum6xGxccy4 xKIOK4Dsy2+o8cNTW79loMkQFxbiQjo= X-Received: by 2002:a2e:a499:0:b0:26f:a7cb:d9d with SMTP id h25-20020a2ea499000000b0026fa7cb0d9dmr2464458lji.139.1665431213397; Mon, 10 Oct 2022 12:46:53 -0700 (PDT) Received: from localhost.localdomain (82-209-154-112.cust.bredband2.com. [82.209.154.112]) by smtp.gmail.com with ESMTPSA id p20-20020ac24ed4000000b004a2588520f5sm1540690lfr.166.2022.10.10.12.46.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Oct 2022 12:46:52 -0700 (PDT) From: Marcus Folkesson To: Marcus Folkesson , Kent Gustavsson , Jonathan Cameron , Lars-Peter Clausen Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] iio: adc: mcp3911: use correct id bits Date: Mon, 10 Oct 2022 21:46:41 +0200 Message-Id: <20221010194641.676484-1-marcus.folkesson@gmail.com> X-Mailer: git-send-email 2.37.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The device ID should be shifted 6 bits to left according to datasheet. Fixes: 3a89b289df5d ("iio: adc: add support for mcp3911") Signed-off-by: Marcus Folkesson --- drivers/iio/adc/mcp3911.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/iio/adc/mcp3911.c b/drivers/iio/adc/mcp3911.c index e55db02c534f..2c1af11a621f 100644 --- a/drivers/iio/adc/mcp3911.c +++ b/drivers/iio/adc/mcp3911.c @@ -57,8 +57,8 @@ /* Internal voltage reference in mV */ #define MCP3911_INT_VREF_MV 1200 -#define MCP3911_REG_READ(reg, id) ((((reg) << 1) | ((id) << 5) | (1 << 0)) & 0xff) -#define MCP3911_REG_WRITE(reg, id) ((((reg) << 1) | ((id) << 5) | (0 << 0)) & 0xff) +#define MCP3911_REG_READ(reg, id) ((((reg) << 1) | ((id) << 6) | (1 << 0)) & 0xff) +#define MCP3911_REG_WRITE(reg, id) ((((reg) << 1) | ((id) << 6) | (0 << 0)) & 0xff) #define MCP3911_NUM_CHANNELS 2 #define MCP3911_NUM_SCALES 6 -- 2.37.1