Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp1219967rwi; Mon, 10 Oct 2022 13:02:13 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6nPnNy//EuCV1Omn7anRloyM8VCRF+fzOiJyz+iCNdlSlsGz9LCuNYiJSSF3YTwjzOsEnm X-Received: by 2002:a17:906:dc89:b0:78d:5616:4c24 with SMTP id cs9-20020a170906dc8900b0078d56164c24mr13622107ejc.118.1665432133335; Mon, 10 Oct 2022 13:02:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1665432133; cv=none; d=google.com; s=arc-20160816; b=OTo51aGhZEoe+t/3vaGXuch3YXXh115JoyVy5Ix8PrLEqqvK95iJvfJq2KyomnH5nG jWaJsD/1D5quaAT4+zdSoC4qxSV3iXrH4Uqjwkypnk4m9s/k5ocnM1FI9zRf7WvCDwOq YpS3Wqb/QCem8W02VGiyjVhKXnL8vXIgruFlc3ArvMN5rc4n7TK6j9iwhburNCMkLZJ6 ojz2lNNb0ECf3/0pv4RP+fB07doGS9D9nolLIN2S8GeAG9INIAjyQAEGDyVUn4jdtWpW hyJIUi5tZZygKTVvMCAwvsW+29y/1dHtWtLAeFcTrMlzA4axonsb2i32wolEZ3A7ql1V kghA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:subject:cc:to:from:date:references:in-reply-to :message-id:mime-version:user-agent:feedback-id:dkim-signature :dkim-signature; bh=OmVrkyV7ebRAniQNae83Idny89aIU9Df0QWBCsfk6KE=; b=jvGXwCTkiBsc4LKYkG3FZPgjC9aikfX1Rm3WVL3Ce01SPkD5zJ+f+LumcDOdCiS2L4 L/0PQej127MS7ORW6wkJhhbc/I7vJ62h/0eZMQ6TgBTmP/tf18Lb2f4IArIFqILmejiV wc+ADtgiMng/8hdiliE4gAItE+OwRG0gNSFWCWRn+1aW26YQ5hOxZt9uxfNZABY/qvDL obwVKo+1ldMjWfC30B4xYm1C5XHuUriqGyObU1nyTID9V6t2Wlcij4prENkvgDV0k5WE BV68yn4HbO3xy+oEb+yddidVrSIgR7e+NDbo8jnqgXUoSBgwM2EyZl8W2CfMNTuzlUr7 pkuw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@arndb.de header.s=fm2 header.b=JNm+uyKx; dkim=pass header.i=@messagingengine.com header.s=fm3 header.b=PQkHsoME; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id bf26-20020a0564021a5a00b004587e08bc14si10434831edb.508.2022.10.10.13.01.47; Mon, 10 Oct 2022 13:02:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@arndb.de header.s=fm2 header.b=JNm+uyKx; dkim=pass header.i=@messagingengine.com header.s=fm3 header.b=PQkHsoME; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229550AbiJJT4Q (ORCPT + 99 others); Mon, 10 Oct 2022 15:56:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42206 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229494AbiJJT4P (ORCPT ); Mon, 10 Oct 2022 15:56:15 -0400 Received: from wnew1-smtp.messagingengine.com (wnew1-smtp.messagingengine.com [64.147.123.26]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5F76B2A433; Mon, 10 Oct 2022 12:56:14 -0700 (PDT) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailnew.west.internal (Postfix) with ESMTP id 10B2C2B06B7D; Mon, 10 Oct 2022 15:56:09 -0400 (EDT) Received: from imap51 ([10.202.2.101]) by compute3.internal (MEProxy); Mon, 10 Oct 2022 15:56:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm2; t=1665431769; x=1665435369; bh=OmVrkyV7eb RAniQNae83Idny89aIU9Df0QWBCsfk6KE=; b=JNm+uyKxoucwEtoyKmec9bMOpb y12Xis5RpW/jjxp8Hfm7qdm2PN5XdMzNcNJBx6OO0pOHMDp4K00NHVc6HKrrOLKT YGOSlwZCDNwQoogvWcqyEtiwuSAUHDOhdQlBYY8Pj2A31q523BNxoR4VwvSC0cJS j6IJv/O/y7HUWnPH8CmFYvsDBvS1VtONHMV3NMFU6gOF8uax2+s7aW3ViDzZ1p7a R/P8BeBULT0cUNMI8lcfwoV61G08rOvpcRpLEC4Dxb8pymKfXROdzcwZJRPVEEUX WlXnz1Tosj30qlf6rAV7UBJQRDb0BPEODMnPgAxUbQajh3HoHAWgSp7tkjMQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1665431769; x=1665435369; bh=OmVrkyV7ebRAniQNae83Idny89aI U9Df0QWBCsfk6KE=; b=PQkHsoMEdaUsHl4egguO1a/yl/ZupKLf2bUv2UYnXXTl S7gvAJlItxcj2GI3cXGV8AHOFQ1MqL5C12GoU8nvpafTWEt1xie713xF6Yi5txJo ZCPofn7GDvUOkoir19j839VbtTsnEkP4V7o8ffjxBwGgcORZyc8IMHDALHUs6LXq mYqM8//y3Yw9JqoE+R7M3NlI4JuvIzdd95O49y2gZZCnTFLlAL51dE3+dYdxZNCe piVOfG+cfoByA9Z3bmtWy5yr4TJcqqBkxqv+Jc02GqNLKDcmBXcKD5GMdd2BQdat jhIp08+BSU7zEt/Mp3DaHoIsdz8X2k5yvH2tBE2xrg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeejgedgudefjecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefofgggkfgjfhffhffvvefutgesthdtredtreertdenucfhrhhomhepfdet rhhnugcuuegvrhhgmhgrnhhnfdcuoegrrhhnugesrghrnhgusgdruggvqeenucggtffrrg htthgvrhhnpeffheeugeetiefhgeethfejgfdtuefggeejleehjeeutefhfeeggefhkedt keetffenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe grrhhnugesrghrnhgusgdruggv X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id B066EB60086; Mon, 10 Oct 2022 15:56:08 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.7.0-alpha0-1015-gaf7d526680-fm-20220929.001-gaf7d5266 Mime-Version: 1.0 Message-Id: In-Reply-To: <20221007201140.1744961-1-ndesaulniers@google.com> References: <20221007201140.1744961-1-ndesaulniers@google.com> Date: Mon, 10 Oct 2022 21:55:47 +0200 From: "Arnd Bergmann" To: "Nick Desaulniers" , "Andrew Morton" Cc: "Alexander Viro" , "Nathan Chancellor" , "Tom Rix" , "Xiaoming Ni" , "Luis Chamberlain" , "Andi Kleen" , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, "Christoph Hellwig" , "Eric Dumazet" , "Darrick J. Wong" , "Greg Kroah-Hartman" Subject: Re: [PATCH] fs/select: mark do_select noinline_for_stack for 32b Content-Type: text/plain X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 7, 2022, at 10:11 PM, Nick Desaulniers wrote: > +#ifdef CONFIG_64BIT > +#define noinline_for_stack_32b > +#else > +#define noinline_for_stack_32b noinline_for_stack > +#endif > + > +noinline_for_stack_32b I don't see much value in making it behave differently for 32 bit: it doesn't reduce the total frame size on 32-bit machines but only hides the warning. The bug you are working around also looks i386 specific (because of limited number of registers vs ubsan needing a lot of them), so just make it a simple 'noinline_for_stack'. Arnd