Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <YzN6A9Y20Ea1LdEz@google.com> <CACRpkdZF9TVA3+3pgjqm_cnhfPO6p0oOT=2jrqFafMCHe2cwDg@mail.gmail.com>
 <YzwtG8CT9sTCqQQk@maple.lan> <CACRpkdZ-DfZKgCOHaKn1UZ8vVwy1dEiFBBDNdxu6VNzrUdeEtA@mail.gmail.com>
 <YzyZJSwy9xsy69WL@google.com> <CACRpkdYecQPUd-evVpOpMLY1XUa87kP4i+E694QfTtDbEarJfQ@mail.gmail.com>
 <Yz6oS/zdNIOEtWxI@maple.lan>
In-Reply-To: <Yz6oS/zdNIOEtWxI@maple.lan>
From:   Linus Walleij <linus.walleij@linaro.org>
Date:   Mon, 10 Oct 2022 22:36:00 +0200
Message-ID: <CACRpkdYdZaxSGy+YiexKtffKvUEr5dcu3g=1zY3Tfhv5WMDtew@mail.gmail.com>
Subject: Re: [RFC/PATCH] backlight: hx8357: prepare to conversion to gpiod API
To:     Daniel Thompson <daniel.thompson@linaro.org>
Cc:     Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Rob Herring <robh+dt@kernel.org>, Lee Jones <lee@kernel.org>,
        Jingoo Han <jingoohan1@gmail.com>,
        Shawn Guo <shawnguo@kernel.org>,
        Fabio Estevam <festevam@gmail.com>,
        NXP Linux Team <linux-imx@nxp.com>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        dri-devel@lists.freedesktop.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, Oct 6, 2022 at 12:05 PM Daniel Thompson
<daniel.thompson@linaro.org> wrote:
> On Thu, Oct 06, 2022 at 11:03:15AM +0200, Linus Walleij wrote:
> > On Tue, Oct 4, 2022 at 10:35 PM Dmitry Torokhov
> > <dmitry.torokhov@gmail.com> wrote:
> >
> > > > Dmitry, could you fix this? Just patch away in gpiolib-of.c.
> > >
> > > Sure, I'll add a few quirks. I wonder what is the best way to merge
> > > this? I can create a bunch of IBs to be pulled, or I can send quirks to
> > > you/Bartosz and once they land send the patches to drivers...
> >
> > When I did it I was sufficiently convinced that I was the only one patching
> > the quirks in gpiolib-of.c that merge window so I just included it as
> > a hunk in the driver patch. If there will be some more patches to that
> > file I guess some separate patch(es) for gpiolib-of.c is needed, maybe
> > an immutable branch for those if it becomes a lot.
>
> Are renames likely to be a common quirk on the road to libgpiod
> conversion?
>
> I admit I sort of expected it to be common enough that there would be
> one rename quirk in the code supported by an alphabetized string table.
> Such a table would certainly still provoke troublesome merges but ones
> that are trivially resolved.

Dmitry added a table of sorts, the problems are usually a bit unique
for each instance of nonstandard DT GPIO bindings, that's why I
mostly solved it with open coding in gpiolib-of.c.

Yours,
Linus Walleij