Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Feedback-ID: i5ec1447f:Fastmail
Message-ID: <e5de59f50c8e4141edc96f882253feb4a12a6536.camel@ljones.dev>
Subject: Re: [PATCH] Fixes bc2c23549ccd ("ALSA: hda/realtek: Add pincfg for
 ASUS G533Z HP jack")
From:   Luke Jones <luke@ljones.dev>
To:     Takashi Iwai <tiwai@suse.de>
Cc:     linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
        tiwai@suse.com, perex@perex.cz
Date:   Tue, 11 Oct 2022 10:50:29 +1300
In-Reply-To: <87zge3etjw.wl-tiwai@suse.de>
References: <20221010065702.35190-1-luke@ljones.dev>
         <87zge3etjw.wl-tiwai@suse.de>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.46.0 (by Flathub.org)) 
MIME-Version: 1.0
Precedence: bulk

On Mon, 2022-10-10 at 14:45 +0200, Takashi Iwai wrote:
> On Mon, 10 Oct 2022 08:57:02 +0200,
> Luke D. Jones wrote:
> >=20
> > The initial fix for ASUS G533Z was based on faulty information.
> > This
> > fixes the pincfg to values that have been verified with no existing
> > module options or other hacks enabled.
> >=20
> > Enables headphone jack, and 5.1 surround.
> >=20
> > Signed-off-by: Luke D. Jones <luke@ljones.dev>
>=20
> The changes look OK, but the subject line should be rather describing
> what about the patch is about.=C2=A0 I corrected the subject and put the
> proper Fixes tag (as well as Cc-to-stable).
>=20
> Also, the indent level wasn't right, so I corrected it locally, too.

Oh... Sorry about the hassle there, I could have sworn it was correct.
Thanks for accepting regardless :)

>=20
> thanks,
>=20
> Takashi