Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Richard Acayan <mailingradian@gmail.com>
To:     Sasha Levin <sashal@kernel.org>
Cc:     linux-kernel@vger.kernel.org, stable@vger.kernel.org,
        Richard Acayan <mailingradian@gmail.com>,
        Bhupesh Sharma <bhupesh.sharma@linaro.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Ulf Hansson <ulf.hansson@linaro.org>, agross@kernel.org,
        andersson@kernel.org, adrian.hunter@intel.com,
        linux-arm-msm@vger.kernel.org, linux-mmc@vger.kernel.org
Subject: Re: [PATCH AUTOSEL 6.0 39/44] mmc: sdhci-msm: add compatible string check for sdm670
Date:   Mon, 10 Oct 2022 19:43:53 -0400
Message-Id: <20221010234353.228833-1-mailingradian@gmail.com>
In-Reply-To: <20221009234932.1230196-39-sashal@kernel.org>
References: <20221009234932.1230196-1-sashal@kernel.org> <20221009234932.1230196-39-sashal@kernel.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

> From: Richard Acayan <mailingradian@gmail.com>
> 
> [ Upstream commit 4de95950d970c71a9e82a24573bb7a44fd95baa1 ]
> 
> The Snapdragon 670 has the same quirk as Snapdragon 845 (needing to
> restore the dll config). Add a compatible string check to detect the need
> for this.
> 
> Signed-off-by: Richard Acayan <mailingradian@gmail.com>
> Reviewed-by: Bhupesh Sharma <bhupesh.sharma@linaro.org>
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Link: https://lore.kernel.org/r/20220923014322.33620-3-mailingradian@gmail.com
> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
> Signed-off-by: Sasha Levin <sashal@kernel.org>
> ---
>  drivers/mmc/host/sdhci-msm.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c
> index dc2991422a87..3a091a387ecb 100644
> --- a/drivers/mmc/host/sdhci-msm.c
> +++ b/drivers/mmc/host/sdhci-msm.c
> @@ -2441,6 +2441,7 @@ static const struct of_device_id sdhci_msm_dt_match[] = {
>  	 */
>  	{.compatible = "qcom,sdhci-msm-v4", .data = &sdhci_msm_mci_var},
>  	{.compatible = "qcom,sdhci-msm-v5", .data = &sdhci_msm_v5_var},
> +	{.compatible = "qcom,sdm670-sdhci", .data = &sdm845_sdhci_var},

Supporting device trees which are invalid under 6.0 schema? It's not a bug fix,
it's a feature.

Documentation/devicetree/bindings/mmc/sdhci-msm.yaml:17-49, at tag v6.0:

    properties:
      compatible:
        oneOf:
          - enum:
              - qcom,sdhci-msm-v4
            deprecated: true
          - items:
              - enum:
                  - qcom,apq8084-sdhci
                  - qcom,msm8226-sdhci
                  - qcom,msm8953-sdhci
                  - qcom,msm8974-sdhci
                  - qcom,msm8916-sdhci
                  - qcom,msm8992-sdhci
                  - qcom,msm8994-sdhci
                  - qcom,msm8996-sdhci
                  - qcom,msm8998-sdhci
              - const: qcom,sdhci-msm-v4 # for sdcc versions less than 5.0
          - items:
              - enum:
                  - qcom,qcs404-sdhci
                  - qcom,sc7180-sdhci
                  - qcom,sc7280-sdhci
                  - qcom,sdm630-sdhci
                  - qcom,sdm845-sdhci
                  - qcom,sdx55-sdhci
                  - qcom,sdx65-sdhci
                  - qcom,sm6125-sdhci
                  - qcom,sm6350-sdhci
                  - qcom,sm8150-sdhci
                  - qcom,sm8250-sdhci
                  - qcom,sm8450-sdhci
              - const: qcom,sdhci-msm-v5 # for sdcc version 5.0

I'm new to this, so I apologize if I don't understand stable kernel development.

>  	{.compatible = "qcom,sdm845-sdhci", .data = &sdm845_sdhci_var},
>  	{.compatible = "qcom,sc7180-sdhci", .data = &sdm845_sdhci_var},
>  	{},
> -- 
> 2.35.1