Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Elliott, Robert (Servers)" <elliott@hpe.com>
To:     "Elliott, Robert (Servers)" <elliott@hpe.com>,
        Aaron Tomlin <atomlin@redhat.com>,
        "linux-modules@vger.kernel.org" <linux-modules@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: Unloaded tainted modules list with tcrypt
Thread-Topic: Unloaded tainted modules list with tcrypt
Thread-Index: AdjcuQahMl2C8lRIQDeORTZxmzyv4AATEgAA
Date:   Tue, 11 Oct 2022 00:09:38 +0000
Message-ID: <MW5PR84MB184240ECFBB251B8A9CC1B8EAB239@MW5PR84MB1842.NAMPRD84.PROD.OUTLOOK.COM>
References: <MW5PR84MB1842AE1F86F2B66A5D57DAA5AB209@MW5PR84MB1842.NAMPRD84.PROD.OUTLOOK.COM>
In-Reply-To: <MW5PR84MB1842AE1F86F2B66A5D57DAA5AB209@MW5PR84MB1842.NAMPRD84.PROD.OUTLOOK.COM>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Yrl+scudoPVFAdjFiGzQu4n3f+wofsd6Eb98L8fw//jz7wougTdmxrSotN4m?=
 =?us-ascii?Q?W8oju1G85uOlKkQP6BlmtPzNfqWILfzTPfxBg2mReG4zPeYhD1IshCRXLJZs?=
 =?us-ascii?Q?RlcZvIxHn3ywj/HCySCGfKK8dwXMJoJSDjY2FLdCMB5Gy3bqOUtlytBBmQsm?=
 =?us-ascii?Q?a1RSRTO3H9xBHleGQn01JzF+1dH3fV5W1osgDWZUNhfyAn/UwptnvYB/1NF3?=
 =?us-ascii?Q?PMbmMZhv79ZBsib2htBbXinwzTBB7OnV0YHB4S9g+idbFjwHr+O2xbodP4Wu?=
 =?us-ascii?Q?itZ+P6DvFmFGf+xW+WzndpGRe2dAhggt55V9cIruUzeDL1sq1ka8C9haNanV?=
 =?us-ascii?Q?HPU4ZUTOzX9ho8EuriRMa5wPybv/YWu5089xCoi9pdWPB9f/yJQUPuDULPtu?=
 =?us-ascii?Q?muMskEJDWwZvX6QQeRKhlqEZSrhP5GQrcDnj/PO6yrHsvqjSsLmOoUNvc4uU?=
 =?us-ascii?Q?owRmVeN8DsQvBh9S3cUEa42p9SN74OG1g6G8FCrRK+2Jxe6Xf37FzCQQYZ3g?=
 =?us-ascii?Q?UXL2oBts7LUHYueXK/8JYmrO6k8Ymv+ENnx+ZRzXUVC7/r3wJjNNr4N6u0Fv?=
 =?us-ascii?Q?puV27lxrtAbf+4ymAq8RGGU4du6P9N4gVlPQlVu2oEl7fZSO/MDDxUNp4fZz?=
 =?us-ascii?Q?6ylZAJ8OwULXSbTO+5+yTqiEDLPCisES98bf9bNOV3KKA1Mbc7bnED6zrlAF?=
 =?us-ascii?Q?bAGosa2aHf/29jB33RQjWtTeBCFQGuc7p2x3BlTIK1g6p+380plk4gh7pyZW?=
 =?us-ascii?Q?CUBPR/yyrYwHmsXVI75z2zGx3HYwmJzU12VgrAwIeFo56stZvYYYZ7c4+rHQ?=
 =?us-ascii?Q?KorILYbShT464xby5Tw/bF17daVTI+GgVT8Eqypevv/2faICMFpX7RJaySJP?=
 =?us-ascii?Q?2b+jFO3rHOnNSLVLQjiULExtrdJWu3NmIFgJ0ho4936VkVW+d/L0Ja2xBnMm?=
 =?us-ascii?Q?ruk/EZ6657Vcf1CfVEFYa+MvtT99Z9EagNAFrg/ERISGJCUoR2csJut0/MCd?=
 =?us-ascii?Q?OlXZXuKY5pJ+cZAjRD7Sj0Vx+9KmVCkIby83M/eoryv/tezHPgjzd5EXmy96?=
 =?us-ascii?Q?x9koPSU55bPYYkvP4n8zjH2jourTaU9RfVzw3HJ7fYJh5QJQIdqraTQGsy33?=
 =?us-ascii?Q?mopGz9tpCP9GHdRHLJs8yeedCtbjhh4yJ3uVpoQn6sCcZ12uamT/Ht8s9n0v?=
 =?us-ascii?Q?bYsr/7PoRf2G7L8eWrau8aq6GIh2Jw0T9XojoOrKbmKIkAdK4wApHwHxzplc?=
 =?us-ascii?Q?hhTCHAR5QA9+rXWyVuos4Za0Yz4fSfMCMNlHya+/Kk5phmdU9n6A0wD2etQJ?=
 =?us-ascii?Q?8Uw0wOpCMIbYmPsaF/aD5WIlW+nhGbQ4B4YtsdOfc1F5rm3UzRfMSVYQb+J6?=
 =?us-ascii?Q?t9qiB5RSegFQHWxOTKT1Iz/FU3rnifRI477Naslrm5fuGUpJGpuKx+Z4Rfxq?=
 =?us-ascii?Q?NuykS7LkVaJbV0OlgznVc7Qh1RUY1iIq4PSby3tDw62P7csF2TXw1S4gh4gt?=
 =?us-ascii?Q?n/+uHsFENNXfPM5zYuauThw5nAxS/NosEqX/fqmifXju71jxKIdhg1pGbg5z?=
 =?us-ascii?Q?f0OHPXqG9XHHBih3bDw=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MW5PR84MB1842.NAMPRD84.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-Network-Message-Id: cf5ee1c6-e6e7-4fdb-3701-08daab1ce30f
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Oct 2022 00:09:38.2893
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: mh3idLHH8MEFzfReFZjMx9DA8TMxUvO/iJJTEXU64HySUhiZZGcarpSf99Xv9LLc
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW5PR84MB1498
X-OriginatorOrg: hpe.com
X-Proofpoint-ORIG-GUID: E1OJMDd7TB5jO3H-Xkd4GMK_VchE36Jo
X-Proofpoint-GUID: E1OJMDd7TB5jO3H-Xkd4GMK_VchE36Jo
X-HPE-SCL: -1
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1
 definitions=2022-10-10_12,2022-10-10_02,2022-06-22_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 spamscore=0
 mlxscore=0 mlxlogscore=641 priorityscore=1501 suspectscore=0
 lowpriorityscore=0 phishscore=0 impostorscore=0 adultscore=0 bulkscore=0
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2209130000 definitions=main-2210100143
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Elliott, Robert (Servers) <elliott@hpe.com>
> Sent: Monday, October 10, 2022 10:12 AM
> To: Aaron Tomlin <atomlin@redhat.com>; linux-modules@vger.kernel.org; lin=
ux-
> kernel@vger.kernel.org
> Subject: Unloaded tainted modules list with tcrypt
>=20
> When repeatedly using the tcrypt module (which is designed to never
> load successfully), the "Unloaded tainted modules" list grows forever:
>=20
> Unloaded tainted modules: tcrypt():1 tcrypt():1 tcrypt():1 tcrypt():1
> tcrypt():1 tcrypt():1 tcrypt():1 tcrypt():1 tcrypt():1 tcrypt():1
> tcrypt():1 tcrypt():1 tcrypt():1 tcrypt():1 tcrypt():1 tcrypt():1
> tcrypt():1 tcrypt():1 tcrypt():1 tcrypt():1 tcrypt():1 tcrypt():1
> tcrypt():1 tcrypt():1 tcrypt():1 tcrypt():1 tcrypt():1 tcrypt():1
> tcrypt():1 tcrypt():1 tcrypt():1 tcrypt():1 tcrypt():1 tcrypt():1
> tcrypt():1 tcrypt():1 tcrypt():1 tcrypt():1 tcrypt():1 tcrypt():1
> tcrypt():1 tcrypt():1 tcrypt():1 tcrypt():1 tcrypt():1 tcrypt():1
> tcrypt():1 tcrypt():1 padlock_aes():1 padlock_aes():1
> isst_if_mbox_msr():1 acpi_cpufreq():1 pcc_cpufreq():1 isst_if_mbox_msr():=
1
> acpi_cpufreq():1 pcc_cpufreq():1 acpi_cpufreq():1 acpi_cpufreq():1
> pcc_cpufreq():1 isst_if_mbox_msr():1 acpi_cpufreq():1 acpi_cpufreq():1
> pcc_cpufreq():1 isst_if_mbox_msr():1 acpi_cpufreq():1 acpi_cpufreq():1
> isst_if_mbox_msr():1 isst_if_mbox_msr():1
> acpi_cpufreq():1 pcc_cpufreq():1 acpi_cpufreq():1 isst_if_mbox_msr():1
>=20
> Some other modules like acpi_cpufreq() are repeated too.
>=20
> Maybe this check after the name comparison:
> 	mod_taint->taints & mod->taints
> should be:
> 	mod_taint->taints =3D=3D mod->taints
>=20
> or shouldn't be there at all?

Changing to =3D=3D seems to work well - that shows incremented counts
rather than new entries:
Unloaded tainted modules: tcrypt():40 padlock_aes():1 isst_if_mbox_msr():56=
 pcc_cpufreq():56 acpi_cpufreq():112