Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 11 Oct 2022 02:24:50 +0200
From:   Samuel Thibault <samuel.thibault@ens-lyon.org>
To:     Yureka <yuka@yuka.dev>
Cc:     w.d.hubbs@gmail.com, chris@the-brannons.com,
        gregkh@linuxfoundation.org, speakup@linux-speakup.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] speakup: remove usage of non-standard u_char
Message-ID: <20221011002450.d25x3gvgu5snsozm@begin>
Mail-Followup-To: Samuel Thibault <samuel.thibault@ens-lyon.org>,
        Yureka <yuka@yuka.dev>, w.d.hubbs@gmail.com, chris@the-brannons.com,
        gregkh@linuxfoundation.org, speakup@linux-speakup.org,
        linux-kernel@vger.kernel.org
References: <9b7e4894-deec-39ba-bb7c-3c6d6427fa1d@yuka.dev>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <9b7e4894-deec-39ba-bb7c-3c6d6427fa1d@yuka.dev>
Organization: I am not organized
User-Agent: NeoMutt/20170609 (1.8.3)
Precedence: bulk

Yureka, le mar. 11 oct. 2022 02:17:43 +0200, a ecrit:
> From: Yureka Lilian <yuka@yuka.dev>
> 
> This code is included in the build tools makemapdata and genmap, and it
> expects that libc exposes a definition of u_char. But u_char is not
> defined in either C or POSIX standards, and some systems don't have it.
> Namely this breaks the build on hosts using musl libc, because musl only
> exposes u_char if _GNU_SOURCE is defined.
> 
> Signed-off-by: Yureka Lilian <yuka@yuka.dev>

Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>

> ---
>  drivers/accessibility/speakup/utils.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/accessibility/speakup/utils.h b/drivers/accessibility/speakup/utils.h
> index 4bf2ee8ac..4ce9a12f7 100644
> --- a/drivers/accessibility/speakup/utils.h
> +++ b/drivers/accessibility/speakup/utils.h
> @@ -54,7 +54,7 @@ static inline int oops(const char *msg, const char *info)
>  
>  static inline struct st_key *hash_name(char *name)
>  {
> -   u_char *pn = (u_char *)name;
> +   unsigned char *pn = (unsigned char *)name;
>     int hash = 0;
>  
>     while (*pn) {
> -- 
> 2.37.3