Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp1509421rwi; Mon, 10 Oct 2022 18:02:56 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6qQrAfn4GHMY3bsHJr+IX9xxkj48w9p6Z/U+B0I4UQ0CZKEEfk/Y31nwMPxKxakH2UU/E3 X-Received: by 2002:a17:902:8217:b0:176:e41d:b804 with SMTP id x23-20020a170902821700b00176e41db804mr21482479pln.111.1665450176234; Mon, 10 Oct 2022 18:02:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1665450176; cv=none; d=google.com; s=arc-20160816; b=m8gn3i1/A/cP+jQfLgVXQlvV+TiJlB4US+9ZlHKXiJ2aVlbLIr4hTQasykAxbng+Zi +cUi7h6xGPczCuvAOoGGONwRE1JjDUOeEsg1ncCRlOxutCvuzgJec/jxcUbfJXUx56oF xDOJFgZuMXUYefwRl526snNXzHE4ky3DlPkUR6WufvqsJEImdlEDX5uAoh/G9nWOlhl1 mFM2wgw2bmOc7mCVuuK8c6Jm9lkPxHx4RgC4n12v6kKB3bJh5O0SZS4V+Bx1A9y7TGMN MbkTFRxQBGH81I0U1SAt/TzuH11hZzJ3MOwfFC8ZJ7t3/usk/UMyfZFUYTsQKfxFkYyB vVaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:sender:dkim-signature; bh=XATmXDDouGmZ8eVmg2gOICME3agw6HNrb3TQMDuvm/4=; b=BqYxWIvkFctdB0qDX0VMGl2G1EOcGpTV6a5ytPFdI8oaPWM2PIKIAF+H6adYcufvHY YIwPifYHEo1ly4ubOUbrq2EKhaJijcDbMxsXLwE8dsg08emxUrMZLcPqiU802nH0aIjX 3Q93w1MwDs/7j7T3TpQ5qchbE4IDHEjClOECWtOZ9HesDR6eEsFqh28oNZK4duvZhO2B Zy/trm4MLyS9fQVw9uRI51FzscnETw28PAi61+sfHqlFOmtr2V0NpV7sLjd1lB+BxWcx SNG4C4TMCzEThj/k50GRzTK0uBM/diEiRdpGyg3rmB6ugOsXHEGUvL2cZQ56ibnNT9O5 aofw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=AS5j0Wak; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i15-20020a63130f000000b0045fc63bf52csi11773367pgl.764.2022.10.10.18.02.22; Mon, 10 Oct 2022 18:02:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=AS5j0Wak; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230179AbiJJX7t (ORCPT + 99 others); Mon, 10 Oct 2022 19:59:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60584 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230246AbiJJX7d (ORCPT ); Mon, 10 Oct 2022 19:59:33 -0400 Received: from mail-pj1-x102d.google.com (mail-pj1-x102d.google.com [IPv6:2607:f8b0:4864:20::102d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F33DF7FFA0; Mon, 10 Oct 2022 16:59:24 -0700 (PDT) Received: by mail-pj1-x102d.google.com with SMTP id 70so11042968pjo.4; Mon, 10 Oct 2022 16:59:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=XATmXDDouGmZ8eVmg2gOICME3agw6HNrb3TQMDuvm/4=; b=AS5j0WakWcXloGTMkDVqd2Cneha7BIrjvG2XXT41mxwinS7nhAdmQDYDl1IzutSN7N GtfRRcfzd/xXbKbIdHhfHCn7qpzNdjU25NUUUIt8Lj2MXVutYNCUSLZczrKNSg7HShqK G+LNdMzkSzzqM2Tl1x5FWduRvauGP8dZvRrRveXpg9Iv9KPDRJID+v0C8uufmRDysenO 7AB7VUpvwZQibh3eFsy3F4vSq9HU8M+WE4BnUTlc/ZJpGSmRtHMdsfNXIFkmygCi03+G UlASbuOBE7FXyQhJNlcCOZIYSvSritHqCB5kuLO4I2L4te6Ox7aSJyuxic4Kwee29AwF Qfsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XATmXDDouGmZ8eVmg2gOICME3agw6HNrb3TQMDuvm/4=; b=YzC9UbzCGS1M10wGcBPzpbacrVzCBXQxFQhtGRwWKEnHKF/SbCzaiLU6uEDVHY9tc+ X3ucV1OxiOxJzpOdQr0j7EuudeeZc2WeFHWn5owhHEMPkjdHUQQ5mu9H2IHSaM3Fq5hM AQFurdZnW9m/CIZ5V/CB+tsRcD1wJVDV11L6tO0dqStsV7OW79huR+PJhzOoNwWnvWKv ODWibtyb9XQWpD62KTWt8doGIjer50Bs6U4l4FXdN+CQDJvMbnX9Xs1rrFLz5Ep+e33g b8kRbozselQtltWKrO5j1JR2yxyB/9YMUPfeYJhWwFlbMtex5tSRtXnB+gYem93bLZfk ivKQ== X-Gm-Message-State: ACrzQf1pa/MQOQqWLkw6n10NFstqbaX6zkRdPvp97GI1TYqQODuJDhaN 4IdsUs1+YmYsIoICCJJUVDI= X-Received: by 2002:a17:902:d2cc:b0:182:d901:5d28 with SMTP id n12-20020a170902d2cc00b00182d9015d28mr5580837plc.142.1665446361746; Mon, 10 Oct 2022 16:59:21 -0700 (PDT) Received: from localhost (2603-800c-1a02-1bae-a7fa-157f-969a-4cde.res6.spectrum.com. [2603:800c:1a02:1bae:a7fa:157f:969a:4cde]) by smtp.gmail.com with ESMTPSA id f13-20020a170902f38d00b00172fc5b0764sm7111255ple.270.2022.10.10.16.59.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Oct 2022 16:59:21 -0700 (PDT) Sender: Tejun Heo Date: Mon, 10 Oct 2022 13:59:20 -1000 From: Tejun Heo To: Namhyung Kim Cc: Zefan Li , Johannes Weiner , cgroups@vger.kernel.org, Arnaldo Carvalho de Melo , Jiri Olsa , LKML , linux-perf-users@vger.kernel.org, Song Liu , bpf@vger.kernel.org Subject: Re: [PATCH] perf stat: Support old kernels for bperf cgroup counting Message-ID: References: <20220922041435.709119-1-namhyung@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220922041435.709119-1-namhyung@kernel.org> X-Spam-Status: No, score=-1.5 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 21, 2022 at 09:14:35PM -0700, Namhyung Kim wrote: > The recent change in the cgroup will break the backward compatiblity in > the BPF program. It should support both old and new kernels using BPF > CO-RE technique. > > Like the task_struct->__state handling in the offcpu analysis, we can > check the field name in the cgroup struct. > > Signed-off-by: Namhyung Kim Looks like it's acked enough but the patch doesn't apply anymore. Namhyung, can you please refresh the patch? I'll route this through cgroup/for-6.1-fixes unless somebody objects. Thanks. -- tejun