Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20221010142553.776550-1-xukuohai@huawei.com>
In-Reply-To: <20221010142553.776550-1-xukuohai@huawei.com>
From:   Andrii Nakryiko <andrii.nakryiko@gmail.com>
Date:   Mon, 10 Oct 2022 18:37:00 -0700
Message-ID: <CAEf4Bzbt1_J=bzsSmO-xX=Ubi9UeGj8swQT7c1pZt_ay1npZhw@mail.gmail.com>
Subject: Re: [PATCH bpf v3 0/6] Fix bugs found by ASAN when running selftests
To:     Xu Kuohai <xukuohai@huawei.com>
Cc:     bpf@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-kselftest@vger.kernel.org, netdev@vger.kernel.org,
        Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Andrii Nakryiko <andrii@kernel.org>,
        Martin KaFai Lau <martin.lau@linux.dev>,
        Song Liu <song@kernel.org>, Yonghong Song <yhs@fb.com>,
        John Fastabend <john.fastabend@gmail.com>,
        KP Singh <kpsingh@kernel.org>,
        Stanislav Fomichev <sdf@google.com>,
        Hao Luo <haoluo@google.com>, Jiri Olsa <jolsa@kernel.org>,
        Mykola Lysenko <mykolal@fb.com>, Shuah Khan <shuah@kernel.org>,
        "David S . Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Jesper Dangaard Brouer <hawk@kernel.org>,
        Kumar Kartikeya Dwivedi <memxor@gmail.com>,
        Alan Maguire <alan.maguire@oracle.com>,
        Delyan Kratunov <delyank@fb.com>,
        Lorenzo Bianconi <lorenzo@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, Oct 10, 2022 at 7:08 AM Xu Kuohai <xukuohai@huawei.com> wrote:
>

Thanks for the fixes! I left a few comments in a few patches, please
address those. But also
please provide a commit message, even if a single line one. Kernel
style dictates that the commit message shouldn't be empty.

And I think none of these fixes are critical enough to go to bpf tree,
please target bpf-next for next revision. Thanks.


> v3:
> - Fix error failure of case test_xdp_adjust_tail_grow exposed by this series
>
> v2: https://lore.kernel.org/bpf/20221010070454.577433-1-xukuohai@huaweicloud.com
> - Rebase and fix conflict
>
> v1: https://lore.kernel.org/bpf/20221009131830.395569-1-xukuohai@huaweicloud.com
>
> Xu Kuohai (6):
>   libbpf: Fix use-after-free in btf_dump_name_dups
>   libbpf: Fix memory leak in parse_usdt_arg()
>   selftests/bpf: Fix memory leak caused by not destroying skeleton
>   selftest/bpf: Fix memory leak in kprobe_multi_test
>   selftests/bpf: Fix error failure of case test_xdp_adjust_tail_grow
>   selftest/bpf: Fix error usage of ASSERT_OK in xdp_adjust_tail.c
>
>  tools/lib/bpf/btf_dump.c                      | 47 +++++++++++----
>  tools/lib/bpf/usdt.c                          | 59 +++++++++++--------
>  .../bpf/prog_tests/kprobe_multi_test.c        | 17 +++---
>  .../selftests/bpf/prog_tests/map_kptr.c       |  3 +-
>  .../selftests/bpf/prog_tests/tracing_struct.c |  3 +-
>  .../bpf/prog_tests/xdp_adjust_tail.c          |  7 ++-
>  6 files changed, 86 insertions(+), 50 deletions(-)
>
> --
> 2.30.2
>