Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp1767645rwi; Mon, 10 Oct 2022 23:19:37 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7OE/Ug7YKSo3mgn/AFVAyIPlnGkzN8dhMr9AHbN67PZGkkgoHWE2BvikmaE2SIFMoM6NZK X-Received: by 2002:a17:907:968d:b0:78d:b7d6:d9de with SMTP id hd13-20020a170907968d00b0078db7d6d9demr6458028ejc.57.1665469177620; Mon, 10 Oct 2022 23:19:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1665469177; cv=none; d=google.com; s=arc-20160816; b=hPgfgrwwLNj4Th4duEcJTM0pVV/0BceQtTODpVXil/SSblY7bcfEhyDFbpZCoMvRyj YoGI2ZaKGzP8ugwx7zgYe5ebpNrdt0TewC6qTB8QkCfzboVNniwpjUjM1Y5y5tQNyMpp 45QlTBlsGlOhvZ67WSYAWclGp/L7ugdFAmkOgmStbjZ4vWVaTf60jptpj4iBBYEdOMN9 Wb7OXccyGotz7AZGCHrJDBybet334eGhNeCV2uzAXAKXBFKL3KeeVX02pXHyvCBhZ1Nw SZO1Ojq9xEAPv659Kjg/HX3tTilEDMUWLnN5p23HV5wGNI+0Om9ObtBc+eF30aMgZF3o X+JQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :organization:references:in-reply-to:message-id:subject:cc:to:from :date:dkim-signature; bh=mDLip3zeejmnkhQb+7KaEyxp3L0KOSICdhVmdqjYG3k=; b=Q/aAYQR+3qrAg7mz/Ory7Rrlht6cLT7Ay8LiQNVLMzpl0Q88cXEC+xrHX3pcpOX9gp O4lCuUwIRgB+djI1yMNksWXQxjbbQvkDOH3OiDL5DRQMaY+s5yIQEv8SaiSHluPb2AEN R3SDOWHTO/KxjYibUwwNxWBnzLD+SrDiPxewAOTWfwAKS90ncFVN79xQoHSvPGRrS02g ufomawXivzIQaQe3xBPlMgcYk9opjCw8ZkfsHKO31mHJ3zYr+TpRFHlNEMH6uH5WKRKJ LJsYINILNfNyOLB0A4IiemcWn/KVRDkJxqtwgMBDiJeyl7xD1YlvwSMX9/tp27OTJade trhw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=MGlF0dqT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c26-20020aa7c75a000000b004573275623fsi11306388eds.423.2022.10.10.23.19.12; Mon, 10 Oct 2022 23:19:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=MGlF0dqT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229557AbiJKFqA (ORCPT + 99 others); Tue, 11 Oct 2022 01:46:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48608 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229517AbiJKFp6 (ORCPT ); Tue, 11 Oct 2022 01:45:58 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BE58F4D15C for ; Mon, 10 Oct 2022 22:45:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1665467156; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mDLip3zeejmnkhQb+7KaEyxp3L0KOSICdhVmdqjYG3k=; b=MGlF0dqT33/Rr3VrOm1Rkux/ifisCHdo2aAZJRCxZyGOU8l9HktYnKIdngMrejBxB1krQM x2VY+quty/jHSLBjvsgoef/923diMf6cWr3KxGG+r5Xup9jkrp4nj2WxZHEXhAL/uSLOSO K2ui3KgLfvcPDDFvs3EfM9W+mXukBsQ= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-163-OgahoQadP1OS0h1KxdBUYg-1; Tue, 11 Oct 2022 01:45:52 -0400 X-MC-Unique: OgahoQadP1OS0h1KxdBUYg-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 1CB6F185A794; Tue, 11 Oct 2022 05:45:52 +0000 (UTC) Received: from niphredil.zaitcev.lan (unknown [10.2.17.221]) by smtp.corp.redhat.com (Postfix) with ESMTP id 85A2DA37D0; Tue, 11 Oct 2022 05:45:51 +0000 (UTC) Date: Tue, 11 Oct 2022 00:45:50 -0500 From: Pete Zaitcev To: Greg Kroah-Hartman Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Jiri Kosina , Benjamin Tissoires , Juergen Stuber , Johan Hovold Subject: Re: [PATCH] USB: make devnode() callback in usb_class_driver take a const * Message-ID: <20221011004550.46e068f5@niphredil.zaitcev.lan> In-Reply-To: <20221001165128.2688526-1-gregkh@linuxfoundation.org> References: <20221001165128.2688526-1-gregkh@linuxfoundation.org> Organization: Red Hat, Inc. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 1 Oct 2022 18:51:28 +0200 Greg Kroah-Hartman wrote: > +++ b/drivers/usb/class/usblp.c > @@ -1090,7 +1090,7 @@ static const struct file_operations usblp_fops = { > -static char *usblp_devnode(struct device *dev, umode_t *mode) > +static char *usblp_devnode(const struct device *dev, umode_t *mode) > { > return kasprintf(GFP_KERNEL, "usb/%s", dev_name(dev)); > } Seems obvious. Acked-by: Pete Zaitcev -- P