Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756292AbXF0BdO (ORCPT ); Tue, 26 Jun 2007 21:33:14 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753122AbXF0BdA (ORCPT ); Tue, 26 Jun 2007 21:33:00 -0400 Received: from smtpout.mac.com ([17.250.248.178]:53377 "EHLO smtpout.mac.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752285AbXF0Bc7 (ORCPT ); Tue, 26 Jun 2007 21:32:59 -0400 In-Reply-To: <20070622150038.GN23017@stusta.de> References: <467afc63.OnsqEXOk5zqMYzym%Joerg.Schilling@fokus.fraunhofer.de> <467b0bf2.Xfs7T8Ys4nY9ZNLW%Joerg.Schilling@fokus.fraunhofer.de> <1182483527.10524.31.camel@shinybook.infradead.org> <20070622150038.GN23017@stusta.de> Mime-Version: 1.0 (Apple Message framework v752.2) Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Message-Id: Cc: David Woodhouse , Joerg Schilling , david@lang.hm, LKML Kernel Content-Transfer-Encoding: 7bit From: Kyle Moffett Subject: Re: Linux Kernel include files Date: Tue, 26 Jun 2007 21:32:39 -0400 To: Adrian Bunk X-Mailer: Apple Mail (2.752.2) X-Brightmail-Tracker: AAAAAA== X-Brightmail-scanned: yes Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1639 Lines: 43 On Jun 22, 2007, at 11:00:38, Adrian Bunk wrote: > It would certainly help if Joerg would tell what exactly breaks, > but I spot one likely problem in include/asm-i386/types.h: > > #if defined(__GNUC__) && !defined(__STRICT_ANSI__) > typedef __signed__ long long __s64; > typedef unsigned long long __u64; > #endif > > It might make sense to remove the #if and simply require that a C > compiler under Linux must know about the C99 "long long"? Gah, this particular topic and a few other similar header- compatibility ones show up once a month on LKML; I should probably just make a patch to fix all the types.h files and be done with it. The proper solution is this: # if __STDC_VERSION__ >= 19901L typedef signed long long __s64; typedef unsigned long long __u64; # elif defined(__GNUC__) __extension__ typedef signed long long __s64; __extension__ typedef unsigned long long __u64; # else # error "Your compiler doesn't support long long (IOW: It sucks). Please get a new one" # endif That way if you have any kind of vaguely-long-long-compatible compiler then it will work, and otherwise you'll get a nice useful error message. It also makes sure that GCC doesn't spew warnings/ errors when in c89-pedantic mode. The "__extension__" keyword is designed for use in implementation header files which want to use GCC- isms unconditionally. Cheers, Kyle Moffett - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/