Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Padmanabhan Rajanbabu" <p.rajanbabu@samsung.com>
To:     "'Krzysztof Kozlowski'" <krzysztof.kozlowski@linaro.org>,
        <robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
        <alim.akhtar@samsung.com>, <chanho61.park@samsung.com>,
        <linus.walleij@linaro.org>, <pankaj.dubey@samsung.com>
Cc:     <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <linux-samsung-soc@vger.kernel.org>
In-Reply-To: <ebf9e667-6b08-4a04-2241-04295cc28058@linaro.org>
Subject: RE: [PATCH] arm64: dts: fix drive strength macros as per FSD HW UM
Date:   Tue, 11 Oct 2022 10:22:59 +0530
Message-ID: <000001d8dd2d$57d6a060$0783e120$@samsung.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Thread-Index: AQJKGaiSsiqhKxku7uYTSPaoJqYSAAESoaKbAd+H3XmtDpGHcA==
Content-Language: en-in
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 105P
DLP-Filter: Pass
References: <CGME20221010123120epcas5p3ba947a3a982bc6a78310472c2a65ebfe@epcas5p3.samsung.com>
        <20221010120438.80680-1-p.rajanbabu@samsung.com>
        <ebf9e667-6b08-4a04-2241-04295cc28058@linaro.org>
Precedence: bulk


> -----Original Message-----
> From: Krzysztof Kozlowski =5Bmailto:krzysztof.kozlowski=40linaro.org=5D
> Sent: 10 October 2022 06:54 PM
> To: Padmanabhan Rajanbabu <p.rajanbabu=40samsung.com>;
> robh+dt=40kernel.org; krzysztof.kozlowski+dt=40linaro.org;
> alim.akhtar=40samsung.com; chanho61.park=40samsung.com;
> linus.walleij=40linaro.org; pankaj.dubey=40samsung.com
> Cc: devicetree=40vger.kernel.org; linux-kernel=40vger.kernel.org; linux-
> samsung-soc=40vger.kernel.org
> Subject: Re: =5BPATCH=5D arm64: dts: fix drive strength macros as per FSD=
 HW UM
>=20
> On 10/10/2022 08:04, Padmanabhan Rajanbabu wrote:
> > In FSD pinctrl implementation, the pinctrl driver is using drive
> > strength MACROs, which are deviating from the actual values specified
> > in FSD HW UM
>=20
> But you are changing DTS, not pinctrl driver. The message is a bit confus=
ing.
Sorry about the commit description. I'll update it to reflect the right con=
text.
>=20
> Add full stop to the sentence.
okay
>=20
> >
> > This patch adds the right pinctrl drive strength values for FSD SoC.
> > This
>=20
> Do not use =22This commit/patch=22.
> https://protect2.fireeye.com/v1/url?k=3D7c0c10dd-239729b8-7c0d9b92-
> 000babff32e3-25043687ce355c88&q=3D1&e=3D110f55cc-c214-4bfd-b74b-
> 928d7f2efcbc&u=3Dhttps%3A%2F%2Felixir.bootlin.com%2Flinux%2Fv5.17.1%2F
> source%2FDocumentation%2Fprocess%2Fsubmitting-patches.rst%23L95
Okay.
>=20
> > patch also ensures that the peripherals are using right drive strength
> > MACROs in-order to function as expected
>=20
> Full stop
Okay.
>=20
> Which commit introduced it? Add a Fixes tag.
I'll add the fixes tag.
>=20
>=20
> >
> > Signed-off-by: Padmanabhan Rajanbabu <p.rajanbabu=40samsung.com>
> > ---
> >  arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi =7C 34 +++++++++++---------=
--
> >  arch/arm64/boot/dts/tesla/fsd-pinctrl.h    =7C  6 ++--
> >  2 files changed, 20 insertions(+), 20 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi
> > b/arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi
> > index d0abb9aa0e9e..e3852c946352 100644
> > --- a/arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi
> > +++ b/arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi
> > =40=40 -55,14 +55,14 =40=40
> >  		samsung,pins =3D =22gpf5-0=22;
> >  		samsung,pin-function =3D <FSD_PIN_FUNC_2>;
> >  		samsung,pin-pud =3D <FSD_PIN_PULL_NONE>;
> > -		samsung,pin-drv =3D <FSD_PIN_DRV_LV2>;
> > +		samsung,pin-drv =3D <FSD_PIN_DRV_LV4>;
>=20
> Are you sure? The original commit used here value of =222=22, your change=
 also
> set value of =222=22, so what deviates from actual values?
The intention of the patch is to change the value of MACROs as well as name=
 of the MACROs
according to the FSD HW user manual.
>=20
> You need to describe better the problem.
In the next version, I'll update the problem description in a much better w=
ay.
>=20
> Best regards,
> Krzysztof
Thanks for quick review.

Regards,
Padmanabhan R.