Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   David Laight <David.Laight@ACULAB.COM>
To:     'Leon Romanovsky' <leon@kernel.org>, Rui Ma <Rui.Ma@amd.com>
CC:     "helgaas@kernel.org" <helgaas@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
        "Alexander.Deucher@amd.com" <Alexander.Deucher@amd.com>,
        "bhelgaas@google.com" <bhelgaas@google.com>
Subject: RE: [PATCH] PCI/IOV: Decrease VF memory BAR size to save host memory
 occupied by PTEs
Thread-Topic: [PATCH] PCI/IOV: Decrease VF memory BAR size to save host memory
 occupied by PTEs
Thread-Index: AQHY3WXQJdhdERmAOESu97r3UBgaK64JE0ig
Date:   Tue, 11 Oct 2022 11:48:05 +0000
Message-ID: <da760d45e4714a289220591a0f2efb97@AcuMS.aculab.com>
References: <20221011112325.992317-1-Rui.Ma@amd.com> <Y0VVXB0XTobClVJo@unreal>
In-Reply-To: <Y0VVXB0XTobClVJo@unreal>
Accept-Language: en-GB, en-US
MIME-Version: 1.0
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Precedence: bulk

From: Leon Romanovsky
> Sent: 11 October 2022 12:37
> 
> On Tue, Oct 11, 2022 at 07:23:25PM +0800, Rui Ma wrote:
> > In some certain SR-IOV scene, when the device physical space(such as Video
> > RAM)is fixed, as the number of VFs increases, some device driver may decrease
> > actual BAR memory space used by each VF. However, the VF BAR memory mapping is
> > always based on the usual BAR probing algorithm in PCIe spec. So do not map this
> > unneeded memory can save host memory which occupied by PTEs. Although each PTE
> > only occupies a few bytes of space on its own, a large number of PTEs can still
> > take up a lot of space.
...
> > +    /*
> > +     * Some SR-IOV device's BAR map range is larger than they can actually use.
> > +     * This extra BAR space occupy too much reverse mapping size(physical page
> > +     * back to the PTEs). So add a divisor shift parameter to resize the request
> > +     * resource of VF according to num of VFs.
> > +     */
> > +	u16 shift = 1;

Why u16??

> > +		virtfn->resource[i].end = virtfn->resource[i].start + (size >> (shift - 1)) - 1;

The 'shift - 1' may require a mask.

...
> > +struct virtfn_get_shift_methods {
> > +	u16 vendor;
> > +	u16 device;
> > +	u16 (*get_shift)(struct pci_dev *dev, u16 arg, int arg2);

More pointless u16 - they just make the code larger.

...
> > +static inline u16 virtfn_get_shift(struct pci_dev *dev, u16 arg1, int arg2)
> > +{
> > +	return (u16)1;
> 
> <...>
> 
> > +	return (u16)1;
> 
> Why do you need these casts? You can omit them.

Kill all the u16

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)