Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 11 Oct 2022 14:37:26 +0200
From:   Sebastian Reichel <sre@kernel.org>
To:     Tony Lindgren <tony@atomide.com>
Cc:     Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        =?utf-8?Q?Beno=C3=AEt?= Cousson <bcousson@baylibre.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Rob Herring <robh+dt@kernel.org>, devicetree@vger.kernel.org,
        linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] ARM: dts: omap3-n900: fix LCD reset line polarity
Message-ID: <20221011123726.elsr53ue7nxzhvww@mercury.elektranox.org>
References: <20221004213503.848262-1-dmitry.torokhov@gmail.com>
 <Y0UDEtQlN5Y9h7BU@atomide.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="st6zuozv63braxzg"
Content-Disposition: inline
In-Reply-To: <Y0UDEtQlN5Y9h7BU@atomide.com>
Precedence: bulk


--st6zuozv63braxzg
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

On Tue, Oct 11, 2022 at 08:45:54AM +0300, Tony Lindgren wrote:
> * Dmitry Torokhov <dmitry.torokhov@gmail.com> [221004 21:26]:
> > The LCD driver (panel-sony-acx565akm), when probing, starts with line
> > driven low, and then toggles it to high and keeps it there. Also, the
> > line is driven low when powering off the device, and ls released when
> > powering it back on. This means that the reset line should be described
> > as "active low" in DTS. This will be important when the driver is
> > converted to gpiod API which respects the polarity declared in DTS.
>=20
> We should ensure these patches get merged together with the driver
> change to avoid breaking LCD for booting. Probably no need to have
> the driver quirk handling for inverted polartity in this case.
>=20
> It's probably easiest to have an immutable branch for the driver
> changes I can base the dts changes on. Or I can ack the dts changes
> if they get merged with the driver.

Both drivers are already using gpiod API:

drivers/gpu/drm/panel/panel-sony-acx565akm.c
drivers/gpu/drm/panel/panel-dsi-cm.c

So this just breaks things.

-- Sebastian

--st6zuozv63braxzg
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAmNFY3gACgkQ2O7X88g7
+ppABg//U+RTuiDkx3hmsy4n39Pd+7oMisWb9D2dE4ILhkVJFHwuG66GIO8nBwMa
YBLWUuS/5y60Uz6TZWzGJ3eYQk9V7KLXs9TGThqy1luG/sbQA7PC1VoUDsaIaiF0
GgIlkW7/H8oEcoCnMTR2dzHWm5DtJ9ElcamJvZTYIVtLWx9eErVkfViD12imESc1
C3EhdFp3fdaBlj5R17BaBEBXDW8abHZ49S2erL9PopRd4WpKCBBgVPbFaoetAEuQ
hlDWiC1TrthF2aMr6EaXjSVtdK+dpi9lkYOAvQedFvAfzszC9LB0gfebMuD0dm0M
baNelPT/rHt/ppNbq7CEVyglQ3gJ0guKnLYPLs8CTuHYJa0FGFnB3qObVi7mA0cp
oQOkFdUxVuTDFspyjl2PqTDn94bLG8W4Pqh5jNcauKn0gRJqV2An8dnNMZoVGtq3
DTRZCTgcPKDjxjNVA5E1ClLiDuf+JvXUVvqU1IFmGZuPbuqRyi6P5zcInmoX+MJA
Uh0t+HmdzKmygU7EKvDDmVClazfGGOUfEIfBSalJ+5ul/nKBcMsvVH9yj8y2P91R
grHGqbtNHenjfniU1qEqVDWTeKdlMztQ6NTNBjMLn3pBao4WN4weE+Pc2r0kdxwF
8bKhFGxxvJdNg2kbjX1xoxQGyRy0yGAQW4GV38+9sS05U+yebLM=
=l0si
-----END PGP SIGNATURE-----

--st6zuozv63braxzg--