Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <ba47d079-6d97-0412-69a0-fa15999b5024@amd.com>
Date:   Tue, 11 Oct 2022 18:49:55 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.1
Subject: Re: [PATCH v2] perf: Rewrite core context handling
Content-Language: en-US
To:     Peter Zijlstra <peterz@infradead.org>
Cc:     acme@kernel.org, alexander.shishkin@linux.intel.com,
        jolsa@redhat.com, namhyung@kernel.org, songliubraving@fb.com,
        eranian@google.com, ak@linux.intel.com, mark.rutland@arm.com,
        frederic@kernel.org, maddy@linux.ibm.com, irogers@google.com,
        will@kernel.org, robh@kernel.org, mingo@redhat.com,
        catalin.marinas@arm.com, ndesaulniers@google.com,
        srw@sladewatkins.net, linux-arm-kernel@lists.infradead.org,
        linux-perf-users@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
        linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org,
        sandipan.das@amd.com, ananth.narayan@amd.com, kim.phillips@amd.com,
        santosh.shukla@amd.com, Ravi Bangoria <ravi.bangoria@amd.com>
References: <20221008062424.313-1-ravi.bangoria@amd.com>
 <Y0VTn0qLWd925etP@hirez.programming.kicks-ass.net>
From:   Ravi Bangoria <ravi.bangoria@amd.com>
In-Reply-To: <Y0VTn0qLWd925etP@hirez.programming.kicks-ass.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QkRlTlFhRlFtQjlWcHB3MDlEZ0RSRFZ4dUFYVVNWU0pzLzgyZTJ0a0RVYXFu?=
 =?utf-8?B?L3haUUlORlVlYllFYnRya0FpMXcxNUFLQzBheUVhV0Y1Y1lGLyt2TjZrKzBm?=
 =?utf-8?B?MEJTcnNWMy91Z0twMWZnbnQ4bGJlbTFZV2FRbStaRGpLc1hPVm9JS0k0bGpW?=
 =?utf-8?B?ZlNWd1orcUNhRFZJMXB2a25iWElsZHRnTmZ2Y0lENWFMbkpYWlBFRTA1UTV0?=
 =?utf-8?B?QUdadjFmTm1HeTgzUE5sWDVZZW83RHpUT20xY2Z5Mk5La2VteEhZMEYyVGZj?=
 =?utf-8?B?QVhFbTlybW5nRXQ1QXBpMzNqOTYvRm9kbEFiazNHVlppRlNLblZGbTl5RzA3?=
 =?utf-8?B?T3BvdjhtbVhhbDIrL1RGVFVaOUZybVM0V3VrN1JKRHAzR2trT1VLaWFDczd1?=
 =?utf-8?B?ZUlZcE0vZENHWm9LZUtMOHBydHQ3azdOZm9Td0R1WUNMMVJVcEs4SytqMzZB?=
 =?utf-8?B?Mmx1T29IVUJ5RVpLTXA4bXN3aG80YlRrM0duYWRCeCt6U21saEh1MmdGcDFQ?=
 =?utf-8?B?OHJZVmlWZ0cyNGpyaGdQUWE5ZmFJYk9iT2dxbDBjb1Q5Vmp4djdxeHBZUFpM?=
 =?utf-8?B?bWVvdE9FK2NoZ0R4VlRNdDRMUDc2REhmc3RPR0pWWVVkSU1PQ2NISWJwZ28w?=
 =?utf-8?B?ZUNhWUxidWpGQVBCRlM4Z1Ywb0ViQUFOU0tvcHNSYTZRVXBiT3htQjB1OGI5?=
 =?utf-8?B?UFlYWUdldXBjdVVMNHpjSFVaOUQzcnFZSDlQUXZZUnhtNGtKdmdmWmYxUG5u?=
 =?utf-8?B?VndHdHl4Q2RTS0M1VTJGdkdhQ1NvZ3lLWjMwTTFWM1FtWFlpWlhDZ1RBN2pH?=
 =?utf-8?B?N0lJMDcxeWh2SGkreGtGQSt4emJZNzNYczZ1RWxJVUpaTzM1NUl0Wkc4STVE?=
 =?utf-8?B?Ulc4ajlZRzdYL2tWVHV6RFYwR0tRRHpvamhZVnFqdzU5aloxWHhLSzVwODg5?=
 =?utf-8?B?YjVUMDZ6Tkc3OWtZeG9GZVZLVjl3cVZ6dXRpU244d2FkVGZyMWJxVDB0RWpN?=
 =?utf-8?B?d3loWndqU1ZlUFNlUy9CTnF3SmhqYzhxVUZEbHFhTDRWVVd2NHcvNGpiTnpY?=
 =?utf-8?B?KzROa1ZWV2xnK0I3bzZSSzVWRmRycEUxbFFqSyt6L2dUQmdWMTFGQTAwSnZu?=
 =?utf-8?B?U09BYWtLSVJxcHhWVnM5Sjd0aFQ0UjJqOFVueHRvUGdDMnp2eEoyK2FHQUtL?=
 =?utf-8?B?Z0FzWTU2UEp1QStIb0kzNkhzUXZ6YjhWOTRiNnI0Njg1RTZiVlR5UnJ6cXpl?=
 =?utf-8?B?VHJ1bDZNNkZjK3RxRGl3TzRVYXBsZE81UVJMYVh6QW9qWEdUbTJtajcreXJI?=
 =?utf-8?B?bGFQMm5ZOXlSV2gzNXJmdlNJcGd0YnJUM0o0M2l0UG5uamtBMytpdWVSSkNo?=
 =?utf-8?B?ZXJkZit4L3dSb2ZZYzdvSXM3b3BEVVRpWXlRbFBScGhVWEhOSFBydXd3OTdp?=
 =?utf-8?B?TjdqMWR1OVRCY3c2S3JCMHF4ZlFjRHYvdXJzWEVRYkMwL0RYTFBQblhLczNv?=
 =?utf-8?B?QXF0Y1QvZ3lydmsrMVdQKzJOZ3Z0VnhhMUg2enlVNzJXRnZsSG1oNmdVRjlx?=
 =?utf-8?B?Q0U2TXRHdElHNzJPWHI0VXE2YzhYdVAwR091c01qR3pMc0YvKzVPTkU1cW1z?=
 =?utf-8?B?TzJJSXFTZXkxeW1COUZPNjNrMHc4cS9sVGVjY000ay9McWd2eUVmWGU1Z0xt?=
 =?utf-8?B?RGZCY2FMeU9QNlZFU3k3VXhSQlRETTc3QkpvdnhxY3Z2Y0RaZXdKalpkTWY3?=
 =?utf-8?B?aVY0UzdYMkFvdlZQa0pXWkpZM21vcHR5eHFvODRTcUlRMDBQRU5rYk5JMDFY?=
 =?utf-8?B?eWhuK2cxV0tUMnhKdWVHb1hKc21QOEFpRXRBQ3pjRmhlM1c0bnE2NWtUNk03?=
 =?utf-8?B?VWxDWlhRMmk3RDcxWkFOQ3JIUVdKeUNhTW1TK1ZxUyswbU15cFQ1aFlZbjFI?=
 =?utf-8?B?aGVMOGVBcDlSOStYeityTmlKMFk2SEQ4N2Qzc0NyM3doSlllbDc3QUdxVXVr?=
 =?utf-8?B?T3NqQktmNFpiNEsrSDNwVmYxUVpobVR1Rk9CaGlzUkI4dTVhTkx1ZXE1blNt?=
 =?utf-8?B?a0owTHhabDNNb2ZSWXBsL3RJTi81d3plOUFQcDladFRZZXY4K29PYTU3VUlK?=
 =?utf-8?Q?Ya8tjN8RI7HBLbsMjTJB7vsBg?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0644ac64-882f-4178-1562-08daab8b5530
X-MS-Exchange-CrossTenant-AuthSource: PH7PR12MB6588.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2022 13:20:14.7020
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 633TzDeNA+t7Oo8jETcdVLvVZ3APB2kjakF0s3ssc1IGMgxziBLNTWsl9E+isqFoWH/FB8weL8TwUKpWXiZMRQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB7381
X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 11-Oct-22 4:59 PM, Peter Zijlstra wrote:
> On Sat, Oct 08, 2022 at 11:54:24AM +0530, Ravi Bangoria wrote:
> 
>> +static void perf_event_swap_task_ctx_data(struct perf_event_context *prev_ctx,
>> +					  struct perf_event_context *next_ctx)
>> +{
>> +	struct perf_event_pmu_context *prev_epc, *next_epc;
>> +
>> +	if (!prev_ctx->nr_task_data)
>> +		return;
>> +
>> +	prev_epc = list_first_entry(&prev_ctx->pmu_ctx_list,
>> +				    struct perf_event_pmu_context,
>> +				    pmu_ctx_entry);
>> +	next_epc = list_first_entry(&next_ctx->pmu_ctx_list,
>> +				    struct perf_event_pmu_context,
>> +				    pmu_ctx_entry);
>> +
>> +	while (&prev_epc->pmu_ctx_entry != &prev_ctx->pmu_ctx_list &&
>> +	       &next_epc->pmu_ctx_entry != &next_ctx->pmu_ctx_list) {
>> +
>> +		WARN_ON_ONCE(prev_epc->pmu != next_epc->pmu);
>> +
>> +		/*
>> +		 * PMU specific parts of task perf context can require
>> +		 * additional synchronization. As an example of such
>> +		 * synchronization see implementation details of Intel
>> +		 * LBR call stack data profiling;
>> +		 */
>> +		if (prev_epc->pmu->swap_task_ctx)
>> +			prev_epc->pmu->swap_task_ctx(prev_epc, next_epc);
>> +		else
>> +			swap(prev_epc->task_ctx_data, next_epc->task_ctx_data);
> 
> Did I forget to advance the iterators here?

Yeah. Seems so. I overlooked it too.

Thanks,
Ravi