Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp2261262rwi; Tue, 11 Oct 2022 06:51:52 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5iu/3+dK61sFw7yInYi2ybVm3nIxnnsW0gd+bcxJ7fwMBHKjeG/qGW0alHCjhyKvBwBpE7 X-Received: by 2002:a17:902:7c91:b0:17f:6711:1fac with SMTP id y17-20020a1709027c9100b0017f67111facmr24717598pll.118.1665496312027; Tue, 11 Oct 2022 06:51:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1665496312; cv=none; d=google.com; s=arc-20160816; b=m2Rm/pGymc2YNbkf1oE0wgEgjCpxxA1WQHGMQBL9dfZb3J4x5dcHx0I6eYlkNCWlNI ZQWEKoJJ0GbmdTmCMQMspUCJDRV1xX/ODWu82iiApSpLMWVj0yibMEaKfYl+wW51w7Hm +tiXaBAjy4mJ1B4vZcdhVDV7VmSwozA6XILEZtfHeBle9YH9FDPkyGw/ymGHSZonBd6p 48T3mmz9quT7bO/aOT5UWInDfnYw44fCPgSilGxSEnYiVfsUhgykQwsHzT1sK2oG2GQd 8x+t5Dj0rLvv9+u98oMngSWuCpVKuDvQQnW4HL4LP8wgdGv0Um5SaSBVH9OT8/N8jgZf DAKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=aSMPgjswa0b5a8/jRySNmwzxT/MJQufut7Bj0GfUTMc=; b=TO9AjmuKCjBicNp8VKpefg8gCGvX7VDRvG82nm+yPBwlqFDdjKPQiMfZ/Pcp1ml/l0 Qp+OlKKMqQsZwpULVFzrYQoaDL6tzIh/bsZrRC8c1vslUWPmywLJ3bwODb8Lhf2Xh7sS JnUAWlbGoDuwXgX0kPweuLOBlG1S6leNoC1ReuOBYNmKo10cc+EhRbX9JfOc1jNksQx4 C7Z0mjF2UNu33nm8Eae6VISelvBUtP4KyG/6joJtd2m/BQF/s/eiac6iQ0ItlqIBk/A+ 39jXVHqRyyuHo0S4xkBCVJuirOa6eUfqB4LUQNH5MlQD6LY9q+lRe+vz3OwyLCueoB+n kiBA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=zmGh1ZUW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p22-20020a170902b09600b00179ee311540si14169806plr.233.2022.10.11.06.51.32; Tue, 11 Oct 2022 06:51:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=zmGh1ZUW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229641AbiJKMo6 (ORCPT + 99 others); Tue, 11 Oct 2022 08:44:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37258 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229546AbiJKMoz (ORCPT ); Tue, 11 Oct 2022 08:44:55 -0400 Received: from vps0.lunn.ch (vps0.lunn.ch [185.16.172.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D93682EF2D; Tue, 11 Oct 2022 05:44:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=aSMPgjswa0b5a8/jRySNmwzxT/MJQufut7Bj0GfUTMc=; b=zmGh1ZUWlzJAhBOMGcl7GmO3FV FB75xhNGi0Z4LfgCJe8FTwOtMotLRvYYfbmG9/N5UpZJFVvszoNqhduCajBYsUzIluU3ZV5IurBjM xWuRuxV5fgdSd+eenZL2dre/OmgozZek88ADe41czljP3sej1qsvTTpcTsl++L46t8AE=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1oiEcl-001iF2-P1; Tue, 11 Oct 2022 14:44:43 +0200 Date: Tue, 11 Oct 2022 14:44:43 +0200 From: Andrew Lunn To: Matthias Schiffer Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Siddharth Vadapalli , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net] net: ethernet: ti: am65-cpsw: set correct devlink flavour for unused ports Message-ID: References: <20221011075002.3887-1-matthias.schiffer@ew.tq-group.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221011075002.3887-1-matthias.schiffer@ew.tq-group.com> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 11, 2022 at 09:50:02AM +0200, Matthias Schiffer wrote: > am65_cpsw_nuss_register_ndevs() skips calling devlink_port_type_eth_set() > for ports without assigned netdev, triggering the following warning when > DEVLINK_PORT_TYPE_WARN_TIMEOUT elapses after 3600s: > > Type was not set for devlink port. > WARNING: CPU: 0 PID: 129 at net/core/devlink.c:8095 devlink_port_type_warn+0x18/0x30 > > Fixes: 0680e20af5fb ("net: ethernet: ti: am65-cpsw: Fix devlink port register sequence") > Signed-off-by: Matthias Schiffer Reviewed-by: Andrew Lunn Andrew