Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp2268507rwi; Tue, 11 Oct 2022 06:58:04 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4m25NI1ZQG2cfWqMp/oBoiKXZ8SLcMSWq0/HBkpMppQ1qnRgclBvURN0hF3SYd0oatTgvv X-Received: by 2002:a17:907:75d8:b0:78d:3c2e:9a99 with SMTP id jl24-20020a17090775d800b0078d3c2e9a99mr18297312ejc.686.1665496683734; Tue, 11 Oct 2022 06:58:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1665496683; cv=none; d=google.com; s=arc-20160816; b=HrvXAJUAVeRnKoKxXsD1ZX8ZFzN7MSRJMJdBOFUu2ZxOCFhNoYDNlxwibUlNOmlYyj X6EXXUtw+YelLwkaPSryKzQEty4NBSbkZkQeJ/uETd+pAJ8zETdJ5A0WjLoQ0GuJmuvW 1liH35NTHx860WUN4AG33t6TRoXm5TgcxcqET+WkRB+fsWrw1m77XWxk/C+8C/EpPfvN Q7CuVTwcQvLByTjeDE3V8t1K2X8QPFZSQV8bDh/Syj5kRX63or2QrooaOBlqeC81LR50 c3Xa9AbPZCJ05lt2Hhuamob/vWW1VpqPOQjDA1KLRm0jbVR6xTP2p+M2jKJHGfMa9XwB WFXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=2O/sgWaGnO6z4AF/yeVmsjYkOvAsF7Wd+OoPbVTejeU=; b=Qnuk5A0RYy47MSJ+r7IY02QBWSUcYuKYF+0VXRqKEeCzj65vLALrI03EEoH3eHf3S9 7N8JUmTgzluDnidYeLlJCgXWR9DTbao7lHfu1czY2tSEe9YJ2lQnZjURYHpXRaU0fd2W aT66f2isnAHh0+Opr0b4fXTpV9UPXKvh8MY4RSWwycRjSnwK6sgQi6qgvqEQ9WayA/Ly +p8bGcWGwTeJ9VbuCxqyL8PnjXpdTzhz2relByOq8eRvZBb9+VtBtbiRBwxomw5Il9oI Zw03GO1uXVyKwv1MqqnaUxevA+GD5sOInOYC8pwiscDC/vFpsT4EZ5yC5VNs4ZUvofJQ MrgQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=Pj4BNK+r; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hv11-20020a17090760cb00b0077f7781816fsi13057745ejc.655.2022.10.11.06.57.37; Tue, 11 Oct 2022 06:58:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=Pj4BNK+r; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229921AbiJKNso (ORCPT + 99 others); Tue, 11 Oct 2022 09:48:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49830 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230004AbiJKNs0 (ORCPT ); Tue, 11 Oct 2022 09:48:26 -0400 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BD8AE77555; Tue, 11 Oct 2022 06:48:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1665496105; x=1697032105; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=QHbuyb2S/uUcVxyF/lwXUqAZuHdBPKm0sW+WbMyb3sc=; b=Pj4BNK+rzzSTyBXemPpBH2NMgeihtQKzOP08GkE32BBDFHsEGUAOjS/g YtBTzP+IhzjASx0CQoxtsOGSgggsc6r1ZngggideScpztEHBpvubxJvM/ PrBL8xLU0ZS173Xl1LBsRCKZZsUhVi7fKD8k2d9jHx/MqBAXkHRDZRdt4 jP4ZP+oPiaF9m0MFT6RAOay9XKsfteS6LOUKuYpRkK5k6bSbSgcvtu+/L naYmNshmjYqukJl6ZQrLY6QTS7HynU+I2J6mqh2J4UJJdOFmwMHwDGHsu Dh8DYhwk1KYkPnYhlJoeIytZJScs+etnJw5/us2S84x9IdC3nJtnr0iej Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10497"; a="303244167" X-IronPort-AV: E=Sophos;i="5.95,176,1661842800"; d="scan'208";a="303244167" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Oct 2022 06:48:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10497"; a="695068698" X-IronPort-AV: E=Sophos;i="5.95,176,1661842800"; d="scan'208";a="695068698" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga004.fm.intel.com with ESMTP; 11 Oct 2022 06:48:19 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1oiFcH-005KIR-1Z; Tue, 11 Oct 2022 16:48:17 +0300 Date: Tue, 11 Oct 2022 16:48:17 +0300 From: Andy Shevchenko To: Kent Gibson Cc: Bartosz Golaszewski , linux-gpio@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-actions@lists.infradead.org, linux-aspeed@lists.ozlabs.org, openbmc@lists.ozlabs.org, linux-rpi-kernel@lists.infradead.org, alsa-devel@alsa-project.org, patches@opensource.cirrus.com, linux-mediatek@lists.infradead.org, linux-mips@vger.kernel.org, linux-riscv@lists.infradead.org, linux-omap@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-msm@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-samsung-soc@vger.kernel.org Subject: Re: [PATCH v2 02/36] gpiolib: cdev: Add missed header(s) Message-ID: References: <20221010201453.77401-1-andriy.shevchenko@linux.intel.com> <20221010201453.77401-3-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 11, 2022 at 11:05:42AM +0300, Andy Shevchenko wrote: > On Tue, Oct 11, 2022 at 3:02 AM Kent Gibson wrote: > > On Mon, Oct 10, 2022 at 11:14:18PM +0300, Andy Shevchenko wrote: ... > > > -#include > > > #include > > > +#include > > > +#include > > > > Ok with the hte re-order. > > > > But moving the gpio subsystem header after the gpio/driver is not > > alphabetical ('.' precedes '/') and it read better and made more sense > > to me the way it was. > > I see, I guess this is vim sort vs shell sort. Strange, they should > follow the locale settings... I have checked, the shell and vim sort gave the same result as in this patch. -- With Best Regards, Andy Shevchenko