Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp2284501rwi; Tue, 11 Oct 2022 07:07:17 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7AQrpyfcgv9/FuM91G0CiS1pCMjS55YyC1KzbP8bmX6yT69VKzjmYHclK/JIVa8/cHCVSG X-Received: by 2002:a05:6a00:21c2:b0:52b:ff44:6680 with SMTP id t2-20020a056a0021c200b0052bff446680mr25791447pfj.57.1665497236718; Tue, 11 Oct 2022 07:07:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1665497236; cv=none; d=google.com; s=arc-20160816; b=uJlQdO8WLzYXjYhBP/Fdu2vNv2BH86JDdLEUmgjMGbJ2bKChFto/yridZvYxHahJrh sPQUr+BUCF3X+mEClOUjpbWxj9PuYqxVOMFSVeO/FhI2m4zMlpJxiFELL2iZ0jmnm+aN v0bkgf9svm0Jtw3ngjM3qBGPyrBakQ4SRIa0DBe7woLvF76XfjXl/56dtxXcPyJqm0Mv 5KYsisgD+aZhhu2S59VV0X6Q9UdL0ZByKOJ5phmUtcdhNga4olzvaSlMaTfA9mEDyk2W qOqlRdyMQ9vxoTLueKsh5sCCxRHyB6z56MlJCyPpFHvd0TpPx6pNzaFQzHZlC/c3b1YE oxFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=qumU7debCS+DOddWrWVWavmH1w79UYhLhWyOjNv83+g=; b=dYAoyJxDT1AKR5Wl1+PDK7COkZrN7Z3SmYiLnq2FZXC38mMx5qPNFEOI0PPBU78MGY 5I8PnHQ2gdIdVEbSp/LX7BF2gYdb4APuzlpZ0tiOr0c3SmSOloAhHWxty/GHM9cR5FUQ 92SQe90NPEws1qGbiJlSFcDxF1421gKETaIev+0YAOxI9+zdXO2asfreRKJYcCwDnXVS 7Z16i4026XOzSHGstN/Zjfsbdfa1cyuSB18wFdGUVS8gvHOiJ0kMAq4/qrCfXsqp9lrA Q2VtH/4mh7u4w0MENwqzoRmYiF0xp6vY4oaH8COkN2e7SRZ0gJeR3jrBB5FZ32nLh7Dt Rgbg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=desiato.20200630 header.b="jf/2rqKV"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d8-20020a056a0024c800b00557a43656c6si2371843pfv.109.2022.10.11.07.06.56; Tue, 11 Oct 2022 07:07:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=desiato.20200630 header.b="jf/2rqKV"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229456AbiJKOCW (ORCPT + 99 others); Tue, 11 Oct 2022 10:02:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52800 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229446AbiJKOCU (ORCPT ); Tue, 11 Oct 2022 10:02:20 -0400 Received: from desiato.infradead.org (desiato.infradead.org [IPv6:2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 65AFB6FA14 for ; Tue, 11 Oct 2022 07:02:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=qumU7debCS+DOddWrWVWavmH1w79UYhLhWyOjNv83+g=; b=jf/2rqKVoNpyd1A4Fem/70AwyL QBNF51RhZF93mzfHpCI6zCqNsWKeIV895ouyjGec+UXbujXWe2nGFDqhXwdkKoPWaN9kRnuf0dCuq 5zJwK+6rvtgyn/IePaj40XLMqcmvwIkyw7QucDNLPnYJLzVE070AGlQGtT7fXe99gQmWLtIk4BAY3 h0IOMIgU0fleq2tFwdKxyqPxQMJLF7fOsMbjppjJn0nikcf1GosBLMeHv+WV8EDhFtc/yYPDz5MVc Gyi3I4P2CsR2WKz1N//bFx/Ep8gJvJB4GXoQbiH6UmljvwoyVgA9php+S2tHGPvlmDKcO/QWgWDZT KTuncp7Q==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1oiFpN-002aTY-GS; Tue, 11 Oct 2022 14:01:49 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 9226F300422; Tue, 11 Oct 2022 16:01:46 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 7AA3E2997FB9B; Tue, 11 Oct 2022 16:01:46 +0200 (CEST) Date: Tue, 11 Oct 2022 16:01:46 +0200 From: Peter Zijlstra To: Zhang Rui Cc: Dave Hansen , Feng Tang , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H . Peter Anvin" , x86@kernel.org, linux-kernel@vger.kernel.org, tim.c.chen@intel.com, Xiongfeng Wang , Yu Liao Subject: Re: [PATCH] x86/tsc: Extend the watchdog check exemption to 4S/8S machine Message-ID: References: <20221009051209.393377-1-feng.tang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 11, 2022 at 09:33:26PM +0800, Zhang Rui wrote: > topology_max_packages() or variable logical_packages can tell the > maximum packages. > But this check_system_tsc_reliable() is done in early boot phase where > we have boot cpu only. And the cpu topology is not built up at this > stage. Is there a problem with disabling the TSC watchdog later in boot -- after SMP bringup for example?