Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <41663e73-6eb6-3624-7e7e-661745a72193@amd.com>
Date:   Tue, 11 Oct 2022 11:27:41 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.2
Subject: Re: [PATCH -next] drm/amd/display: Simplify bool conversion
Content-Language: en-US
To:     Yang Li <yang.lee@linux.alibaba.com>, alexander.deucher@amd.com
Cc:     sunpeng.li@amd.com, Rodrigo.Siqueira@amd.com,
        christian.koenig@amd.com, Xinhui.Pan@amd.com, airlied@gmail.com,
        daniel@ffwll.ch, amd-gfx@lists.freedesktop.org,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
        Abaci Robot <abaci@linux.alibaba.com>
References: <20221010073803.88244-1-yang.lee@linux.alibaba.com>
From:   Harry Wentland <harry.wentland@amd.com>
In-Reply-To: <20221010073803.88244-1-yang.lee@linux.alibaba.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UW5UdTNRR2RuTDBDczVydGpSK29pOGZlVGVUNHJVcTNzaTRUVXY0WWpKcHo3?=
 =?utf-8?B?cjVwYllOeHM0YTRJOVhneGhaZVR6TXZyMVFEY0RNSjJ4Wko2SlpoRmVORGxS?=
 =?utf-8?B?cTd6K09RQzh2eHo3bFpRRU84Nnl5Y0hPbVQ3SWhCWjg3K1BvWWRpZmx0OTht?=
 =?utf-8?B?VnlqNk15OXRFUmdpT1dyWEFnYldFTXdXR3phd1hvbjZtaXJzZ0RSWXBkWStw?=
 =?utf-8?B?UU55eS94TVo5ZnlnZGZSUDdadHlLMndmMFJYL0kxamtseEE5dUVxaHB3amJi?=
 =?utf-8?B?QVFjTzE0SWpqQ01QTXJONi9hczhLT05SbzZEM08xV1pJMEFQSGJSLytpdnNB?=
 =?utf-8?B?OFN1d2ZicFBheEUya3R0cEtPVUFzOTcycHRXRDFYcCsrQm53MkNGc1BVZzU4?=
 =?utf-8?B?MGZIb1ZkamVGL1FmbmhQR1FTNmdEZkowcEY0VmxtaG5BaTZXNEY5OVdIS01G?=
 =?utf-8?B?aERSS1djNitQeVdBa1pNK1dFQUEwRHJXTkgxbTV0S0pYSU1QSWVmYjlQNG1Q?=
 =?utf-8?B?NllaRFloajV0eDhDdzJKaWVIZldNY0VQRkZLczJwYVVySGlqbjBYWlhLOHAr?=
 =?utf-8?B?TGkvdXROVkhETFB1WVVwY2o3MDRVL1FXTVBjZElXR2IyRjRwcFZIK3RMcUN6?=
 =?utf-8?B?VThHNmI2RldhdXFVZlkwVU81OGd4RFVsdEpMelZ6VEROKzlRc0NpazhQdE5L?=
 =?utf-8?B?TTk4bGt2QzVwU0FlUXhIRlByOElOem9HYjZDRFpuNEwvMldZUHJEaEpFb3Zo?=
 =?utf-8?B?Q0R1dHJ2U3ZBSnlMeWdubWZnRFhGd1RGZnNCRUZQcUFHalRPV1pLSUpjRDg1?=
 =?utf-8?B?VkZDNVhLdUJmRDZaalI2b3dEM2IvY00zbU55dTJ3MTJDZitnSitPczJ0YnZu?=
 =?utf-8?B?Ukw3MjRoampHYmNzbkVqbitPZ2huQmE0NHpRMkU1KzJIdnd5MmFZYjlvells?=
 =?utf-8?B?b1NiOVlZUVhOS3BiOGRVMTZqSnM5ek5VUjR6TmN2OTZlUDBxQnY1Q1dZU1Ex?=
 =?utf-8?B?RlFPTCtmWjdNeEhWRVBFNEhxb3NyOWlhS1IzZkJzc3BCa0RTNEgvYkNHOEVv?=
 =?utf-8?B?NzBXZkdkUDVYQWdOdmpWWnBRTWNFRGNQaGNLTGVPYTBhZHZzbndoaUhnQk5H?=
 =?utf-8?B?NkdDQ2g5N0JYWXVNa09FQ0NCUDFqMFpiQ3B6OTErRGJsNVRtNklFcklUbzYx?=
 =?utf-8?B?VzNOZUdQeWRsK3FmMkdFSzVvUmlzME5pS2lIZUJtOFM1SXFlQis5ZXF0OGt5?=
 =?utf-8?B?blpUYnhtWklRbW03UGlkOWdNc3V3Sk5EYkhPWTV1aTg2dHZvcmVKaDF6aUNR?=
 =?utf-8?B?NmtDdFFLSTJUL2pWL3BsTW5OZ2QzTjZ0cDErZ3lob1Z6UkR1Wm1Zd2NYS0xh?=
 =?utf-8?B?Nmh6RTVKQzh5STkvSkRuaDdUQ1JISndvSFY5bTREeXFqbWhtaW9Lb2QvNXdL?=
 =?utf-8?B?ZGpkc2pOYVI2elhUQVFZZzZwMll1aXlZeE5MVzZHWEpOenQ0by9UWHg4UkJC?=
 =?utf-8?B?U054dnJ2RVdIUnVoaW9XQ21jemFUWGRSTHppcDQwVEtyL1V2dFFFTjhIN09L?=
 =?utf-8?B?Q0srb0poQzIzWUhEcGlxVXNhZGZBWjFVb1V3dlB5ZzlDNnBzUFV1akpwbE5u?=
 =?utf-8?B?VWhJVDdvUnc3a1dmWkExTm1qKy9jU3U5eXJmVVZ0L3d5L21HNVJXOVFTaDhU?=
 =?utf-8?B?WnhKN21VOHV2d2E4OUs5aTJacEgwRGJLdVpMM1cxSlo1ZUY4Vk85T1FXb0xl?=
 =?utf-8?B?ay96VGE1WTVkZVZWWUM4V1ZGOG1TdlljOTF0bExJYzdtcit4bUJaY09JcDg5?=
 =?utf-8?B?dEdzUVdDSHFNTnFscWp6cmFqKzZPWEQ0Y1hTdHJ6Y3RHOVVacG91V3NneDlF?=
 =?utf-8?B?SFZnSUFOR1lmSGVjMUdsOUQyRHIxMDZGdUFXN2Z5VENRSFFqY1ZscGVhcWFL?=
 =?utf-8?B?Sjg5eG1TTEJIRTFHNVVHL0tDYTUvSXdYNFNHOWgwc1ZWNjdJZGVmc0dQbWVp?=
 =?utf-8?B?WnVtUTIzWkRwcW52L2RqaUNrT3Qwakl0aXBVdzhrWnVqaVhkMkk3MVMxWnRQ?=
 =?utf-8?B?VXI1dmFlU01uQVRSc3U2VTQ5eUxPRE5JTU5kc3lYQUJvTjFpbzNxOWhJSndw?=
 =?utf-8?Q?8xR30ewxUMMTOUgBDjjUvlo/P?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 69a25e52-9317-4a02-a47e-08daab9d25e3
X-MS-Exchange-CrossTenant-AuthSource: CO6PR12MB5427.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2022 15:27:46.2580
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: IMIu5epWKlsQmB+8w2SaxdyMObl4jZ592EkcZnjSd8Q5572AbXMRSijAPlFmk+2N/j8oZxnvCd2DJ6P/8MoB2Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6325
X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2022-10-10 03:38, Yang Li wrote:
> The result of 'pwr_status == 0' is Boolean, and the question mark
> expression is redundant.
> 
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2354
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>

Reviewed-by: Harry Wentland <harry.wentland@amd.com>

Harry

> ---
>  drivers/gpu/drm/amd/display/dc/dcn32/dcn32_hwseq.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_hwseq.c b/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_hwseq.c
> index 955ca273cfe1..cbda458bf040 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_hwseq.c
> +++ b/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_hwseq.c
> @@ -1401,7 +1401,7 @@ bool dcn32_dsc_pg_status(
>  		break;
>  	}
>  
> -	return pwr_status == 0 ? true : false;
> +	return pwr_status == 0;
>  }
>  
>  void dcn32_update_dsc_pg(struct dc *dc,