Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20221010073803.88244-1-yang.lee@linux.alibaba.com> <41663e73-6eb6-3624-7e7e-661745a72193@amd.com>
In-Reply-To: <41663e73-6eb6-3624-7e7e-661745a72193@amd.com>
From:   Alex Deucher <alexdeucher@gmail.com>
Date:   Tue, 11 Oct 2022 11:58:54 -0400
Message-ID: <CADnq5_My7KXYqQ1SrGqK2nj4P67NUh1hoYD+C+BngRJNC9YcCg@mail.gmail.com>
Subject: Re: [PATCH -next] drm/amd/display: Simplify bool conversion
To:     Harry Wentland <harry.wentland@amd.com>
Cc:     Yang Li <yang.lee@linux.alibaba.com>, alexander.deucher@amd.com,
        sunpeng.li@amd.com, Abaci Robot <abaci@linux.alibaba.com>,
        Xinhui.Pan@amd.com, Rodrigo.Siqueira@amd.com,
        linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org,
        dri-devel@lists.freedesktop.org, daniel@ffwll.ch,
        airlied@gmail.com, christian.koenig@amd.com
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Applied.  Thanks!

Alex

On Tue, Oct 11, 2022 at 11:27 AM Harry Wentland <harry.wentland@amd.com> wrote:
>
> On 2022-10-10 03:38, Yang Li wrote:
> > The result of 'pwr_status == 0' is Boolean, and the question mark
> > expression is redundant.
> >
> > Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2354
> > Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> > Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
>
> Reviewed-by: Harry Wentland <harry.wentland@amd.com>
>
> Harry
>
> > ---
> >  drivers/gpu/drm/amd/display/dc/dcn32/dcn32_hwseq.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_hwseq.c b/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_hwseq.c
> > index 955ca273cfe1..cbda458bf040 100644
> > --- a/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_hwseq.c
> > +++ b/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_hwseq.c
> > @@ -1401,7 +1401,7 @@ bool dcn32_dsc_pg_status(
> >               break;
> >       }
> >
> > -     return pwr_status == 0 ? true : false;
> > +     return pwr_status == 0;
> >  }
> >
> >  void dcn32_update_dsc_pg(struct dc *dc,
>