Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp2534834rwi; Tue, 11 Oct 2022 09:55:26 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5qxbXWHkIEhorjjZ9uzTXPS9B/aCmL/coi823THO39J17N78B3hwhrIK3uK8g4iUC6J36K X-Received: by 2002:a17:907:3e9c:b0:78d:ce8b:8548 with SMTP id hs28-20020a1709073e9c00b0078dce8b8548mr5465039ejc.427.1665507325852; Tue, 11 Oct 2022 09:55:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1665507325; cv=none; d=google.com; s=arc-20160816; b=yPlhNTPj+Ln3du0kkZW1m3zY4nRA++s+Gb6QCg0YZTjDMAqN7bpU8RpYG1Qdhu4dXV 88o9qMpblWlqGknG5aImN8eSIBby4sYDpe3of08ZV63z2csbnR9AV9U177QYnqzQGfUs LkI91CZF2PRTNmzSiaHDnWylkX8riFjD2fcCxRSuSNyJZLnsHebn88HIqb03yNULvqZW MebGZaDnv9N3dFzNoQ5OXucSCaFKt3dkR+6I7vt6/rUk/MhrkK4h/pWZXG1P4S1KIX8T mx6q2BuVRIay9W4X23A6dLEetkJ1ocr0+sy+ywRg4AjMkRSU/AcT8bFy62OG89j+cKb0 0Plw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:sender:dkim-signature; bh=ADBsxLunge1AhqEpSVfGO0kFOloOABIAiXPDugpYJZk=; b=V27ZdT5LjtZ/fg7DaFuI2bvVUO9nKRGh6po0gPMLehuuZKryegOwxkOuuuhj1q0Ygw 4DGpvJt/0Zaca5UfAZXkzfvf4J59QdLvJrAoCsCJR2nMrKuvMzfvSKHW5L5LTolOJUsC tTRFoN61+BaGloyQvM2K3uuRhOb3aB1/pZGaLxfevtg0YLlIOHMiOg/Qem1Pl7heJEvZ YdtAdvGyW4AaFDzkTrz0X6puIGUEZDgEdXdRBVVFYOhQf2vOQhdpRUJSQAKAfflnAGEL plvIsbJzXkSnOgOQ2+fONbIBcvYiuYkd9ANEwq0bTuS4UlKeJcrblQCbT67Jv7bE82vH Ixfg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=XEG0+rif; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id dd21-20020a1709069b9500b0078db717cf44si4969703ejc.303.2022.10.11.09.54.58; Tue, 11 Oct 2022 09:55:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=XEG0+rif; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229548AbiJKQvb (ORCPT + 99 others); Tue, 11 Oct 2022 12:51:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34820 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229532AbiJKQv2 (ORCPT ); Tue, 11 Oct 2022 12:51:28 -0400 Received: from mail-pj1-x1030.google.com (mail-pj1-x1030.google.com [IPv6:2607:f8b0:4864:20::1030]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9F69E42E6B; Tue, 11 Oct 2022 09:51:27 -0700 (PDT) Received: by mail-pj1-x1030.google.com with SMTP id fw14so12986927pjb.3; Tue, 11 Oct 2022 09:51:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=ADBsxLunge1AhqEpSVfGO0kFOloOABIAiXPDugpYJZk=; b=XEG0+rifCJBs/VBmh3mu4URmwTT/ffH/L1xVT0nYnfMdL2BvMHjdfRoyoRBRnB7RZ4 5BnpGQywEA/92cRoaZCZncGb9B0QnB/wtC85n5uLMYxEC2+B9ny+fQ+JvyO5w2UxNfCH yITSzjKTNhmdMRklBn3mf5s0m4hr1EL3TNjovWH297zbwGFOtErDgOjzLqcvo7XqrWVR 1mO90RNcL8plTUjxhbMb4SdUv9U9lJtg/TjZ7eNkJa273jilFF44fYe48Pjeo5VzTGyc EZjN7POAOMZAZ5DLeCfJJOR/UzUhHIqwSLGknhAXyfBZJngu4vROfvegVQdXt5YpVyEJ tW7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ADBsxLunge1AhqEpSVfGO0kFOloOABIAiXPDugpYJZk=; b=IckhE8arIfxb/rsxzErOp/d/yT+aYSokU0T+6ZQfyAx9j6WOJWPgi+YoRGpa9/SHhV Kl5hXBjcQBg1BjaEEaZmxUhHVfhhKvM6QjtnwE5AQ9Sh4hy9LJvgN0ku4S6KT+r8wPY1 srAKBSWzxrV7KTAsYFeZPhQQkeJB3KjEJiLfw/iUiHDLurkjqlPuy9MO5zXVAjwyUGWL S2OZDIamsXI+ukOcMUZ060V4ONIzpQuL7LFMM616iRF9ioNk8gJOiqKAgZK03ZIGKU2w Mi8rdF4t8KnG24e/kKkkD5SXdgvCAHosD3PLuxNdwivZHtiO5vLy3i/kT8RWDnNKdXca +lAw== X-Gm-Message-State: ACrzQf1WcEzNotTUG/lQw0zvC1Kf7pkiVoSo8/uIRdU7KulmkSW2qSdO LukeZr7WVIqvT2BJcV32vww= X-Received: by 2002:a17:902:724b:b0:183:16f:fae4 with SMTP id c11-20020a170902724b00b00183016ffae4mr8300979pll.88.1665507087030; Tue, 11 Oct 2022 09:51:27 -0700 (PDT) Received: from localhost (2603-800c-1a02-1bae-a7fa-157f-969a-4cde.res6.spectrum.com. [2603:800c:1a02:1bae:a7fa:157f:969a:4cde]) by smtp.gmail.com with ESMTPSA id w12-20020a170902e88c00b00176b3d7db49sm8978933plg.0.2022.10.11.09.51.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Oct 2022 09:51:26 -0700 (PDT) Sender: Tejun Heo Date: Tue, 11 Oct 2022 06:51:25 -1000 From: Tejun Heo To: Yosry Ahmed Cc: Zefan Li , Johannes Weiner , Yonghong Song , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Song Liu , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org Subject: Re: [PATCH v2 0/2] Support cgroup1 in get from fd/file interfaces Message-ID: References: <20221011003359.3475263-1-yosryahmed@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221011003359.3475263-1-yosryahmed@google.com> X-Spam-Status: No, score=-1.5 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 11, 2022 at 12:33:57AM +0000, Yosry Ahmed wrote: > commit f3a2aebdd6fb ("cgroup: enable cgroup_get_from_file() on cgroup1") > enabled using cgroup_get_from_file() and cgroup_get_from_fd() on > cgroup1, to enable bpf cgroup_iter to attach to cgroup1. > > Apparently, other callers depended on these functions only supporting > cgroup2, so f3a2aebdd6 was reverted. Instead, add new separate interfaces > that support both cgroup1 and cgroup2 and use them in bpf cgroup_iter. Applied to cgroup/for-6.1-fixes. Thanks. -- tejun