Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20221010092014.2229246-1-xiaolei.wang@windriver.com> <20221010145726.GD92394@ediswmail.ad.cirrus.com>
In-Reply-To: <20221010145726.GD92394@ediswmail.ad.cirrus.com>
From:   Adam Ford <aford173@gmail.com>
Date:   Tue, 11 Oct 2022 12:45:06 -0500
Message-ID: <CAHCN7xJbwhpL8sp6rn6D5G1PnLJTvaow_b0hF=Lv_AzcWsd4DQ@mail.gmail.com>
Subject: Re: [PATCH] ASoC: wm8962: Add an event handler for TEMP_HP and TEMP_SPK
To:     Charles Keepax <ckeepax@opensource.cirrus.com>
Cc:     Xiaolei Wang <xiaolei.wang@windriver.com>, lgirdwood@gmail.com,
        broonie@kernel.org, perex@perex.cz, tiwai@suse.com, steve@sk2.org,
        geert+renesas@glider.be, chi.minghao@zte.com.cn,
        patches@opensource.cirrus.com, alsa-devel@alsa-project.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, Oct 10, 2022 at 9:57 AM Charles Keepax
<ckeepax@opensource.cirrus.com> wrote:
>
> On Mon, Oct 10, 2022 at 05:20:14PM +0800, Xiaolei Wang wrote:
> > In wm8962 driver, the WM8962_ADDITIONAL_CONTROL_4 is used as a volatile
> > register, but this register mixes a bunch of volatile status bits and a
> > bunch of non-volatile control bits. The dapm widgets TEMP_HP and
> > TEMP_SPK leverages the control bits in this register. After the wm8962
> > probe, the regmap will bet set to cache only mode, then a read error
> > like below would be triggered when trying to read the initial power
> > state of the dapm widgets TEMP_HP and TEMP_SPK.
> >   wm8962 0-001a: ASoC: error at soc_component_read_no_lock
> >   on wm8962.0-001a: -16

Thanks for this.  I saw this same error, but the audio that I use
didn't appear impacted, so I just ignored it.

> >
> > In order to fix this issue, we add event handler to actually power
> > up/down these widgets. With this change, we also need to explicitly
> > power off these widgets in the wm8962 probe since they are enabled
> > by default.
> >
> > Signed-off-by: Xiaolei Wang <xiaolei.wang@windriver.com>
> > ---
>
> Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com>

Tested-by: Adam Ford <aford173@gmail.com>
>
> Thanks,
> Charles