Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp2689912rwi; Tue, 11 Oct 2022 12:00:00 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6KzmUceC/qtS1uyp91P5USdE8BSPENF8JjG5u2tOCaeton9xC9/AAsaoO/rxSAJsSV7eOS X-Received: by 2002:a17:902:f708:b0:178:9b70:310b with SMTP id h8-20020a170902f70800b001789b70310bmr24983148plo.65.1665514800463; Tue, 11 Oct 2022 12:00:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1665514800; cv=none; d=google.com; s=arc-20160816; b=HtFh5gYpoqo73vJYFpYQHOwLs6vdXRpiAVrUlq664PoVv2r6zZS2Z+3t49UrEzc7vr Tw8qJ8B9l/z9P1hMQE/84Z+q5Ok1cR+iKcM3/WGpbtRwqDnAd28iN3CkAe80Wme65j08 lizOIl13kt5kXHI82Hei1e/YmvDME/apALGIVcZUCJxfx6GbXxUMoqfAmDQsxCiDS07H 6KCwmT+l5ZJYA27/GPdoHAhHfS1yJp8rjGJCINCjcRKHUX9Tl5mBJ14JNC7pBmfuxuAD 3AY+j4tfmefbP4HhD3cBv9UIt4wNqYB2Ezq3SWwRdgkR697DS9kUbuRCUWLr9FmpQg69 ev3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:in-reply-to:message-id:date:subject :cc:to:from:dkim-signature; bh=jC9v6x5O9g4o36lTWYhNYvUXqkkWlvK03fmUWelD46Y=; b=zATeOht8v6XjKRx5tRC3Kw/F1OadkhvRz8nyLod6oQr+qkQE/8oBUTU6njmvSKbtEX 1hmV1wDIoyYWcf+TfQX7oXDMHgJh+nFsADVe7KqUR/SPRfGFAFIzSA7QWok3q/Km2QNW 2qiVUZdd13d0p73KDRAvQkNIe1VJo9RpZiuv+L5BN8FC56r4JCjBiMxFNdHfg6R/REnc Xx3kBvc8bPSMmqzW0hhjC9uYI9pb0Ra/eyAC05l1X5jJfse7U/P0Mm4YHCY2B8alGmFn Whl/a1CY8nC9qcM4z2aIs9VGgslNcVzX43HEyJ/n1XIwuyUyX9IsEy7w+WSsHQaahKBU kOSQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=QJXGNK69; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p20-20020a63fe14000000b0045a2d89c9cfsi16645888pgh.348.2022.10.11.11.59.47; Tue, 11 Oct 2022 12:00:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=QJXGNK69; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229910AbiJKSmf (ORCPT + 99 others); Tue, 11 Oct 2022 14:42:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46970 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229880AbiJKSmW (ORCPT ); Tue, 11 Oct 2022 14:42:22 -0400 Received: from mail-qt1-x82d.google.com (mail-qt1-x82d.google.com [IPv6:2607:f8b0:4864:20::82d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5F5617CB48; Tue, 11 Oct 2022 11:42:21 -0700 (PDT) Received: by mail-qt1-x82d.google.com with SMTP id r19so623140qtx.6; Tue, 11 Oct 2022 11:42:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=references:in-reply-to:message-id:date:subject:cc:to:from:from:to :cc:subject:date:message-id:reply-to; bh=jC9v6x5O9g4o36lTWYhNYvUXqkkWlvK03fmUWelD46Y=; b=QJXGNK69c45gXxMdpzsU32P1osw4qt8d4ezCrzK7p+V9A9LWM7zYJYKdkJi4RCVhU/ xlprNjlA0EEFoHkTc98wUvsr0TGnRoDMxZEQNJ/2AVBdNKFGpAKU6W1udWq4eeNdpFpj 3qLuT1Xli21zAtRxMdp8YsiAtmUKH5nPqzUL8MpDKW4sFAT+30a2U3pzok4z9qJGHjzk Lkh/5rsq73Ib6fXEJfZboA1ADYW8kK4sdtBUb1F3qYC8vqmiys/xoge+3oX4Eo0/beDF Sg+1iuecagwXvBNWP+pfASw79MbYknWYbyaFHSgHDDdB6bimib1Ir8YC2509qr+R4PaE 8x3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=references:in-reply-to:message-id:date:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jC9v6x5O9g4o36lTWYhNYvUXqkkWlvK03fmUWelD46Y=; b=x+i03wfxTVLadnNXxVBrvOU6f0Q25OC+G1K+skZriv+jIxTTA3AJUY2+hWivxPFZuo LbHRpxRubw9RYt6vBBT+rtcQH4bO+QY+jBslEHjjTbMR4Xx3yeUuGT2SB5wJ1uknxMzg X0Af4Y7rFuHP8CypQpghgULMX6WMuHMRgysiIseaczE9a4JB0irxBfelqNij+s/gjwe/ UJDdbLts6kwZlNqFtmGsMyJY2aXVatpGm+7R1sX6bp1ODMp/HisnWZ2BlS3GRFqmylYe SKYbqON/YuP1Cdln29FuzUWe8xQ6ETqYHcwp7AWx9NDAD9SYbtrOHXHyRVIHbNfxYtwV RwZQ== X-Gm-Message-State: ACrzQf1BTH0a0sOgpXviH1tXFzUqaUX760AiwTtHCfYYjo1so5CrkE84 ctsXtMNvu4p24yL0CU7jy+9LWIPqBDM= X-Received: by 2002:ac8:5751:0:b0:39c:b848:198f with SMTP id 17-20020ac85751000000b0039cb848198fmr2170312qtx.429.1665513739432; Tue, 11 Oct 2022 11:42:19 -0700 (PDT) Received: from stbsrv-and-01.and.broadcom.net ([192.19.144.250]) by smtp.gmail.com with ESMTPSA id fc8-20020a05622a488800b003938a65479bsm10961732qtb.10.2022.10.11.11.42.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Oct 2022 11:42:18 -0700 (PDT) From: Jim Quinlan To: linux-pci@vger.kernel.org, Nicolas Saenz Julienne , Bjorn Helgaas , Lorenzo Pieralisi , Cyril Brulebois , bcm-kernel-feedback-list@broadcom.com, jim2101024@gmail.com, james.quinlan@broadcom.com Cc: Florian Fainelli , Lorenzo Pieralisi , Rob Herring , =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= , linux-rpi-kernel@lists.infradead.org (moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE), linux-arm-kernel@lists.infradead.org (moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE), linux-kernel@vger.kernel.org (open list) Subject: [PATCH v2 4/5] PCI: brcmstb: Functions needlessly specified as "inline" Date: Tue, 11 Oct 2022 14:42:09 -0400 Message-Id: <20221011184211.18128-5-jim2101024@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20221011184211.18128-1-jim2101024@gmail.com> References: <20221011184211.18128-1-jim2101024@gmail.com> X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org A number of inline functions are called rarely and/or are not time-critical. Take out the "inline" and let the compiler do its work. Signed-off-by: Jim Quinlan Acked-by: Florian Fainelli --- drivers/pci/controller/pcie-brcmstb.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/pci/controller/pcie-brcmstb.c b/drivers/pci/controller/pcie-brcmstb.c index c7210cec1f58..e3045f1eadbc 100644 --- a/drivers/pci/controller/pcie-brcmstb.c +++ b/drivers/pci/controller/pcie-brcmstb.c @@ -723,7 +723,7 @@ static void __iomem *brcm7425_pcie_map_bus(struct pci_bus *bus, return base + DATA_ADDR(pcie); } -static inline void brcm_pcie_bridge_sw_init_set_generic(struct brcm_pcie *pcie, u32 val) +static void brcm_pcie_bridge_sw_init_set_generic(struct brcm_pcie *pcie, u32 val) { u32 tmp, mask = RGR1_SW_INIT_1_INIT_GENERIC_MASK; u32 shift = RGR1_SW_INIT_1_INIT_GENERIC_SHIFT; @@ -733,7 +733,7 @@ static inline void brcm_pcie_bridge_sw_init_set_generic(struct brcm_pcie *pcie, writel(tmp, pcie->base + PCIE_RGR1_SW_INIT_1(pcie)); } -static inline void brcm_pcie_bridge_sw_init_set_7278(struct brcm_pcie *pcie, u32 val) +static void brcm_pcie_bridge_sw_init_set_7278(struct brcm_pcie *pcie, u32 val) { u32 tmp, mask = RGR1_SW_INIT_1_INIT_7278_MASK; u32 shift = RGR1_SW_INIT_1_INIT_7278_SHIFT; @@ -743,7 +743,7 @@ static inline void brcm_pcie_bridge_sw_init_set_7278(struct brcm_pcie *pcie, u32 writel(tmp, pcie->base + PCIE_RGR1_SW_INIT_1(pcie)); } -static inline void brcm_pcie_perst_set_4908(struct brcm_pcie *pcie, u32 val) +static void brcm_pcie_perst_set_4908(struct brcm_pcie *pcie, u32 val) { if (WARN_ONCE(!pcie->perst_reset, "missing PERST# reset controller\n")) return; @@ -754,7 +754,7 @@ static inline void brcm_pcie_perst_set_4908(struct brcm_pcie *pcie, u32 val) reset_control_deassert(pcie->perst_reset); } -static inline void brcm_pcie_perst_set_7278(struct brcm_pcie *pcie, u32 val) +static void brcm_pcie_perst_set_7278(struct brcm_pcie *pcie, u32 val) { u32 tmp; @@ -764,7 +764,7 @@ static inline void brcm_pcie_perst_set_7278(struct brcm_pcie *pcie, u32 val) writel(tmp, pcie->base + PCIE_MISC_PCIE_CTRL); } -static inline void brcm_pcie_perst_set_generic(struct brcm_pcie *pcie, u32 val) +static void brcm_pcie_perst_set_generic(struct brcm_pcie *pcie, u32 val) { u32 tmp; @@ -773,7 +773,7 @@ static inline void brcm_pcie_perst_set_generic(struct brcm_pcie *pcie, u32 val) writel(tmp, pcie->base + PCIE_RGR1_SW_INIT_1(pcie)); } -static inline int brcm_pcie_get_rc_bar2_size_and_offset(struct brcm_pcie *pcie, +static int brcm_pcie_get_rc_bar2_size_and_offset(struct brcm_pcie *pcie, u64 *rc_bar2_size, u64 *rc_bar2_offset) { -- 2.17.1