Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 11 Oct 2022 19:45:06 +0000
From:   Sean Christopherson <seanjc@google.com>
To:     Carlos Bilbao <carlos.bilbao@amd.com>
Cc:     pbonzini@redhat.com, vkuznets@redhat.com, wanpengli@tencent.com,
        jmattson@google.com, joro@8bytes.org, linux-kernel@vger.kernel.org,
        kvm@vger.kernel.org, bilbao@vt.edu
Subject: Re: [PATCH] KVM: SEV: Fix a few small typos
Message-ID: <Y0XHwmNDJj68pKp5@google.com>
References: <20220928173142.2935674-1-carlos.bilbao@amd.com>
 <Y0W7J9+2P2u83EaD@google.com>
 <515927f6-a53e-519e-6d7b-80f26f6f8946@amd.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <515927f6-a53e-519e-6d7b-80f26f6f8946@amd.com>
Precedence: bulk

On Tue, Oct 11, 2022, Carlos Bilbao wrote:
> On 10/11/22 13:51, Sean Christopherson wrote:
> 
> > On Wed, Sep 28, 2022, Carlos Bilbao wrote:
> > > @@ -3510,7 +3510,7 @@ bool sev_snp_init_protected_guest_state(struct kvm_vcpu *vcpu)
> > >   	ret = __sev_snp_update_protected_guest_state(vcpu);
> > >   	if (ret)
> > > -		vcpu_unimpl(vcpu, "snp: AP state update on init failed\n");
> > > +		vcpu_unimpl(vcpu, "SNP: AP state update on init failed\n");
> > >   unlock:
> > >   	mutex_unlock(&svm->snp_vmsa_mutex);
> > > @@ -4170,7 +4170,7 @@ void sev_es_prepare_guest_switch(struct vcpu_svm *svm, unsigned int cpu)
> > >   	/* PKRU is restored on VMEXIT, save the current host value */
> > >   	hostsa->pkru = read_pkru();
> > > -	/* MSR_IA32_XSS is restored on VMEXIT, save the currnet host value */
> > > +	/* MSR_IA32_XSS is restored on VMEXIT, save the current host value */
> > >   	hostsa->xss = host_xss;
> > >   }
> > > @@ -4223,7 +4223,7 @@ struct page *snp_safe_alloc_page(struct kvm_vcpu *vcpu)
> > >   	 * Allocate an SNP safe page to workaround the SNP erratum where
> > >   	 * the CPU will incorrectly signal an RMP violation  #PF if a
> > >   	 * hugepage (2mb or 1gb) collides with the RMP entry of VMCB, VMSA
> > > -	 * or AVIC backing page. The recommeded workaround is to not use the
> > > +	 * or AVIC backing page. The recommended workaround is to not use the
> > >   	 * hugepage.
> > >   	 *
> > >   	 * Allocate one extra page, use a page which is not 2mb aligned
> > SNP support doesn't exist upstream, looks like this was generated against an SNP
> > branch.
> You're absolutely right. The only typo that's upstream is "currnet" in
> sev_es_prepare_switch_to_guest(). Not a big deal.

Ya, and that typo should (eventually) go away entirely:
https://lore.kernel.org/all/YzOTOzUzKPQSqURo@google.com