Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <515927f6-a53e-519e-6d7b-80f26f6f8946@amd.com>
Date:   Tue, 11 Oct 2022 14:22:46 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH] KVM: SEV: Fix a few small typos
Content-Language: en-US
To:     Sean Christopherson <seanjc@google.com>
Cc:     pbonzini@redhat.com, vkuznets@redhat.com, wanpengli@tencent.com,
        jmattson@google.com, joro@8bytes.org, linux-kernel@vger.kernel.org,
        kvm@vger.kernel.org, bilbao@vt.edu
References: <20220928173142.2935674-1-carlos.bilbao@amd.com>
 <Y0W7J9+2P2u83EaD@google.com>
From:   Carlos Bilbao <carlos.bilbao@amd.com>
In-Reply-To: <Y0W7J9+2P2u83EaD@google.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dDRhNk04THRJTUgvOVNteWV4VkR1c05Eb3o2TDdkVDZEUC9seUhxdzJCaGFX?=
 =?utf-8?B?WXZLMTljL2FRMHhSNU9DYzIxVDJxWGQ1dUFYV0xXSkwxRTRLcC9WUEtoQUY0?=
 =?utf-8?B?M0t0Q2o1NHVWQVg5RXZ3SWdGZ3NZSWl3RkdkNG1pTDl3SVBMRjZ1dXV2M2ZH?=
 =?utf-8?B?Wmo2WjFVdjVyTmNkZ05wbmlyWjFob0VwUEp3bnJrS2o2UEFrQ2VHbXA1NE0y?=
 =?utf-8?B?dTlOTko4QjdoSEhFY2EvRCtIU0xDR1JPcFVRYU5WUzQrMEowSzNYUlBrVnQy?=
 =?utf-8?B?M2dXakQ1WlVlV2FLZEEzM0MxMWh2bmdXTUppQzAwdWZlNCs0S25wVmZ4eTI3?=
 =?utf-8?B?MVprMS8zczQvVFJmTTNHS0Q3M0tTRGIwbFFRV2hya1Q1Rm8zWGFWaW5Ea0N6?=
 =?utf-8?B?Ti9ZcVloTXVmUjh4MXNUaTd3TTBMMGduVVorY2NtdENsc1hWWENQbFRBd2R2?=
 =?utf-8?B?SC9GR3NXZk8vc2Y3QzVnMUNyRXJncHlqWTNmQm5YUHp2SldMRU1ZTzk3dzJl?=
 =?utf-8?B?L0NBNlZabWQ0VkcwaTlrYjU5MHdxcDErM3N3NG03L09FT3ZUMitIdHFwZzF2?=
 =?utf-8?B?UWt5ejlxZ2c0ZG5UaWpLRS9EVlIxajc4Qmh0UzNKbk5McyttNi9peURCeGJj?=
 =?utf-8?B?YTNQY2VKU1N5Qm9VbWFuU2xGVm1YNnB1NjNFNVFmbE95YXJhY1BXTDZ5STBB?=
 =?utf-8?B?bGJDZG9OZHdCY3o2OW1Ud2NlZ09JVFNqZ2d5ck4zV2JZdWNXdEowNjNIR1hv?=
 =?utf-8?B?VWpVYVltLzI2eituckFuamxNOFJmMHVHcXVXbmFTa3RoclRVa3oxUm9LaitB?=
 =?utf-8?B?K1BQekZtREFSVGhJSFFWSk9YVG9vV0laOHVPTUF5SU5yc3ZVekJPUFBYR1Rp?=
 =?utf-8?B?eHFabXdEb3dVVlBWb2tPeEY0S0lBL2hOaHA5VUdQWEtTOVFKOUhKcEZGd0tt?=
 =?utf-8?B?NVBIZHd0MjFBWnF1TUJTamNJSDZiVTJjcjB5V284TWZqOHd3eTZKSXk3Zmxq?=
 =?utf-8?B?SEtQMUFEeDRIZVVINmFCWjVId3RCeHNNdnBHWnkwcVQ5dThMWU5JRVpkcXlt?=
 =?utf-8?B?d3RReUk5N2RwcjR6dklnN0xuaVFNSEpJUWdqOHRNTml0Mk84ZEZSRzB6L2l6?=
 =?utf-8?B?R3R4YXUxbTBIUlY2WUhpM24rUFl2TjFTcU5seU9MTTJtS0NWZnR0YXU1WWtv?=
 =?utf-8?B?TC9ZNG5qQllBMXdkcW1PSjBQWDNuWWtnKzBLUENGNDkwZi9iY1NUcUxEWFJS?=
 =?utf-8?B?NDJ2NUszSUlVSitxVHltcHBqdE9oTGUzZHNOVXBsYWhTVVJHSFhaSng1TXN3?=
 =?utf-8?B?dTVPK081eTJqODdmdno2TUNYTExoWnNQaXVUbXRodXpmQmZwazQySkJUbVRH?=
 =?utf-8?B?WEw3RXdsR3hUSVFqQ3kwamp1dU11MDduT3JGc2g5dmd6U0labjJjZVdYUDBE?=
 =?utf-8?B?S2dxd0dna3RLbFp0TEVKc0hoYmNNUG1EZTloaDNaRmdCZ1pGcC94U240d1VN?=
 =?utf-8?B?akJueUNMZTlURFhZa29tRVE1cWo0TFhoeTNLT3lpTzZmRHhubytIQ296VzhY?=
 =?utf-8?B?Wjh2eDRyYk5Lc0lNTExlV3F1Nk11T1l3MlBpZnhFd05rZ3hPM0ZlSDV4am5Y?=
 =?utf-8?B?Y0hwcU5LWGZqSzVueC9qTWdDaHdyVzJzbE9ZQzljVWtmVHRBdFpBTC9LV1Ir?=
 =?utf-8?B?UlNtQTJQT0dCbUdhTW1ibnJCWldYZlFjSUtSMzMvb1hDVDkybis0L21nSkpC?=
 =?utf-8?B?cWtzN21DQWdzK1F6enFoMnlhV250NlI2Z1I5Wlh3WGdxbWJkemlEM3JMWkhq?=
 =?utf-8?B?cEtCUkVQcXRrVmtmTWhlcytIVHB2MGt6VithN0xwYk5QM05YR1l3UFRBcEhW?=
 =?utf-8?B?U1J0NWFTNGl1YWxDUjIzU3lCV1M0N05kNzU5L2w3Wm1yLzl1eVR2UGsxMVI1?=
 =?utf-8?B?UERCaWFhYTAyVFRJRkZ6ZFNsWXRDQjZoL0ViOEpmSDFvNE5VU0hvOFJBN0cx?=
 =?utf-8?B?VHdsaSt4OGswbnJHZGkxOUpUZ2dXWkRiSjF6ODc3Y3BOVXpBS3BTUElnRlRw?=
 =?utf-8?B?a2xJaHBkN0k1L2k2dyt5UWttZzcwOVRBUS90UEp0VHZBNi9iaCttVklnNUJm?=
 =?utf-8?Q?uaza1LcuZU59yV3pUKEQw/AKt?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f71498c1-3ee0-4e98-36cf-08daabbdfb8e
X-MS-Exchange-CrossTenant-AuthSource: BL1PR12MB5874.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2022 19:22:48.5634
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: gbPi8XGL5ExdPho9BKN6JcAzBtjFXyARw0ZwJ2PelklUu47NS/7TXD10YwG+bae+ilw8Uk0HU0Kl7D81qmOyMQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB7654
X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 10/11/22 13:51, Sean Christopherson wrote:

> On Wed, Sep 28, 2022, Carlos Bilbao wrote:
>> @@ -3510,7 +3510,7 @@ bool sev_snp_init_protected_guest_state(struct kvm_vcpu *vcpu)
>>   
>>   	ret = __sev_snp_update_protected_guest_state(vcpu);
>>   	if (ret)
>> -		vcpu_unimpl(vcpu, "snp: AP state update on init failed\n");
>> +		vcpu_unimpl(vcpu, "SNP: AP state update on init failed\n");
>>   
>>   unlock:
>>   	mutex_unlock(&svm->snp_vmsa_mutex);
>> @@ -4170,7 +4170,7 @@ void sev_es_prepare_guest_switch(struct vcpu_svm *svm, unsigned int cpu)
>>   	/* PKRU is restored on VMEXIT, save the current host value */
>>   	hostsa->pkru = read_pkru();
>>   
>> -	/* MSR_IA32_XSS is restored on VMEXIT, save the currnet host value */
>> +	/* MSR_IA32_XSS is restored on VMEXIT, save the current host value */
>>   	hostsa->xss = host_xss;
>>   }
>>   
>> @@ -4223,7 +4223,7 @@ struct page *snp_safe_alloc_page(struct kvm_vcpu *vcpu)
>>   	 * Allocate an SNP safe page to workaround the SNP erratum where
>>   	 * the CPU will incorrectly signal an RMP violation  #PF if a
>>   	 * hugepage (2mb or 1gb) collides with the RMP entry of VMCB, VMSA
>> -	 * or AVIC backing page. The recommeded workaround is to not use the
>> +	 * or AVIC backing page. The recommended workaround is to not use the
>>   	 * hugepage.
>>   	 *
>>   	 * Allocate one extra page, use a page which is not 2mb aligned
> SNP support doesn't exist upstream, looks like this was generated against an SNP
> branch.
You're absolutely right. The only typo that's upstream is "currnet" in
sev_es_prepare_switch_to_guest(). Not a big deal.

Thanks,
Carlos