Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <2e38c0f1-1b6c-1825-12c1-5ad135865c0c@intel.com>
Date:   Tue, 11 Oct 2022 14:46:07 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.13.1
Subject: Re: [PATCH linux-next] iavf: Replace __FUNCTION__ with __func__
Content-Language: en-US
To:     <yexingchen116@gmail.com>, <anthony.l.nguyen@intel.com>
CC:     <davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
        <pabeni@redhat.com>, <intel-wired-lan@lists.osuosl.org>,
        <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        ye xingchen <ye.xingchen@zte.com.cn>
References: <20221011111638.324346-1-ye.xingchen@zte.com.cn>
From:   Jesse Brandeburg <jesse.brandeburg@intel.com>
In-Reply-To: <20221011111638.324346-1-ye.xingchen@zte.com.cn>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZWVZc3M5VDVGR3NzcW56L3dVbWVvNmtya3ZMVnMzUWRFVWY4V2p1TnFOUTIw?=
 =?utf-8?B?ZjVGNW9HZnFud29nSUdUeVJ4YjczMStMc0FHaCs1K3lkN2U4SGVIamJONThJ?=
 =?utf-8?B?Uno1cmVWdGZPbmxpSGlQNGFCUGVBTCt6aDFvbkxNTExOZm1GQXlEOU5GN0Zv?=
 =?utf-8?B?VEo5Q1UveVNleUx6eUp5WW9mUGE3UjN5bnMvcVFHUE1QZ3oxbFhrVUdsVTNI?=
 =?utf-8?B?d2JZSDVBb244RHBVaGMyaTFKOU5Eb043QTVlTmF5MDRqZnk1aGp6d09sQ0xN?=
 =?utf-8?B?bDcvUmhXYXV4eHVDSmlRRVBpaG9iUDZoMHFEVXVla3JXbHp3OURkcEJINDFu?=
 =?utf-8?B?ODVsTU8yYjdESzJSbnU5Z2ZZMkEvQ0VhcVFPT1NOZnI1T0VkZWpQT0wwUkUw?=
 =?utf-8?B?aUVpY1FnQnFQSXA5RnBLNkdoK1A2dXo2SlBua1Z2MWR4bDdYSm53U2I4Nitt?=
 =?utf-8?B?cnNNUWZvbGZhVGZDV2g1WGlNS09TTTI5T0VsbHBNVk84NGkyVFFvbHdwekFX?=
 =?utf-8?B?akl5UzVBU0dJZHowZC9QSFI5andjUjdlRDAxRXJ2ZU8rRHd5N3pVVFhHSXRx?=
 =?utf-8?B?aVpWbEN4V1NsTUMxN2lVekhFUStVL25OZVpBMWdETWl4ZVJkV2xxVkVYUGJO?=
 =?utf-8?B?dU5LZk9WMHdOUW5oRW9yaFlCcE13ZnhSc29mUHZPQXcyQ0V6TzJMajNTWVl2?=
 =?utf-8?B?UlMyeDVDa1RlRjhKd2NlSUlQZGQyWTJlU0M1VmgvcDlzVnFKeWNrMkZtdVhH?=
 =?utf-8?B?dVJnUFR2RHBWVFd2Wmkzbm9lQ2xSTDIvNU5XUTZiV1hEMWFhYitGU1NOaUZM?=
 =?utf-8?B?bEJTRkxUZkNjM2JVRm9YcXBSUktrNkwzSy9mT21Xam9sZjNIQlRWeWNIV252?=
 =?utf-8?B?N0FTeTR0NmlhdWxwSkZZektGOTFER3hvZUNRNmZ1NEF6TEhob1g5bU55T1Jw?=
 =?utf-8?B?dk1uQzRSbmFLbVN3TERlL08ycEZuc28zMWtuS2lBMmNYNG5tcVNtUUVjbUJ3?=
 =?utf-8?B?RE1lUW9LSFBsaWxPM1Rrd0JNWHVGYjFoeUl6YW43SytnR0gwZk5MbmgvVlBK?=
 =?utf-8?B?ZVVWeDhvNERodWRPa01zZkhCVjdJVFdMdGRGbUppcDY1Q2JmQkNsanVVbXNv?=
 =?utf-8?B?NVJLODJJU0V6RkNkVjAzbW1BUVZzV0dKL3BqaVhkQlFBdG5PZXh0M3ZuVHpw?=
 =?utf-8?B?cDhJTVhHV1lNRjhjRFBDZC93NDMrYUc0M0Z4blVTL0lGQjNNQ1N5Wk1VbnA5?=
 =?utf-8?B?MEo5dFFWNWg2dFhtSDZIVUNnQ1J2YlE5aTFzZnVzTDlUNTFuYlprSWs1VDE2?=
 =?utf-8?B?TEx5ek1xdjFqRTJ0bjZYdHZGemRyTTRGZVBYUzIzZ29EN1QwYnpZK2Ixc0Rh?=
 =?utf-8?B?WHFlWUk5U3d5M2VwSitPRmlCdGhBdDhweDJiUG5sdXQzUUNwRm8vcE8yMTdJ?=
 =?utf-8?B?YWpUa28za0ZDNzVNTVZsZFZQck9RQTkwTnRFdk5WV3c3M2lQNDl2UEVHN2ww?=
 =?utf-8?B?cEpUdlhQTEJkTXRQMy9JYXlFSmdPd0xMSGVzMzR0RFUrckVoNWpRYi9yRjlF?=
 =?utf-8?B?WWtwalFSSWZJMjZUdUVtenNDVExQaVNoNWd0QnR4QnBNLzdlQWlxck0wdUtI?=
 =?utf-8?B?N2NqajlNVmVqa0tobzYyUm1oVUVlY1d6VHhPbUN1azJYU1JneGhBT1VjSmZL?=
 =?utf-8?B?OWVmTXF4Zk0zKzk1eDFBYzRKd2JJZ1NZWW5Jb1ptb0FmbnZ3OHYydnQ4YW5N?=
 =?utf-8?B?cWNFL1hnelpZMkZxQVgwWTN0YytNQXBuR3VDbTI3bitScW14Mlk5Njh5MFhn?=
 =?utf-8?B?UnhmK3hzTnNGakRPM0hGaHlJRkphcVRKMUVKWE1MTVUwRGo3Wlo5NWV3YkVh?=
 =?utf-8?B?OHVVSnh4RnI5MTc2MXJRM3VxMWZOa3EwMlhnMFVmcUtKeXFhY3BNUnNlcVZN?=
 =?utf-8?B?ajhKN2lKdStWUC8veXE1V1YzMWVwUXVTU24weTRGUGVoeVkxZmxoRFR1RGxv?=
 =?utf-8?B?d1VsUERzcGJFN0R3anEyTmdEL3JRcHRZdWM4MHNLMWRkZjJYYUxrUHZGRjVa?=
 =?utf-8?B?cUg1YUNYYXN2TGlMMFNQM1ZUcTVkOHVlZFB3RUY5b3dsaWRObW9SaS9hcjJW?=
 =?utf-8?B?L1pKRlVSYmM0NU44anFDajhYT0lmWTlNWm1Ud2o1MVEvWEFxR3hxRnV4UXFo?=
 =?utf-8?B?ZGc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 3dbdb21f-8020-43e8-ec2b-08daabd2020a
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4914.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2022 21:46:09.3817
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /w47VSJIvZ+yORlel/yuFOSyVJhP26KCTP1/QVtb7cslatqLG1k97Ch9l41Ahr9JM3um4SIOYuRG0JZHZ7+lvlyMcasUH5m3gdjUp5C4wCw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4611
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 10/11/2022 4:16 AM, yexingchen116@gmail.com wrote:
> From: ye xingchen <ye.xingchen@zte.com.cn>
> 
> __FUNCTION__ exists only for backwards compatibility reasons with old
> gcc versions. Replace it with __func__.
> 
> Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
> ---
>   drivers/net/ethernet/intel/iavf/iavf_main.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/intel/iavf/iavf_main.c b/drivers/net/ethernet/intel/iavf/iavf_main.c
> index 3fc572341781..98ab11972f5c 100644
> --- a/drivers/net/ethernet/intel/iavf/iavf_main.c
> +++ b/drivers/net/ethernet/intel/iavf/iavf_main.c
> @@ -4820,7 +4820,7 @@ static void iavf_shutdown(struct pci_dev *pdev)
>   		iavf_close(netdev);
>   
>   	if (iavf_lock_timeout(&adapter->crit_lock, 5000))
> -		dev_warn(&adapter->pdev->dev, "failed to acquire crit_lock in %s\n", __FUNCTION__);
> +		dev_warn(&adapter->pdev->dev, "failed to acquire crit_lock in %s\n", __func__);
>   	/* Prevent the watchdog from running. */
>   	iavf_change_state(adapter, __IAVF_REMOVE);
>   	adapter->aq_required = 0;

yeah, how'd that sneak in there? Thanks!

Reviewed-by: Jesse Brandeburg <jesse.brandeburg@intel.com>