Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp2900612rwi; Tue, 11 Oct 2022 15:21:01 -0700 (PDT) X-Google-Smtp-Source: AMsMyM69fcDR+PGFEmnlQhhas/HFKzeTvwyJMFPwpwdzFIAfGxjThtvdIngxwwyVKg90uPajM3tt X-Received: by 2002:a05:6a00:a22:b0:54e:6a90:fbef with SMTP id p34-20020a056a000a2200b0054e6a90fbefmr26957233pfh.53.1665526851218; Tue, 11 Oct 2022 15:20:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1665526851; cv=none; d=google.com; s=arc-20160816; b=RIhkn7m/udAo36CniTPhoa2tHBqHKfchwJYqcNdWFUfiZnDtoQ4pAi1onTftWIlQBj SvkroLTUa2LWZPPok9aELJfKpnU7UGzoiBF0HFD40CxwAQq9v0HrL//uPdeo8D1Vexey MwfZ4cNUR0vvWMeTmorBNhaWT5YVzrrUUsqmDPrx/uASZ8WRb8LJQG0v3ktCfGaee+Xk k0QFlxqpEuIpzJbEgoYuWVV4QCYf+GEZJM8KQjexAK/JZVb3q9UbT/UkBEPKzWiKVD42 G7oKFr5s2j/1v20GCLmA1AQr7SPx+Wim8CnTHQHeHIXWvX3Yu2TDauNc5vM+oDtdvQnt I/Ng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=XOz+D3qN+D5XSjeZhjdEZw1Edyfh9x16KWqNTlE6IJw=; b=aRMV9IkIsMR4d6l34dbGK9z0N8fXiaKb3a99EI561RGJ2zVcBQEyReU/iZ3B5cTvo3 lh679dixwmbY6OI6Dvm9UgtuqZuNqAOeHFdq8BtaNA6Ya5qnLs2+TPCR9LoOKb+6D4g3 8hmmlTmmRF8ER2FnufzJXHr3NFfEYHWM8ZHMM7YvXCTyNFUvVBndeNSyFUSDJOZDjEWG A3ruUjyE5TtR49hTtrJ8FoDilz+mF1Qth6taV69mFWvfezKBzDuspjEtLY3dV1Lf9iSC YSGz7QZjEtxIl7CJAYl6LaZFKu+GHVaGfF+RhAO5O/RzJScPWy/VfxhJfMU/lIRAIFgZ 5RvA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b="Aa/p5F9D"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s29-20020a056a00179d00b00562d9cddbf9si15464409pfg.13.2022.10.11.15.20.38; Tue, 11 Oct 2022 15:20:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b="Aa/p5F9D"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229619AbiJKWSS (ORCPT + 99 others); Tue, 11 Oct 2022 18:18:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49226 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229436AbiJKWSQ (ORCPT ); Tue, 11 Oct 2022 18:18:16 -0400 Received: from mail-pf1-x42a.google.com (mail-pf1-x42a.google.com [IPv6:2607:f8b0:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B8B537FE67 for ; Tue, 11 Oct 2022 15:18:15 -0700 (PDT) Received: by mail-pf1-x42a.google.com with SMTP id g28so14780859pfk.8 for ; Tue, 11 Oct 2022 15:18:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=XOz+D3qN+D5XSjeZhjdEZw1Edyfh9x16KWqNTlE6IJw=; b=Aa/p5F9DamtX4hyjG7/mfBjsXWBhWtLfgJ3dAjOuAUZ3O+iUldUtQFsGg6WqSMXu8a 4+uh+1HwwGH6E9Cpwy4+aptXNfuwe45Cq3ozyLW4VPrFHbTrSzKMSow3QHPc6zoSHeOP o0J6gK1GRjNWF2b/sVBVesfl6JM9CPEB4UAIU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=XOz+D3qN+D5XSjeZhjdEZw1Edyfh9x16KWqNTlE6IJw=; b=l5uIurp/flQPMx4XNwK/QKyn8z2Ch8xmBPv1XsPZ/ghbK6YY6Hp0z969vpysMVLp1h ecy0O4k+S6RIWETf33o3Pk0uSP9yVZWOyNB98MiaNR3fTKRuCRmpd60AYyUD/kTJ9QUt SSXitXXWXuhvri4Tzp4c8+S41f1GIi8TFDdWMVRxNGVgMIzzD2pCKJee72yRiTc8JIpC 4oyGI0wAhPb/RDxE/cEEFO2iPaEduNGL9GY7DfJMQ2W2eC07UXyh9GGjmaGW66RSksAh BQSOQpb1FGzRi2+HpFw4KG+lKN8fqgeIOkpVjkKNPUpt2UXecGpQBsBw6zxavc4Ysae3 h0RQ== X-Gm-Message-State: ACrzQf2G9tu4KmJkpF9raebRez/MiIip7nFBySlsEICn+XYJc6CRDa+b Q92O5JANAe8NLnmONxhXD+EF8nZsi/k/DQ== X-Received: by 2002:a63:1a4c:0:b0:43b:e648:a7a4 with SMTP id a12-20020a631a4c000000b0043be648a7a4mr23134321pgm.7.1665526695285; Tue, 11 Oct 2022 15:18:15 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id b13-20020a1709027e0d00b00172973d3cd9sm9112009plm.55.2022.10.11.15.18.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Oct 2022 15:18:14 -0700 (PDT) Date: Tue, 11 Oct 2022 15:18:13 -0700 From: Kees Cook To: Paulo Miguel Almeida Cc: Christine Caulfield , David Teigland , cluster-devel@redhat.com, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH v5] [next] dlm: replace one-element array with fixed size array Message-ID: <202210111518.A6E8A0FD@keescook> References: <202210111305.743F591@keescook> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 12, 2022 at 09:23:14AM +1300, Paulo Miguel Almeida wrote: > One-element arrays are deprecated. So, replace one-element array with > fixed size array member in struct dlm_ls, and refactor the rest of the > code, accordingly. > > Link: https://github.com/KSPP/linux/issues/79 > Link: https://github.com/KSPP/linux/issues/228 > Link: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101836 > Link: https://lore.kernel.org/lkml/Y0W5jkiXUkpNl4ap@mail.google.com/ > > Signed-off-by: Paulo Miguel Almeida Reviewed-by: Kees Cook -- Kees Cook