Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   <Shravan.Chippa@microchip.com>
To:     <sakari.ailus@iki.fi>
CC:     <paul.j.murphy@intel.com>, <daniele.alessandrelli@intel.com>,
        <mchehab@kernel.org>, <linux-media@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <Conor.Dooley@microchip.com>,
        <Prakash.Battu@microchip.com>
Subject: RE: [PATCH v4] media: i2c: imx334: support lower bandwidth mode
Thread-Topic: [PATCH v4] media: i2c: imx334: support lower bandwidth mode
Thread-Index: AQHYzK9awxPJcnRsMkKQ3xMPRpeBzK3oO6wAgAjvzMCAAMuUgIAHULEggAHT6YCAD4HEwA==
Date:   Wed, 12 Oct 2022 09:27:58 +0000
Message-ID: <PH0PR11MB5611BE11C6F670971DCED30681229@PH0PR11MB5611.namprd11.prod.outlook.com>
References: <20220920051023.12330-1-shravan.chippa@microchip.com>
 <YymuoFhxHBQLAicQ@valkosipuli.retiisi.eu>
 <PH0PR11MB56118BCE8F6B5E045485A71C81529@PH0PR11MB5611.namprd11.prod.outlook.com>
 <YzHYi2FQN1R+Ge4w@valkosipuli.retiisi.eu>
 <PH0PR11MB5611B27A6A2EFA9ABD79AB5E81599@PH0PR11MB5611.namprd11.prod.outlook.com>
 <YzmD+yNv0Ryj/8IC@valkosipuli.retiisi.eu>
In-Reply-To: <YzmD+yNv0Ryj/8IC@valkosipuli.retiisi.eu>
Accept-Language: en-GB, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?zSZQEF0UB7Lh8e7IDsbBbpWtB8VwhrI7u2yJk7TCRZZ00/XlDA900nCHFg5M?=
 =?us-ascii?Q?ZedMVo98wFbD14ffRet7Ati68KIFg25FOLlSg0GbB4ccfLJr/IydtWR+7kxo?=
 =?us-ascii?Q?1svuSZgF8NjR+oSM4/l9HNOSPizgq2zWr+I4LNTM+3daWyUzVaOR/Dx8nDDn?=
 =?us-ascii?Q?ygqDUhoUaRBYRqdXhx9jTdqsFq0r5YyGFXGGZ0qytWPVOXyuXn/tKVH5Ucdo?=
 =?us-ascii?Q?58oKsz5HScw4EaujmNkTOzseNORSpShhN+61HmgMSWpmVUCiYPPQbzxSZ20A?=
 =?us-ascii?Q?8ntoAcDt9F6n3sHFn932JOSCwJeFNvd5AljpUxBS1nDgbx+VEGGlePNtmtbv?=
 =?us-ascii?Q?Hf/sj6RBP3UgCVDDB8Ohva3Q7w01e8fjKNgVOlbOJSdtjxXEEKp1mutOp0Y/?=
 =?us-ascii?Q?FVvpcsMBQTItMRL3SRaftcREsMz2Q7Sgf6jbByGmtCcy6FC0kDBOqDm4xi6b?=
 =?us-ascii?Q?HEU/Hh/qk0pt+1SZHCImhY14+VMdrw2was/fMBnHRYajNAx86duXbnHr/0zU?=
 =?us-ascii?Q?VQCrHbRiehDxuSjSlfhXy8TXLHURY2OKF1M2T0/AubWm2DEqUquh6zQvYkEE?=
 =?us-ascii?Q?zx37L7kXkFm7dd9eCJsJGM6tAKe8YfXWBIZe923kR1RikqVdeNyHIq15lVsI?=
 =?us-ascii?Q?J26rCiz83WoHYpY6husZtdTxzKJ6ktz+Xbjq3ZB+5UHSvuxY1xCg/p6UatT2?=
 =?us-ascii?Q?LQpBvWJz3fY1L08+I21drLX4D7hjmCwEu6R3oLNn0KiA3ZGg/Nh19G1J4mjF?=
 =?us-ascii?Q?8B3QnqKaMU4kL+84TSFDo6F9Ter+4m18sZD7hB7JkOqYFeufD6My+AgVXMxW?=
 =?us-ascii?Q?Z4rGeDQ+qYdJruZQWXirCj8Du8daO85nj01lQJsoEW7K6UnXyntz4ecPTCTu?=
 =?us-ascii?Q?t62nXJp3z/OHM+G+S60oDZD6zBVbLuhL6LjAAc15xm8WZZMJaB3jegnXYgCN?=
 =?us-ascii?Q?Hio8+ugb6/Ockp7YD9XClGab7lblViPePKdK91FIQju153SZIOqfXnncTlyF?=
 =?us-ascii?Q?Bil26XTdwEkBZozNUZ5RQShI5NSNk2tMctiZFY1rH1i0ASE4Oa56VKi363nI?=
 =?us-ascii?Q?+8cGf/Z/qxZaGOl/JatL+5oswMkofZhsNbtSTbQbiP1KEWpdKAbto8cCHZjG?=
 =?us-ascii?Q?GTBs51h2MhWcCjkEXpUOw4+aARnYWdRFZBLcQAmbJLE0hxKbOwCteX/buy85?=
 =?us-ascii?Q?Z05jkKWhFIJZWkl12fbT9FG4Y+bjjtFwyulotR5q/BSwJcypimC3+jpQNwuN?=
 =?us-ascii?Q?lufP1nX5JDShDMv3esEQ9Mq6BwGt46Bd/Ggdpwjym0x8WygC4dGQYcKertyt?=
 =?us-ascii?Q?AQPM9yEfPbiOsJsnS8EYbFhPUntMc18hrNXhEcjl/bfQz6oB7oWCWhH5rWcz?=
 =?us-ascii?Q?ox2ImaPqQT7yd4eLghZC6LCxJKfN6Tvkx1wens9U1pzbD75hT1XVq87vNisW?=
 =?us-ascii?Q?ZE13/AKxoS6tHNLyK/x5bmTCu18nkH7led6Ay7D6T59h3yUdsJYAwIysVsHo?=
 =?us-ascii?Q?9UmgbS5t3B8L+Cy5IxDI6kYR0p4mqFLmntvmf37xpgRcs8EsqDqBvsXY8Cz4?=
 =?us-ascii?Q?Rnr8OcQ+5wN/Zw5pNC0J2uqnd2D5fsTMBpvGdKqU?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5611.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7df2b3a1-fc36-4ef9-e460-08daac340d00
X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Oct 2022 09:27:58.2629
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: LDViVAlQ221GZQCwE9Eum7D2+87VzgAok6GfGhtuqQSS/BhsNsY4/Ue4QGqmCADgf9PohU6cQFTT8dB3zRww2ike4LyQgq39qUOlC8xtFMY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB6027
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,
        SPF_PASS autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> -----Original Message-----
> From: Sakari Ailus <sakari.ailus@iki.fi>
> Sent: 02 October 2022 05:59 PM
> To: shravan Chippa - I35088 <Shravan.Chippa@microchip.com>
> Cc: paul.j.murphy@intel.com; daniele.alessandrelli@intel.com;
> mchehab@kernel.org; linux-media@vger.kernel.org; linux-
> kernel@vger.kernel.org; Conor Dooley - M52691
> <Conor.Dooley@microchip.com>; Battu Prakash Reddy - I30399
> <Prakash.Battu@microchip.com>
> Subject: Re: [PATCH v4] media: i2c: imx334: support lower bandwidth mode
>=20
> EXTERNAL EMAIL: Do not click links or open attachments unless you know th=
e
> content is safe
>=20
> On Sat, Oct 01, 2022 at 08:51:46AM +0000, Shravan.Chippa@microchip.com
> wrote:
> > > > > > +     case MEDIA_BUS_FMT_SRGGB12_1X12:
> > > > > > +             return imx334_write_regs(imx334,
> > > > > > + raw12_framefmt_regs,
> > > > > > +
> > > > > > + ARRAY_SIZE(raw12_framefmt_regs));
> > > > >
> > > > > I think you'll also need changes to the pixel clock calculation.
> > > > >
> > > > In this driver pixel clock read only variable.
> > > > Pixel clock change maybe in different series.
> > >
> > > Please address it in this patch.
> > >
> > > Is the link frequency affected by this patch as well?
> >
> > I will try to modify my patch with the default link frequency
> > available in the driver
>=20
> Also check the frequencies the driver enables will be available in link-
> frequencies.

This patch is not affecting the default link frequency 891Mbps with input c=
lock frequency (24Mhz)
I have cross-checked with the present supported 3840x2160 resolution and im=
x334 UG.

Thanks,
Shravan

>=20
> --
> Sakari Ailus