Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <20f6407e-aecc-cd84-f57c-8f4f477630ab@datenfreihafen.org>
Date:   Wed, 12 Oct 2022 11:11:58 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.1
Subject: Re: [PATCH linux-next] ieee802154: cc2520: remove the unneeded result
 variable
Content-Language: en-US
To:     cgel.zte@gmail.com, varkabhadram@gmail.com
Cc:     alex.aring@gmail.com, davem@davemloft.net, edumazet@google.com,
        kuba@kernel.org, pabeni@redhat.com, linux-wpan@vger.kernel.org,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        Xu Panda <xu.panda@zte.com.cn>, Zeal Robot <zealci@zte.com.cn>
References: <20220912072041.16873-1-xu.panda@zte.com.cn>
From:   Stefan Schmidt <stefan@datenfreihafen.org>
In-Reply-To: <20220912072041.16873-1-xu.panda@zte.com.cn>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hello.

On 12.09.22 09:20, cgel.zte@gmail.com wrote:
> From: Xu Panda <xu.panda@zte.com.cn>
> 
> Return the value cc2520_write_register() directly instead of storing it in
> another redundant variable.
> 
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Xu Panda <xu.panda@zte.com.cn>
> ---
>   drivers/net/ieee802154/cc2520.c | 7 ++-----
>   1 file changed, 2 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/net/ieee802154/cc2520.c b/drivers/net/ieee802154/cc2520.c
> index c69b87d3837d..abe331c795df 100644
> --- a/drivers/net/ieee802154/cc2520.c
> +++ b/drivers/net/ieee802154/cc2520.c
> @@ -632,7 +632,6 @@ static int
>   cc2520_set_channel(struct ieee802154_hw *hw, u8 page, u8 channel)
>   {
>          struct cc2520_private *priv = hw->priv;
> -       int ret;
> 
>          dev_dbg(&priv->spi->dev, "trying to set channel\n");
> 
> @@ -640,10 +639,8 @@ cc2520_set_channel(struct ieee802154_hw *hw, u8 page, u8 channel)
>          WARN_ON(channel < CC2520_MINCHANNEL);
>          WARN_ON(channel > CC2520_MAXCHANNEL);
> 
> -       ret = cc2520_write_register(priv, CC2520_FREQCTRL,
> -                                   11 + 5 * (channel - 11));
> -
> -       return ret;
> +       return cc2520_write_register(priv, CC2520_FREQCTRL,
> +                                    11 + 5 * (channel - 11));
>   }
> 
>   static int

The patch itself looks good, but it does not apply here:

[stefan@localhost wpan-next]$ git am -s 
linux-next-ieee802154-cc2520-remove-the-unneeded-result-variable.patch
Applying: ieee802154: cc2520: remove the unneeded result variable
error: patch failed: drivers/net/ieee802154/cc2520.c:632
error: drivers/net/ieee802154/cc2520.c: patch does not apply
Patch failed at 0001 ieee802154: cc2520: remove the unneeded result variable

Against which tree did you make this patch? Could you please rebase 
against latest net-next or wpan-next?

regards
Stefan Schmidt