Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <67f722b4bfe84b01bbbf37258a278a68@zeku.com>
In-Reply-To: <67f722b4bfe84b01bbbf37258a278a68@zeku.com>
From:   Ulf Hansson <ulf.hansson@linaro.org>
Date:   Wed, 12 Oct 2022 12:09:27 +0200
Message-ID: <CAPDyKFpfm2i2u3BKCxFEA=qZ8GiOOryhHYKNt_yyMA51sxSLJw@mail.gmail.com>
Subject: Re: [PATCH] mmc: sdio: fix kernel panic when remove non-standard SDIO card
To:     =?UTF-8?B?5qyn6Ziz54Kc6ZKKKFdlaXpoYW8gT3V5YW5nKQ==?= 
        <ouyangweizhao@zeku.com>
Cc:     =?UTF-8?B?546L5aSn5a6HKEpvaG4gV2FuZyk=?= <wangdayu@zeku.com>,
        Sergey Shtylyov <s.shtylyov@omp.ru>,
        =?UTF-8?B?6ams5a6P5LyfKE1hdHRoZXcgTWEp?= <mahongwei@zeku.com>,
        Pierre Ossman <drzeus@drzeus.cx>,
        "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, 12 Oct 2022 at 03:50, =E6=AC=A7=E9=98=B3=E7=82=9C=E9=92=8A(Weizhao =
Ouyang)
<ouyangweizhao@zeku.com> wrote:
>
> 2022=E5=B9=B410=E6=9C=8811=E6=97=A5 22:41, Ulf Hansson <ulf.hansson@linar=
o.org> wrote:
> >
> > On Tue, 27 Sept 2022 at 04:04, Weizhao Ouyang <ouyangweizhao@zeku.com>
> > wrote:
> > >
> > > From: Matthew Ma <mahongwei@zeku.com>
> > >
> > > SDIO tuple is only allocated for standard SDIO card, especially it
> > > causes memory corruption issues when the non-standard SDIO card has
> > > removed since the card device's reference counter does not increase f=
or
> > > it at sdio_init_func(), but all SDIO card device reference counter ha=
s
> > > decreased at sdio_release_func().
> > >
> > > Fixes: 1a632f8cdc33 ("sdio: split up common and function CIS parsing"=
)
> > > Signed-off-by: Matthew Ma <mahongwei@zeku.com>
> > > Reviewed-by: Weizhao Ouyang <ouyangweizhao@zeku.com>
> > > Reviewed-by: John Wang <wangdayu@zeku.com>
> >
> > Apologize for the delay!
> >
> > Wow, that's a very old bug you fixed! However, it looks like the fixed
> > commit should be changed to 6f51be3d37df ("sdio: allow non-standard
> > SDIO cards").
>
> Thanks, I messed the tag.
>
> >
> > I tried to apply the patch, but the patch format seems to be corrupt.
> > Did you use git format-patch and did run ./scripts/checkpatch.pl on
> > it?
> >
>
> Yeah I used checkpatch.pl with strict mode to check this patch, and it
> has no obvious style problems. What's the format error you got?

ERROR: patch seems to be corrupt (line wrapped?)
#130: FILE: drivers/mmc/core/sdio_bus.c:291:
struct sdio_func *func =3D dev_to_sdio_func(dev);

total: 1 errors, 0 warnings, 9 lines checked

If you haven't read the submitting-patches guidelines [1], I strongly
recommend you to have a look.
For example, it explains why you should use git send-email, if you
aren't doing that already.

Kind regards
Uffe

[1]
https://www.kernel.org/doc/html/v6.0/process/submitting-patches.html