Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20221010074207.714077-1-svens@linux.ibm.com>
In-Reply-To: <20221010074207.714077-1-svens@linux.ibm.com>
From:   Masami Hiramatsu <masami.hiramatsu@gmail.com>
Date:   Wed, 12 Oct 2022 12:21:11 +0100
Message-ID: <CADyE4xEkQo+AEEbRwcsQDcU_tWAH_m-XE6iZYRnw97Hz9ZHxYA@mail.gmail.com>
Subject: Re: [PATCH] selftests/ftrace: fix dynamic_events dependency check
To:     Sven Schnelle <svens@linux.ibm.com>
Cc:     Steven Rostedt <rostedt@goodmis.org>,
        Ingo Molnar <mingo@redhat.com>, Shuah Khan <shuah@kernel.org>,
        "Masami Hiramatsu (Google)" <mhiramat@kernel.org>,
        linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Sven,

2022=E5=B9=B410=E6=9C=8810=E6=97=A5(=E6=9C=88) 8:42 Sven Schnelle <svens@li=
nux.ibm.com>:
>
> commit 95c104c378dc ("tracing: Auto generate event name when creating a
> group of events") changed the syntax in the ftrace README file which is
> used by the selftests to check what features are support. Adjust the
> string to make test_duplicates.tc and trigger-synthetic-eprobe.tc work
> again.
>
> Fixes: 95c104c378dc ("tracing: Auto generate event name when creating a g=
roup of events")
> Signed-off-by: Sven Schnelle <svens@linux.ibm.com>

Thanks for fixing it!

Acked-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>

> ---
>  .../testing/selftests/ftrace/test.d/dynevent/test_duplicates.tc | 2 +-
>  .../test.d/trigger/inter-event/trigger-synthetic-eprobe.tc      | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/testing/selftests/ftrace/test.d/dynevent/test_duplicat=
es.tc b/tools/testing/selftests/ftrace/test.d/dynevent/test_duplicates.tc
> index db522577ff78..d3a79da215c8 100644
> --- a/tools/testing/selftests/ftrace/test.d/dynevent/test_duplicates.tc
> +++ b/tools/testing/selftests/ftrace/test.d/dynevent/test_duplicates.tc
> @@ -1,7 +1,7 @@
>  #!/bin/sh
>  # SPDX-License-Identifier: GPL-2.0
>  # description: Generic dynamic event - check if duplicate events are cau=
ght
> -# requires: dynamic_events "e[:[<group>/]<event>] <attached-group>.<atta=
ched-event> [<args>]":README
> +# requires: dynamic_events "e[:[<group>/][<event>]] <attached-group>.<at=
tached-event> [<args>]":README
>
>  echo 0 > events/enable
>
> diff --git a/tools/testing/selftests/ftrace/test.d/trigger/inter-event/tr=
igger-synthetic-eprobe.tc b/tools/testing/selftests/ftrace/test.d/trigger/i=
nter-event/trigger-synthetic-eprobe.tc
> index 914fe2e5d030..6461c375694f 100644
> --- a/tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-s=
ynthetic-eprobe.tc
> +++ b/tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-s=
ynthetic-eprobe.tc
> @@ -1,7 +1,7 @@
>  #!/bin/sh
>  # SPDX-License-Identifier: GPL-2.0
>  # description: event trigger - test inter-event histogram trigger eprobe=
 on synthetic event
> -# requires: dynamic_events synthetic_events events/syscalls/sys_enter_op=
enat/hist "e[:[<group>/]<event>] <attached-group>.<attached-event> [<args>]=
":README
> +# requires: dynamic_events synthetic_events events/syscalls/sys_enter_op=
enat/hist "e[:[<group>/][<event>]] <attached-group>.<attached-event> [<args=
>]":README
>
>  echo 0 > events/enable
>
> --
> 2.34.1
>


--=20
Masami Hiramatsu
mailto:masami.hiramatsu@gmail.com