Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <62f485df-4f5e-64a2-1294-6e162de25556@arm.com>
Date:   Wed, 12 Oct 2022 12:13:36 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Subject: Re: [PATCH] perf: Fix "Track with sched_switch" test by not printing
 warnings in quiet mode
To:     linux-perf-users@vger.kernel.org, acme@kernel.org,
        namhyung@kernel.org
Cc:     linux-kernel@vger.kernel.org,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@kernel.org>, Ian Rogers <irogers@google.com>,
        Adrian Hunter <adrian.hunter@intel.com>
References: <20221012111025.30609-1-james.clark@arm.com>
Content-Language: en-US
From:   James Clark <james.clark@arm.com>
In-Reply-To: <20221012111025.30609-1-james.clark@arm.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 12/10/2022 12:10, James Clark wrote:
> Especially when CONFIG_LOCKDEP and other debug configs are enabled,
> Perf can print the following warning when running the "Track with
> sched_switch" test:

Oops got the wrong test name here and in the title. Should be "kernel
lock contention analysis test"

> 
>   Warning:
>   Processed 1378918 events and lost 4 chunks!
> 
>   Check IO/CPU overload!
> 
>   Warning:
>   Processed 4593325 samples and lost 70.00%!
> 
> The test already supplies -q to run in quiet mode, so extend quiet mode
> to perf_stdio__warning() and also ui__warning() for consistency.
> 
> This fixes the following failure due to the extra lines counted:
> 
>   perf test "lock cont" -vvv
> 
>   82: kernel lock contention analysis test                            :
>   --- start ---
>   test child forked, pid 3125
>   Testing perf lock record and perf lock contention
>   [Fail] Recorded result count is not 1: 9
>   test child finished with -1
>   ---- end ----
>   kernel lock contention analysis test: FAILED!
> 
> Fixes: ec685de25b67 ("perf test: Add kernel lock contention test")
> Cc: Namhyung Kim <namhyung@kernel.org>
> Signed-off-by: James Clark <james.clark@arm.com>
> ---
>  tools/perf/ui/util.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/tools/perf/ui/util.c b/tools/perf/ui/util.c
> index 689b27c34246..1d38ddf01b60 100644
> --- a/tools/perf/ui/util.c
> +++ b/tools/perf/ui/util.c
> @@ -15,6 +15,9 @@ static int perf_stdio__error(const char *format, va_list args)
>  
>  static int perf_stdio__warning(const char *format, va_list args)
>  {
> +	if (quiet)
> +		return 0;
> +
>  	fprintf(stderr, "Warning:\n");
>  	vfprintf(stderr, format, args);
>  	return 0;
> @@ -45,6 +48,8 @@ int ui__warning(const char *format, ...)
>  {
>  	int ret;
>  	va_list args;
> +	if (quiet)
> +		return 0;
>  
>  	va_start(args, format);
>  	ret = perf_eops->warning(format, args);