Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <bbf46b1b-0c1e-7232-ce53-37878f049cf1@amd.com>
Date:   Wed, 12 Oct 2022 07:59:02 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Subject: Re: [PATCH v3] xhci-pci: Set runtime PM as default policy on all xHC
 1.2 or later devices
Content-Language: en-US
To:     Mathias Nyman <mathias.nyman@linux.intel.com>,
        Mika Westerberg <mika.westerberg@linux.intel.com>
Cc:     Mathias Nyman <mathias.nyman@intel.com>,
        "Mehta, Sanju" <Sanju.Mehta@amd.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
References: <20221010160022.647-1-mario.limonciello@amd.com>
 <Y0T68lC6bUY7dg7D@black.fi.intel.com>
 <7c08c4c8-562d-553f-e513-c925080300a7@linux.intel.com>
 <MN0PR12MB6101ECEA1CCED9B65667031DE2239@MN0PR12MB6101.namprd12.prod.outlook.com>
 <7df4a91d-6829-5ebf-18ca-c0783c03f443@linux.intel.com>
From:   Mario Limonciello <mario.limonciello@amd.com>
In-Reply-To: <7df4a91d-6829-5ebf-18ca-c0783c03f443@linux.intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dVdxS3lsNEdoN1UwdkdwclVQc0dJQzNkbFJWeTBTcDRDNVJQdWFRZ2JCUmgv?=
 =?utf-8?B?a3FBa0ZGMTBzMitVUU9uY1BIRVdZWUtxbHVTU1BMNFl1cnoxenlJalc0OEgv?=
 =?utf-8?B?R05LWDBBWm0wcUQwQ1ZWMThWdEFUQ1RObmErRkZJU1JWaDBNejVQOWNrVG4x?=
 =?utf-8?B?TXRIemxRZThQZit6dndMT3QwbDJLQ2J2Z1hFTG9QazhNOXByTG1ER3JncjZH?=
 =?utf-8?B?TzNvdlhwVWFVU3prQnB3V05CTGU2WC9BbThxUC9KNzhxUkNxR2xaU1AvY3Zo?=
 =?utf-8?B?YWF2MFp2TkVXVWY3dkdxeVZGaCs5a2ZtVENtTHFoaHJVelhObXRKQTdFNnF0?=
 =?utf-8?B?U05wZXdKaUpWNUVsd2JsOHJPZEZ3TkFOcnFOUTk2c1JWWVovaDN0Z2liU2xt?=
 =?utf-8?B?Z2VvczFSNjBIODh2NlVWL0pYZ1NlNWRqclRTa1FoMlZPQzZLclZJR3RaZ2ZM?=
 =?utf-8?B?bVdzR0xta1Q0Z2tzeUZwbUczL3ZCV3ArSkI5NC9wMk9JZER2S0pNd1FTc0xq?=
 =?utf-8?B?MGpiVXJtNmZVY3JmS0w5dU1EVFpZeTc1NEVwWjlScTE5SSt2UlAyeVQ4Um5T?=
 =?utf-8?B?aDFlblR5TEtWU2dheXVRb3ZCQnBIODJvOElMTkVUSmMreGJvRHlWdjZrL2I4?=
 =?utf-8?B?b3F3dmFWeDMxVThSMDZYZmhpd2hKcTJ6NkpxSStGZ0lDTFhrNVoxY0tTdjgv?=
 =?utf-8?B?RFJ3NVl6NW96Nm9nRHhSNldwSjFBbHBoZUxHOFhlZWhUcDhPM0dER2Z3YUpn?=
 =?utf-8?B?eEZqVnY3b3ZjRmgzY042RTY2Z0ZsRG0vRGJOQjZxZEZpcXFCYWNXZGFhZTdM?=
 =?utf-8?B?dkNpODVGT3k3bER2VE96NjZhakt6ZG9tc0xCMEo5MDJweHNqNlVPNlMzemJY?=
 =?utf-8?B?N2plVTY0YXZXOURZTGhXUDNXU0ZtZDVsOEU4T0dOVVk1R3YxcGZFYks0TGRl?=
 =?utf-8?B?RkFxMWt5QzRoeXJycTV1d21FdGN2a3pvWlNBbisrcHBTY0M0NnZjRFJkNm5P?=
 =?utf-8?B?ZDdqME1adWs1MjgzWUYyYXVUait4ZjZJRGluZUh6U2RxR2trWmRjNzlmRHZ4?=
 =?utf-8?B?MFFZbU5Gd3JYWDFpd3NqUkU4bStJYWtlVUE5Vmhwb3hYQ2dOdmlSMTQycGlH?=
 =?utf-8?B?Z0VycEVhRTFBbEhJdmNIcFNuSXNhR0dUenNvSWNaZGZvZlhPSjdVV3llakJH?=
 =?utf-8?B?OW1OcmNuTGVQMTlCMW83MWpEVXhaRE82dUYraUQ0UE5Gei9kNDNGK3JHUGdo?=
 =?utf-8?B?YS9DelFpYnJqSkNNelNyRjVvOWI1Rktvd2VlRXBQbHI2akZicnBRZGxpZzBX?=
 =?utf-8?B?anAwUi9TVC93MXhWVjV4cWh2RmdsOCtJbVdENDNrZXZFK3U3Ri9RTnRucVBp?=
 =?utf-8?B?dlBacHhGcDRmVGxqQTBSaDhJTVNyV3B1ekVJcmI3ZjhyY3Niek1ZZHB2OVdj?=
 =?utf-8?B?NkZEREQrY1JnUlpsYUcyT1ZGcmM2elVHWlNUd1cxVTl1YlRjOER0am0wVXpi?=
 =?utf-8?B?UjZ4ckVKNkFaZGxVOTBnYXJRKy9TM3doQ3NtZHFvQ1VWYm10WVBpQmxKNGRU?=
 =?utf-8?B?WjFuSmdaZkdOcVB1TE9CYWdjRWJ6emxtcXI5dmFiQm4xZE9lM1podzMyVlNY?=
 =?utf-8?B?amp1V2g0bGJhZGZNSkRJTVRNWHU4a3I2RVEvTFhHVnFXWEFPSFNEMWtGdXpj?=
 =?utf-8?B?RG9uTTlWWXNVdTBrY3BWSlpPcjBBOUZtVkxlYTRRSTVqRXNVUHd1WThSS0JP?=
 =?utf-8?B?NXd2M0Y2dkJpZ0FzQmtFZTVBZDk0UzJGOVJYZlQ3V29YREZFYlpMdEZTcWhu?=
 =?utf-8?B?N1Yrc1h3b0ZjcjBYL0thcjUzeUdMZzYzemNsMXZNd1g3KzFPQnppOHJDRU9L?=
 =?utf-8?B?bERSUzUyRk4rWng4TXFzamhWdFJicmZKREJUaXpKamVsaHV4OHhCcDdIWHRU?=
 =?utf-8?B?YU16UkVLOTZOSkZEbWd4UXJNMWU0RlpiUFM3d1FxU0JJMzR2WDk3ekJTTXN2?=
 =?utf-8?B?bnUreDlGNTFqY3E0azBVbWZYQlhCMWF0VmhvakJtK0l5UDFtN1hFSDR1N2tj?=
 =?utf-8?B?SDIwOU1sUkl5NlRwaitPNVJQNldUbVRHRHMyRFA3ZXIvdEpIRXdvZjhLTFRH?=
 =?utf-8?Q?h7pgG9ptWWmlbtnO1kt17084w?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ddfef65e-bd33-43b2-0a98-08daac518b1e
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2022 12:59:05.4395
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: aFPwo9i+0sxqV+in8pIH+5p29dcMs75MATiREwyptnVkhba/7LSSci13JXTGEJ79m1l+rmyQPxeAssg5UW+eLQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB5060
X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 10/12/22 03:34, Mathias Nyman wrote:
> On 11.10.2022 19.46, Limonciello, Mario wrote:
>> [Public]
>>
>>> -----Original Message-----
>>> From: Mathias Nyman <mathias.nyman@linux.intel.com>
>>> Sent: Tuesday, October 11, 2022 08:16
>>> To: Mika Westerberg <mika.westerberg@linux.intel.com>; Limonciello,
>>> Mario <Mario.Limonciello@amd.com>
>>> Cc: Mathias Nyman <mathias.nyman@intel.com>; Mehta, Sanju
>>> <Sanju.Mehta@amd.com>; Greg Kroah-Hartman
>>> <gregkh@linuxfoundation.org>; linux-usb@vger.kernel.org; linux-
>>> kernel@vger.kernel.org
>>> Subject: Re: [PATCH v3] xhci-pci: Set runtime PM as default policy on 
>>> all xHC
>>> 1.2 or later devices
>>>
>>> On 11.10.2022 8.11, Mika Westerberg wrote:
>>>> On Mon, Oct 10, 2022 at 11:00:21AM -0500, Mario Limonciello wrote:
>>>>> For optimal power consumption of USB4 routers the XHCI PCIe endpoint
>>>>> used for tunneling must be in D3.  Historically this is accomplished
>>>>> by a long list of PCIe IDs that correspond to these endpoints because
>>>>> the xhci_hcd driver will not default to allowing runtime PM for all
>>>>> devices.
>>>>>
>>>>> As both AMD and Intel have released new products with new XHCI
>>> controllers
>>>>> this list continues to grow. In reviewing the XHCI specification 
>>>>> v1.2 on
>>>>> page 607 there is already a requirement that the PCI power management
>>>>> states D3hot and D3cold must be supported.
>>>>>
>>>>> In the quirk list, use this to indicate that runtime PM should be 
>>>>> allowed
>>>>> on XHCI controllers. The following controllers are known to be xHC 
>>>>> 1.2 and
>>>>> dropped explicitly:
>>>>> * AMD Yellow Carp
>>>>> * Intel Alder Lake
>>>>> * Intel Meteor Lake
>>>>> * Intel Raptor Lake
>>>>>
>>>>> Suggested-by: Mathias Nyman <mathias.nyman@linux.intel.com>
>>>>> Link:
>>> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fww
>>> w.intel.com%2Fcontent%2Fdam%2Fwww%2Fpublic%2Fus%2Fen%2Fdocum
>>> ents%2Ftechnical-specifications%2Fextensible-host-controler-interface-usb-
>>> xhci.pdf&amp;data=05%7C01%7Cmario.limonciello%40amd.com%7Cb286e9c
>>> 63e9e4c3a1a3708daab8a9b23%7C3dd8961fe4884e608e11a82d994e183d%7C0
>>> %7C0%7C638010909687542135%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC
>>> 4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%
>>> 7C%7C%7C&amp;sdata=CetIs1VuAqj8nNBoLnXaGncw6Sl4JcImYY67JpVxyjg%
>>> 3D&amp;reserved=0
>>>>> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
>>>>
>>>> Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
>>>
>>> Thanks, added to queue
>>
>> Thanks!
>> For my own clarity - is this something you'll still take to 6.1, or 
>> are you meaning
>> 6.2 queue at this point?
> 
> Was planning on sending it to usb-next after 6.1-rc1 is out, so ending 
> up in 6.2
> But if there's some benefit in having this already in 6.1 then I don't 
> object that either.
> 

It's a blocker causing higher power consumption on some of the affected 
platforms.  So if you're amenable, I would like to see it for 6.1 so 
these things have a better chance at passing energy certifications.

>>
>> This thread originated from enabling Pink Sardine.  Wherever it lands 
>> after it's
>> baked for $long_enough I would like to bring it back to stable 
>> eventually too.
>> If you think it's too risky for stable later on, can we do separate 
>> set of commits
>> that adds and then removes the IDs for pink sardine that can go to 
>> stable?  This
>> would at least mirror more closely what has been done historically for 
>> the other
>> USB4 products.
> 
> I think we can add this to stable. It's fine for Intel xHCI 1.2 hosts.
> 

OK thanks.