Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp3808962rwi; Wed, 12 Oct 2022 07:05:35 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5y9Weun/CwBrrDPYTnBTwyD+VFkkUg3uGMFoFHDUnxrG7wdEJ3ZZNz8apAP5QOBkb4UErC X-Received: by 2002:a05:6402:1d86:b0:457:e84:f0e with SMTP id dk6-20020a0564021d8600b004570e840f0emr27317733edb.241.1665583535127; Wed, 12 Oct 2022 07:05:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1665583535; cv=none; d=google.com; s=arc-20160816; b=IrPRe5FyxT5EqyLJT3vMyQ5bewv0y0MPCKwY1fKdyXnfcGREEeOoM80fN2DKdBS/hy I99SkY8icW+k/Qad+ncO4tlabEShSflEO5W1gKJWZvm8r4ps6Q1zYIlNkRuDn7f0f36x 8aCiXmIy15nsknhlNT4e4QmoIPZJGwJaphTeLO560AmRHnVwqOT3A0YeJv+8f6N5dHEX M5YTBFXVs2FEl/asR0EEA0CzY+4uQKyx4IeU3A6GLIh3bCZbZ5k+q1Q4GoPqTaqC/uiY 0wnIvny7tGdOLtLXkI+/7lVAaAJv1LG8hJQ94AxGezycXxf981SUwe88GSypiSb7mCp1 NyxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=v5YUZj2preUeh9QTI6ueyx+iJV4FKrSrouAkmiMJdSE=; b=aDJZ4VC/MqTsB5XKw+I7rbbPNLeeVNtkuqJ6tSbpvL5ijxgOVTrJsd3QsTxIlY1us2 uUXRXutALfrOCQH1KHZaxv3MX3dAOBzjGfmTzd6c9KcbAI9GK9PCo26rtdHNQlVDRp4e +u6gg6D9tVMKlYXsKZKxzh3AkxRYdImU527VsvqtNSvwTKtD8pcBQiQbGkARJXszRkAN PK+4Ljj7b7yzfkWwjsVD1fzPWcMT5V0erNaLng3CQZh6bZP7aKajRe7y+E4X134O7DyW sDBz1pSLsF3hmSPjuQDhlVrtbyyRGnWfqjDq3p6js6mBvjraSxEDYGe5ISzIYkhwB41K l5+Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@szeredi.hu header.s=google header.b=JerlzHUN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=szeredi.hu Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z23-20020aa7c657000000b0044e702cd711si13248327edr.98.2022.10.12.07.05.03; Wed, 12 Oct 2022 07:05:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@szeredi.hu header.s=google header.b=JerlzHUN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=szeredi.hu Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229547AbiJLNvN (ORCPT + 99 others); Wed, 12 Oct 2022 09:51:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47550 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229703AbiJLNvJ (ORCPT ); Wed, 12 Oct 2022 09:51:09 -0400 Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com [IPv6:2a00:1450:4864:20::62d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4194461B11 for ; Wed, 12 Oct 2022 06:51:06 -0700 (PDT) Received: by mail-ej1-x62d.google.com with SMTP id ot12so38167608ejb.1 for ; Wed, 12 Oct 2022 06:51:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=szeredi.hu; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=v5YUZj2preUeh9QTI6ueyx+iJV4FKrSrouAkmiMJdSE=; b=JerlzHUNFpL509UfrBoY2mMGhtVuc6daN7sp4Gk+s2hlIIcsYbx8ygP60vLtgvRyWd ZN0AJ4g2MaQIuvuGDCLBvji/aB51RrKDa8kl9XrIi0K61zMBbTV5T0aRPFfB5kmEpkAp aqz03VOaOYuGDyJOuYZmgL2YEV0GrVfcQ9ybw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=v5YUZj2preUeh9QTI6ueyx+iJV4FKrSrouAkmiMJdSE=; b=mPoyrVsuCjOIqo3sdYcWfXYVgILPF1Z9wZlvyeTwacvsxMpZhfKN/vSXX0AnEa87yj LAzpSzlESDaz+yXRArinKiXBwi20Hd3LeUpqz06WUgBjnYFDSC1d6O6y0SW9s2GqrEEO 4xiL38YeCSmZdTJuQh5a0kzT5L0SSIgafwAubktbQWPYODo0Wj6RT3G5e8mwH+pD1Zty jzJm7Q4e3YrAHxzfVXIFWgp9FBAWxJ1PBwtHz26w2XHcJl/m39PtUzIMSt0aTgVKQt7n 9i+5m6AseMefe/8gnMHg5+UWmRwxb3y6iIq23JmcXkTK/DJlA1lfzwRGGVFWTTustK4Y OvFA== X-Gm-Message-State: ACrzQf3mWmwm2MGf9eiIhitgHFE45PUv3Rj1sPUlQgXdSBV74ivSCtH5 9JGMPPW2r1ZehQM4Bqc/zlmQnHIKwYiyAlp8lrOKOg== X-Received: by 2002:a17:907:62a1:b0:781:b320:90c0 with SMTP id nd33-20020a17090762a100b00781b32090c0mr22056168ejc.255.1665582664889; Wed, 12 Oct 2022 06:51:04 -0700 (PDT) MIME-Version: 1.0 References: <20220928121934.3564-1-zhangjiachen.jaycee@bytedance.com> In-Reply-To: <20220928121934.3564-1-zhangjiachen.jaycee@bytedance.com> From: Miklos Szeredi Date: Wed, 12 Oct 2022 15:50:54 +0200 Message-ID: Subject: Re: [PATCH] fuse: always revalidate rename target dentry To: Jiachen Zhang Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Zhang Tianci Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 28 Sept 2022 at 14:20, Jiachen Zhang wrote: > > The previous commit df8629af2934 ("fuse: always revalidate if exclusive > create") ensures that the dentries are revalidated on O_EXCL creates. This > commit complements it by also performing revalidation for rename target > dentries. Otherwise, a rename target file that only exists in kernel dentry > cache but not in the filesystem may result in an EEXIST. "...will result in EEXIST if RENAME_NOREPLACE flag is used." Applied with the above change. Thanks, Miklos